<div class="socmaildefaultfont" dir="ltr" style="font-family:Arial, Helvetica, sans-serif;font-size:10pt" ><div dir="ltr" style="font-family:Arial, Helvetica, sans-serif;font-size:10pt" ><div dir="ltr" ><div>Hi All,</div>
<div> </div>
<div>please confirm on following</div>
<div><br>Boost-bus - compilation fails . Is it used? Should be archived @andrewj?</div>
<div> </div>
<div>Google-ipmi-i2c - code compiles well, complain in formatting script @<span><a data-hovercard-type="user" data-hovercard-url="/users/pstrinkle/hovercard" href="https://github.com/pstrinkle" target="_blank">pstrinkle</a></span><br>subsys_initcall(i2c_via_ipmi_init);^[[m^M<br>Traceback (most recent call last):^M<br> File "/home/lkammath/final_data/unit-test.py", line 826, in <module>^M<br> check_call_cmd("./format-code.sh", CODE_SCAN_DIR)^M<br> File "/home/lkammath/final_data/unit-test.py", line 229, in check_call_cmd^M<br> check_call(cmd)^M<br> File "/usr/lib/python2.7/subprocess.py", line 190, in check_call^M<br> raise CalledProcessError(retcode, cmd)^M<br>subprocess.CalledProcessError: Command '('./format-code.sh', '/home/lkammath/final_data/google-ipmi-i2c')' returned non-zero exit status 1^M<br>Traceback (most recent call last):^M<br> File "/home/lkammath/final_data/dbus-unit-test.py", line 91, in <module>^M</div>
<div><br>Inarp.git - Should be archived @andrewj?<br>Compilation issue<br>inarp.c: In function ‘arp_recv’:<br>inarp.c:433:4: error: taking address of packed member of ‘struct arp_packet’ may result in an unaligned pointer value [-Werror=address-of-packed-member]<br> 433 | &inarp_req.src_ip);<br> | ^~~~~~~~~~~~~~~~~<br>In function ‘do_ifreq’,<br> inlined from ‘get_local_ipaddr’ at inarp.c:182:7,<br> inlined from ‘arp_recv’ at inarp.c:419:7,<br> inlined from ‘main’ at inarp.c:480:4:<br>inarp.c:170:2: error: ‘strncpy’ output may be truncated copying 16 bytes from a string of length 16 [-Werror=stringop-truncation]<br> 170 | strncpy(ifreq->ifr_name, ifname, sizeof(ifreq->ifr_name));<br> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~<br>cc1: all warnings being treated as errors<br>make[1]: *** [inarp.o] Error 1<br>make[1]: Leaving directory `/esw/san5/lkammath/boost/inarp'<br>make: *** [all] Error 2</div>
<div>In CI environment<br>ool.la -lncurses -ltinfo -lcrypto^M<br>copying selected object files to avoid basename conflicts...^M<br>ar: `u' modifier ignored since `D' is the default (see `U')^M<br>make[4]: Leaving directory '/home/lkammath/final_data/ipmitool/src/plugins/lan'^M<br>Making all in lanplus^M<br>make[4]: Entering directory '/home/lkammath/final_data/ipmitool/src/plugins/lanplus'^M<br>/bin/bash ../../../libtool --silent --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I../../.. -I../../../include -g -O2 -Wall -Wextra -std=c99 -pedantic -Wformat -Wformat-nonliteral -MT lanplus_crypt_impl.lo -MD -MP -MF .deps/lanplus_crypt_impl.Tpo -c -o lanplus_crypt_impl.lo lanplus_crypt_impl.c^M<br>lanplus_crypt_impl.c: In function 'lanplus_encrypt_aes_cbc_128':^M<br>lanplus_crypt_impl.c:158:17: error: storage size of 'ctx' isn't known^M<br> 158 | EVP_CIPHER_CTX ctx;^M<br> | ^~~^M<br>lanplus_crypt_impl.c:158:17: warning: unused variable 'ctx' [-Wunused-variable]^M<br>lanplus_crypt_impl.c: In function 'lanplus_decrypt_aes_cbc_128':^M<br>lanplus_crypt_impl.c:233:17: error: storage size of 'ctx' isn't known^M<br> 233 | EVP_CIPHER_CTX ctx;^M<br> | ^~~^M</div>
<div><br>Smbios-mdr - @brad. Please confirm if used?<br>No automake env (make)</div>
<div> </div></div>
<div dir="ltr" ><div dir="ltr" style="font-family:Arial, Helvetica, sans-serif;font-size:10pt" ><div dir="ltr" style="font-family:Arial, Helvetica, sans-serif;font-size:10.5pt" ><div dir="ltr" style="font-family:Arial, Helvetica, sans-serif;font-size:10.5pt" ><div dir="ltr" >Thanks & Regards,<br>Lakshminarayana Kamath<br>--------------------------------------------------------------------------------------------------</div></div></div></div></div>
<div dir="ltr" > </div>
<div dir="ltr" > </div>
<blockquote data-history-content-modified="1" dir="ltr" style="border-left:solid #aaaaaa 2px; margin-left:5px; padding-left:5px; direction:ltr; margin-right:0px" >----- Original message -----<br>From: "Andrew Jeffery" <andrew@aj.id.au><br>To: "Lakshminarayana R Kammath" <lkammath@in.ibm.com>, openbmc@lists.ozlabs.org<br>Cc:<br>Subject: [EXTERNAL] Re: [OpenBMC]: Unit test coverage analysis on openbmc repositories<br>Date: Tue, Mar 3, 2020 10:18 AM<br>
<div><br><font size="2" face="Default Monospace,Courier New,Courier,monospace" >On Sat, 29 Feb 2020, at 02:05, Lakshminarayana R Kammath wrote:<br><br>> <a href="https://github.com/openbmc/obmc-console.git" target="_blank">https://github.com/openbmc/obmc-console.git</a> YES, UNIT TEST<br><br>I need to add coverage support to obmc-console.<br><br>> <a href="https://github.com/openbmc/openbmc-tools.git" target="_blank">https://github.com/openbmc/openbmc-tools.git</a> NO<br><br>Not sure we can expect anything for openbmc-tools - it's a collection<br>of random scripts people have written to make their life developing<br>openbmc easier. It's not something that should have strict QA<br>processes.<br><br>> <a href="https://github.com/openbmc/openpower-host-ipmi-flash.git" target="_blank">https://github.com/openbmc/openpower-host-ipmi-flash.git</a> NO<br><br>I should add some tests here where I can.<br><br>> <a href="https://github.com/openbmc/hiomapd.git" target="_blank">https://github.com/openbmc/hiomapd.git</a> YES, UNIT TEST<br>> <a href="https://github.com/openbmc/libmctp.git" target="_blank">https://github.com/openbmc/libmctp.git</a> YES, UNIT TEST<br>> <a href="https://github.com/openbmc/phosphor-led-sysfs.git" target="_blank">https://github.com/openbmc/phosphor-led-sysfs.git</a> YES, UNIT TEST<br><br>These three do in-fact have GCOV/LCOV support, you need to do the usual autotools invocations to get it:<br><br>```<br>./configure --enable-code-coverage && make check-code-coverage<br>```<br><br>> <a href="https://github.com/openbmc/phosphor-mboxd.git" target="_blank">https://github.com/openbmc/phosphor-mboxd.git</a> ERROR<br><br>This is archived.<br><br>...<br><br>> <a href="https://github.com/openbmc/u-boot" target="_blank">https://github.com/openbmc/u-boot</a> NO<br><br>This uses Kbuild as a build system. I notice openbmc/linux and openbmc/qemu aren't included in the list.<br><br>> <a href="https://github.com/openbmc/webui-vue.git" target="_blank">https://github.com/openbmc/webui-vue.git</a> NO<br>> <a href="https://github.com/openbmc/witherspoon-pfault-analysis.git" target="_blank">https://github.com/openbmc/witherspoon-pfault-analysis.git</a> YES, COVERAGE<br>> <a href="https://github.com/openbmc/x86-power-control.git" target="_blank">https://github.com/openbmc/x86-power-control.git</a> NO<br>> *************************UNIT TEST COVERAGE<br>> REPORT*************************<br>> SUMMARY:<br>> TOTAL REPOSITORIES : 110<br>> TESTED REPOSITORIES : 43<br>> ERROR : 11<br>> COVERAGE REPORT : 12<br>> UNIT TEST REPORT : 31<br>> NO REPORT : 56<br>> ***************************************************************************<br>> Following actions, we can draw from above<br>><br>> 1. *There are 12 repo's that have GCOV/LCOV plugged in* - We need to<br>> maintain which has good coverage and try to improve those which has<br>> less coverage<br>> 2. *There are 31 repo's that have unit test cases added but no<br>> coverage analysis because they aren't plugged in yet to GCOV/LCOV* - Is<br>> there a plan for plugging in GCOV<br><br>As above at least three of these are false-negatives for test coverage.<br><br>Andrew</font><br> </div></blockquote>
<div dir="ltr" > </div></div></div><BR>