<div dir="ltr">Hi Guenter,<div><br></div><div>I still see the whitespaces warning in v5.6-rc4</div><div><br></div><div><a href="https://github.com/torvalds/linux/blob/master/drivers/watchdog/npcm_wdt.c#L106">https://github.com/torvalds/linux/blob/master/drivers/watchdog/npcm_wdt.c#L106</a> <br></div><div><br></div><div><font face="monospace">bash-4.2$ ./scripts/<a href="http://checkpatch.pl">checkpatch.pl</a> --strict --file drivers/watchdog/npcm_wdt.c <br>CHECK: Please don't use multiple blank lines<br>#106: FILE: drivers/watchdog/npcm_wdt.c:106:<br>+<br>+<br><br>WARNING: suspect code indent for conditional statements (8, 14)<br>#112: FILE: drivers/watchdog/npcm_wdt.c:112:<br>+ else if (timeout < 3)<br>+ wdd->timeout = 2;<br><br>WARNING: suspect code indent for conditional statements (8, 14)<br>#114: FILE: drivers/watchdog/npcm_wdt.c:114:<br>+ else if (timeout < 6)<br>+ wdd->timeout = 5;<br><br>WARNING: suspect code indent for conditional statements (8, 14)<br>#116: FILE: drivers/watchdog/npcm_wdt.c:116:<br>+ else if (timeout < 11)<br>+ wdd->timeout = 10;<br><br>WARNING: suspect code indent for conditional statements (8, 14)<br>#118: FILE: drivers/watchdog/npcm_wdt.c:118:<br>+ else if (timeout < 22)<br>+ wdd->timeout = 21;<br><br>WARNING: suspect code indent for conditional statements (8, 14)<br>#120: FILE: drivers/watchdog/npcm_wdt.c:120:<br>+ else if (timeout < 44)<br>+ wdd->timeout = 43;<br><br>WARNING: suspect code indent for conditional statements (8, 14)<br>#122: FILE: drivers/watchdog/npcm_wdt.c:122:<br>+ else if (timeout < 87)<br>+ wdd->timeout = 86;<br><br>WARNING: suspect code indent for conditional statements (8, 14)<br>#124: FILE: drivers/watchdog/npcm_wdt.c:124:<br>+ else if (timeout < 173)<br>+ wdd->timeout = 172;<br><br>WARNING: suspect code indent for conditional statements (8, 14)<br>#126: FILE: drivers/watchdog/npcm_wdt.c:126:<br>+ else if (timeout < 688)<br>+ wdd->timeout = 687;<br><br>WARNING: suspect code indent for conditional statements (8, 14)<br>#128: FILE: drivers/watchdog/npcm_wdt.c:128:<br>+ else<br>+ wdd->timeout = 2750;</font><br></div><div><font face="monospace"><br></font></div><div><font face="arial, sans-serif">Thanks,</font></div><div><font face="arial, sans-serif"><br></font></div><div><font face="arial, sans-serif">Tomer</font></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, 3 Mar 2020 at 23:25, Guenter Roeck <<a href="mailto:linux@roeck-us.net">linux@roeck-us.net</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Tue, Mar 03, 2020 at 12:01:14PM +0200, Tomer Maimon wrote:<br>
> Signed-off-by: Tomer Maimon <<a href="mailto:tmaimon77@gmail.com" target="_blank">tmaimon77@gmail.com</a>><br>
<br>
Turns out this problem does not actually exist in the upstream driver<br>
(as of v5.6-rc4). You might want to align your code with the upstream<br>
kernel.<br>
<br>
Guenter<br>
<br>
> ---<br>
> drivers/watchdog/npcm_wdt.c | 19 +++++++++----------<br>
> 1 file changed, 9 insertions(+), 10 deletions(-)<br>
> <br>
> diff --git a/drivers/watchdog/npcm_wdt.c b/drivers/watchdog/npcm_wdt.c<br>
> index 84a728af6664..bd38bf1ee6a1 100644<br>
> --- a/drivers/watchdog/npcm_wdt.c<br>
> +++ b/drivers/watchdog/npcm_wdt.c<br>
> @@ -123,30 +123,29 @@ static int npcm_wdt_stop(struct watchdog_device *wdd)<br>
> return 0;<br>
> }<br>
> <br>
> -<br>
> static int npcm_wdt_set_timeout(struct watchdog_device *wdd,<br>
> unsigned int timeout)<br>
> {<br>
> if (timeout < 2)<br>
> wdd->timeout = 1;<br>
> else if (timeout < 3)<br>
> - wdd->timeout = 2;<br>
> + wdd->timeout = 2;<br>
> else if (timeout < 6)<br>
> - wdd->timeout = 5;<br>
> + wdd->timeout = 5;<br>
> else if (timeout < 11)<br>
> - wdd->timeout = 10;<br>
> + wdd->timeout = 10;<br>
> else if (timeout < 22)<br>
> - wdd->timeout = 21;<br>
> + wdd->timeout = 21;<br>
> else if (timeout < 44)<br>
> - wdd->timeout = 43;<br>
> + wdd->timeout = 43;<br>
> else if (timeout < 87)<br>
> - wdd->timeout = 86;<br>
> + wdd->timeout = 86;<br>
> else if (timeout < 173)<br>
> - wdd->timeout = 172;<br>
> + wdd->timeout = 172;<br>
> else if (timeout < 688)<br>
> - wdd->timeout = 687;<br>
> + wdd->timeout = 687;<br>
> else<br>
> - wdd->timeout = 2750;<br>
> + wdd->timeout = 2750;<br>
> <br>
> if (watchdog_active(wdd))<br>
> npcm_wdt_start(wdd);<br>
</blockquote></div>