<div class="socmaildefaultfont" dir="ltr" style="font-family:Arial, Helvetica, sans-serif;font-size:10pt" ><div dir="ltr" style="font-family:Arial, Helvetica, sans-serif;font-size:10pt" ><div dir="ltr" >Hi Andrew,</div>
<div dir="ltr" > </div>
<div dir="ltr" >Sure. We Will update our list and scrub the one's which are archived and come back</div>
<div dir="ltr" > </div>
<div dir="ltr" ><div dir="ltr" style="font-family:Arial, Helvetica, sans-serif;font-size:10pt" ><div dir="ltr" style="font-family:Arial, Helvetica, sans-serif;font-size:10.5pt" ><div dir="ltr" style="font-family:Arial, Helvetica, sans-serif;font-size:10.5pt" ><div dir="ltr" >Thanks & Regards,<br>Lakshminarayana Kamath<br>--------------------------------------------------------------------------------------------------<br>Senior Engineer, Power Firmware Verification and DevOps Enablement (FSP & BMC RAS)</div>
<div dir="ltr" >D3 Block, <font size="2" >1st Floor Floor, MD3-1F-B279</font>,<br>Manyata Embassy Business Park,<br>Nagawara Outer Ring Road,<br>Bangalore - 560045<br>email:lkammath@in.ibm.com<br>+Mobile : +91-9980-902931<br>---------------------------------------------------------------------------------------------------</div>
<div dir="ltr" > </div></div></div></div></div>
<div dir="ltr" > </div>
<div dir="ltr" > </div>
<blockquote data-history-content-modified="1" data-history-expanded="1" dir="ltr" style="border-left:solid #aaaaaa 2px; margin-left:5px; padding-left:5px; direction:ltr; margin-right:0px" >----- Original message -----<br>From: "Andrew Jeffery" <andrew@aj.id.au><br>To: "Lakshminarayana R Kammath" <lkammath@in.ibm.com>, openbmc@lists.ozlabs.org<br>Cc:<br>Subject: [EXTERNAL] Re: [OpenBMC]: Unit test coverage analysis on openbmc repositories<br>Date: Tue, Mar 3, 2020 10:18 AM<br>
<div><br><font size="2" face="Default Monospace,Courier New,Courier,monospace" >On Sat, 29 Feb 2020, at 02:05, Lakshminarayana R Kammath wrote:<br><br>> <a href="https://github.com/openbmc/obmc-console.git" target="_blank">https://github.com/openbmc/obmc-console.git</a> YES, UNIT TEST<br><br>I need to add coverage support to obmc-console.<br><br>> <a href="https://github.com/openbmc/openbmc-tools.git" target="_blank">https://github.com/openbmc/openbmc-tools.git</a> NO<br><br>Not sure we can expect anything for openbmc-tools - it's a collection<br>of random scripts people have written to make their life developing<br>openbmc easier. It's not something that should have strict QA<br>processes.<br><br>> <a href="https://github.com/openbmc/openpower-host-ipmi-flash.git" target="_blank">https://github.com/openbmc/openpower-host-ipmi-flash.git</a> NO<br><br>I should add some tests here where I can.<br><br>> <a href="https://github.com/openbmc/hiomapd.git" target="_blank">https://github.com/openbmc/hiomapd.git</a> YES, UNIT TEST<br>> <a href="https://github.com/openbmc/libmctp.git" target="_blank">https://github.com/openbmc/libmctp.git</a> YES, UNIT TEST<br>> <a href="https://github.com/openbmc/phosphor-led-sysfs.git" target="_blank">https://github.com/openbmc/phosphor-led-sysfs.git</a> YES, UNIT TEST<br><br>These three do in-fact have GCOV/LCOV support, you need to do the usual autotools invocations to get it:<br><br>```<br>./configure --enable-code-coverage && make check-code-coverage<br>```<br><br>> <a href="https://github.com/openbmc/phosphor-mboxd.git" target="_blank">https://github.com/openbmc/phosphor-mboxd.git</a> ERROR<br><br>This is archived.<br><br>...<br><br>> <a href="https://github.com/openbmc/u-boot" target="_blank">https://github.com/openbmc/u-boot</a> NO<br><br>This uses Kbuild as a build system. I notice openbmc/linux and openbmc/qemu aren't included in the list.<br><br>> <a href="https://github.com/openbmc/webui-vue.git" target="_blank">https://github.com/openbmc/webui-vue.git</a> NO<br>> <a href="https://github.com/openbmc/witherspoon-pfault-analysis.git" target="_blank">https://github.com/openbmc/witherspoon-pfault-analysis.git</a> YES, COVERAGE<br>> <a href="https://github.com/openbmc/x86-power-control.git" target="_blank">https://github.com/openbmc/x86-power-control.git</a> NO<br>> *************************UNIT TEST COVERAGE<br>> REPORT*************************<br>> SUMMARY:<br>> TOTAL REPOSITORIES : 110<br>> TESTED REPOSITORIES : 43<br>> ERROR : 11<br>> COVERAGE REPORT : 12<br>> UNIT TEST REPORT : 31<br>> NO REPORT : 56<br>> ***************************************************************************<br>> Following actions, we can draw from above<br>><br>> 1. *There are 12 repo's that have GCOV/LCOV plugged in* - We need to<br>> maintain which has good coverage and try to improve those which has<br>> less coverage<br>> 2. *There are 31 repo's that have unit test cases added but no<br>> coverage analysis because they aren't plugged in yet to GCOV/LCOV* - Is<br>> there a plan for plugging in GCOV<br><br>As above at least three of these are false-negatives for test coverage.<br><br>Andrew</font><br> </div></blockquote>
<div dir="ltr" > </div></div></div><BR>