<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:PMingLiU;
panose-1:2 2 5 0 0 0 0 0 0 0;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:PMingLiU;
panose-1:2 1 6 1 0 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p.MsoPlainText, li.MsoPlainText, div.MsoPlainText
{mso-style-priority:99;
mso-style-link:"\7D14\6587\5B57 \5B57\5143";
margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Calibri",sans-serif;}
span.a
{mso-style-name:"\7D14\6587\5B57 \5B57\5143";
mso-style-priority:99;
mso-style-link:\7D14\6587\5B57;
font-family:"Calibri",sans-serif;}
.MsoChpDefault
{mso-style-type:export-only;}
/* Page Definitions */
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 90.0pt 72.0pt 90.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="ZH-TW" link="#0563C1" vlink="#954F72" style="text-justify-trim:punctuation">
<div class="WordSection1">
<p class="MsoPlainText"><span lang="EN-US">Hi James,<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"> We offer a proposal to fix this bug. The bug is about that if we set the upper non-critical (unc) threshold value smaller than reading value, we should get only one assert log but we got 3 logs (assert log, de-assert
log and then assert log). We expect the result is that we can change threshold value property on Dbus (xyz.openbmc_project.EntityManager service and xyz.openbmc_project.IpmbSensor service) and get assert/deassert sel log when we trigger/untrigger the threshold
mechanism. <o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"> Our proposal is about that modify struct sensor's "objectType" member define from "xyz.openbmc_project.Configuration.ExitAirTemp" to "xyz.openbmc_project.Configuration.IpmbSensor". Add a new member (bool alarmvalue)
in</span><span lang="EN-US"> </span><span lang="EN-US">struct Threshold in threshold.hpp. Keeping update alarmvalue when process (ipmbsensor) in function of checkThresholds(). When modifying the threshold value and then process going into function of creatsensor()
again. Rewrite the sensor value and alarmvalue into global struct sensor after global struct sensor initialization. What do you think about our proposal ? Would you accept our proposal ? Please let us know if you have any questions. Thanks for your reply!<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><img width="603" height="371" style="width:6.2812in;height:3.8645in" id="_x5716__x7247__x0020_26" src="cid:image003.png@01D5ECCA.3ACBEE90"></span><span lang="EN-US"><o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">Engineer<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">Storage Firmware<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">Development Dept.<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">Firmware Development Div.<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">Wiwynn Corporation<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">Tel: +886-2-6614-7549<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">E-mail: Max_Lai@wiwynn.com<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">-----Original Message-----<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">From: James Feist <james.feist@linux.intel.com>
<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">Sent: Wednesday, February 26, 2020 1:33 AM<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">To: Max Lai/WYHQ/Wiwynn <Max_Lai@wiwynn.com><o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">Cc: openbmc@lists.ozlabs.org; LF_OpenBMC.WYHQ.Wiwynn <LF_OpenBMC.WYHQ.Wiwynn@Wiwynn.com><o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">Subject: Re: dbus-sensor: setting the upper non-critical(unc) threshold value smaller than reading value would get 3 logs ( assert log, de-assert log and then assert log)<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">On 2/24/20 5:29 PM, Max Lai/WYHQ/Wiwynn wrote:<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> Hi James,<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> <o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> Sorry for I offered the wrong information. The last mail this sentence
<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> "struct sensor's "objectType" member which was set
<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> "xyz.openbmc_project.Configuration.ExitAirTemp" was different than our
<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> "xyz.openbmc_project.EntityManager"." is *wrong*. The
<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> *correct*information is "struct sensor's "objectType" member which was
<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> set "xyz.openbmc_project.Configuration.ExitAirTemp" was different than
<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> our "*xyz.openbmc_project.Configuration.IpmbSensor*". The different is
<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> between "xyz.openbmc_project.Configuration.*ExitAirTemp*" and
<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> "xyz.openbmc_project.Configuration.*IpmbSensor*".<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">That looks like a bug.. I'll look into it. I think it's a copy paste error.<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
</div>
<p><span style="font-family:'Calibri';font-size:11pt; color:#000000;"><b>---------------------------------------------------------------------------------------------------------------------------------------------------------------</b></span></p>
<p><span style="font-family:'Calibri';font-size:11pt; color:#000000;"><b>This email contains confidential or legally privileged information and is for the sole use of its intended recipient. </b></span></p>
<p><span style="font-family:'Calibri';font-size:11pt; color:#000000;"><b>Any unauthorized review, use, copying or distribution of this email or the content of this email is strictly prohibited.</b></span></p>
<p><span style="font-family:'Calibri';font-size:11pt; color:#000000;"><b>If you are not the intended recipient, you may reply to the sender and should delete this e-mail immediately.</b></span></p>
<p><span style="font-family:'Calibri';font-size:11pt; color:#000000;"><b>---------------------------------------------------------------------------------------------------------------------------------------------------------------</b></span></p></body>
</html>