<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:\65B0\7D30\660E\9AD4;
panose-1:2 2 5 0 0 0 0 0 0 0;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"\@\65B0\7D30\660E\9AD4";
panose-1:2 1 6 1 0 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
{mso-style-priority:34;
margin-top:0cm;
margin-right:0cm;
margin-bottom:0cm;
margin-left:24.0pt;
margin-bottom:.0001pt;
mso-para-margin-top:0cm;
mso-para-margin-right:0cm;
mso-para-margin-bottom:0cm;
mso-para-margin-left:2.0gd;
mso-para-margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"\65B0\7D30\660E\9AD4",serif;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;}
/* Page Definitions */
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 90.0pt 72.0pt 90.0pt;}
div.WordSection1
{page:WordSection1;}
/* List Definitions */
@list l0
{mso-list-id:1306012285;
mso-list-type:hybrid;
mso-list-template-ids:1362414106 -608031092 1032859060 -1176860786 -744855594 -172862226 -1352636804 848299878 1353627616 -1344536400;}
@list l0:level1
{mso-level-tab-stop:36.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;}
@list l0:level2
{mso-level-tab-stop:72.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;}
@list l0:level3
{mso-level-tab-stop:108.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;}
@list l0:level4
{mso-level-tab-stop:144.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;}
@list l0:level5
{mso-level-tab-stop:180.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;}
@list l0:level6
{mso-level-tab-stop:216.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;}
@list l0:level7
{mso-level-tab-stop:252.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;}
@list l0:level8
{mso-level-tab-stop:288.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;}
@list l0:level9
{mso-level-tab-stop:324.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;}
ol
{margin-bottom:0cm;}
ul
{margin-bottom:0cm;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="ZH-TW" link="#0563C1" vlink="#954F72" style="text-justify-trim:punctuation">
<div class="WordSection1">
<p class="MsoNormal"><b><span lang="EN-US">Hi James,<o:p></o:p></span></b></p>
<p class="MsoNormal"><b><span lang="EN-US">Our validation team met a problem in dbus-sensor recently. The bug is about that if we set the upper non-critical (unc) threshold value smaller than reading value, we should get only one assert log but we got 3 logs
( assert log, de-assert log and then assert log) .<o:p></o:p></span></b></p>
<p class="MsoNormal"><b><span lang="EN-US">We traced the code of Ipmbsensor. The picture below is the code flow of Ipmbsensor.<o:p></o:p></span></b></p>
<p class="MsoNormal"><b><span lang="EN-US"><o:p> </o:p></span></b></p>
<p class="MsoNormal"><b><span lang="EN-US"><img width="298" height="353" style="width:3.1041in;height:3.677in" id="圖片_x0020_1" src="cid:image001.png@01D5E707.664E4310"></span><span lang="EN-US"><o:p></o:p></span></b></p>
<p class="MsoNormal"><b><span lang="EN-US"><o:p> </o:p></span></b></p>
<p class="MsoNormal"><b><span lang="EN-US">We found that when we set the threshold , the function match (configMatch) which is registered in Ipmbsensor would catch the signal like the below<o:p></o:p></span></b></p>
<p class="MsoNormal"><b><span lang="EN-US"><o:p> </o:p></span></b></p>
<p class="MsoNormal"><b><span lang="EN-US"><img width="804" height="220" style="width:8.375in;height:2.2916in" id="圖片_x0020_22" src="cid:image002.png@01D5E707.664E4310"></span><span lang="EN-US"><o:p></o:p></span></b></p>
<p class="MsoNormal"><b><span lang="EN-US"><o:p> </o:p></span></b></p>
<p class="MsoNormal"><b><span lang="EN-US">When it trigger the handler (eventhandler) and then enter the function of createsensor() and later enter the function of setInitialProperties(). In the setInitialProperties(), It would initial the property (setting
the threshold of alarm to default (false) is the root cause). This would trigger Ipmbsensor to send the deassert log. We was wondering that why setting the threshold would initial the property. Is the code flow we draw is correct? Is there any misunderstanding
in our thought ? What is the purpose of registering match this signal ?<o:p></o:p></span></b></p>
<p class="MsoNormal"><b><span lang="EN-US"><o:p> </o:p></span></b></p>
<p class="MsoNormal"><b><span lang="EN-US">Our source revision :</span></b><span lang="EN-US">
<b>fb64f45d3399b182ceadffb8fa86ee68c0aa0a11<o:p></o:p></b></span></p>
<p class="MsoNormal"><b><span lang="EN-US"><o:p> </o:p></span></b></p>
<p class="MsoNormal"><b><span lang="EN-US">Note: We found that this issue didn’t happen in CPUSensor and HwmonTempSensor.<o:p></o:p></span></b></p>
<p class="MsoNormal"><b><span lang="EN-US"><o:p> </o:p></span></b></p>
<p class="MsoNormal"><b><span lang="EN-US">Regards,<o:p></o:p></span></b></p>
<p class="MsoNormal"><b><span lang="EN-US">Max Lai<o:p></o:p></span></b></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
</div>
<p><span style="font-family:'Calibri';font-size:11pt; color:#000000;"><b>---------------------------------------------------------------------------------------------------------------------------------------------------------------</b></span></p>
<p><span style="font-family:'Calibri';font-size:11pt; color:#000000;"><b>This email contains confidential or legally privileged information and is for the sole use of its intended recipient. </b></span></p>
<p><span style="font-family:'Calibri';font-size:11pt; color:#000000;"><b>Any unauthorized review, use, copying or distribution of this email or the content of this email is strictly prohibited.</b></span></p>
<p><span style="font-family:'Calibri';font-size:11pt; color:#000000;"><b>If you are not the intended recipient, you may reply to the sender and should delete this e-mail immediately.</b></span></p>
<p><span style="font-family:'Calibri';font-size:11pt; color:#000000;"><b>---------------------------------------------------------------------------------------------------------------------------------------------------------------</b></span></p></body>
</html>