<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <p>A couple comments. <br>
    </p>
    <div class="moz-cite-prefix">On 1/7/2020 2:08 PM, Bills, Jason M
      wrote:<br>
    </div>
    <blockquote type="cite"
      cite="mid:a281f9ca-9dc7-9e7a-8e87-08a313d43fe9@linux.intel.com">
      <br>
      On 1/7/2020 2:11 AM, Ratan Gupta wrote:
      <br>
      <br>
      <blockquote type="cite">
        <blockquote type="cite">
          <br>
          <blockquote type="cite">
            <br>
            On Sat, Dec 14, 2019 at 10:57 AM dhruvaraj S
            <a class="moz-txt-link-rfc2396E" href="mailto:dhruvaraj@gmail.com"><dhruvaraj@gmail.com></a> wrote:
            <br>
            <blockquote type="cite">
              <br>
              On Sat, Dec 14, 2019 at 1:32 AM Bills, Jason M
              <br>
              <a class="moz-txt-link-rfc2396E" href="mailto:jason.m.bills@linux.intel.com"><jason.m.bills@linux.intel.com></a> wrote:
              <br>
              <blockquote type="cite">
                <br>
                I like this as well.  I'm trying to support a CPU
                crashdump that would
                <br>
                fit perfectly with this proposal.
                <br>
                <br>
                A question and some comments below:
                <br>
                <br>
                Will Dump only have the two types: BMC and Host?  Could
                this be more
                <br>
                flexible to allow for multiple different types of dumps
                from various
                <br>
                components?
                <br>
              </blockquote>
              + I think dump types should be flexible to cover different
              types of
              <br>
              host or bmc dumps from different components with varying
              formats.
              <br>
            </blockquote>
          </blockquote>
        </blockquote>
        Sure we can enhance the type of dump, it is enum in the proposal
        which can be enhanced.
        <br>
        What could be other dump type which I can add in the types?
        <br>
      </blockquote>
    </blockquote>
    <p>Slide 15:  Since DumpType is an enum, should reason be as well?
      "Type" is a pretty typical enum in Redfish. E.g. BaseModuleType
      from <a class="moz-txt-link-freetext" href="https://redfish.dmtf.org/schemas/Memory.v1_8_0.json">https://redfish.dmtf.org/schemas/Memory.v1_8_0.json</a><br>
      <br>
      Reason seems similar to the <span class="treeLabel objectLabel"
        aria-labelledby="default" data-level="1">LogEntryCode from</span>
      <a class="moz-txt-link-freetext" href="https://redfish.dmtf.org/schemas/LogEntry.v1_5_0.json">https://redfish.dmtf.org/schemas/LogEntry.v1_5_0.json</a><br>
      <br>
      Slide 15: <br>
      "Size": 108944B<br>
      Redfish size properties typically have the unit in the name. E.g.
      From <a class="moz-txt-link-freetext" href="https://redfish.dmtf.org/schemas/Memory.v1_8_0.json">https://redfish.dmtf.org/schemas/Memory.v1_8_0.json</a>
      CacheSizeMiB or CapacityMiB. <br>
      <br>
      odata.context is getting dropped. See
      <a class="moz-txt-link-freetext" href="https://github.com/DMTF/Redfish/issues/2722">https://github.com/DMTF/Redfish/issues/2722</a> or
<a class="moz-txt-link-freetext" href="https://github.com/DMTF/Redfish/commit/ae49f4fb1278fd435f89317c3fa53cac597e3893#diff-e82b4876efbeaa600d3b104a426f7ac5">https://github.com/DMTF/Redfish/commit/ae49f4fb1278fd435f89317c3fa53cac597e3893#diff-e82b4876efbeaa600d3b104a426f7ac5</a>
      <br>
    </p>
  </body>
</html>