<div dir="ltr">Hi Ratan,<div><br></div><div>I think this service is a really good idea. A couple of thoughts:</div><div><br></div><div>1) I don't think the semantics around the Download action are consistent. Generally actions are reserved for stateful changes, and only have post methods. I think this could be simplified by putting an @<a href="http://odata.id">odata.id</a> in the Dump resource that points to the raw dump file. Then clients can do a normal HTTP get on that URL.</div><div><br></div><div>2) I'm wondering what is the best way to communicate what MIME type the raw dump supports. In theory that could be a part of the RawDump resource. However, a case could be made that it should be put into the Dump resource. </div><div><br></div><div>3) Perhaps the dump service should be embedded into other resources, instead of being a top level service. I'm imagining something like how the LogService is setup. That way there are a lot fewer dumpTypes for any particular instance of the service. </div><div> a) This could be taken to the extreme, and the DumpService could be integrated with the existing LogServices. This would mean adding in a new log type, and having a new action.</div><div><br></div><div>4) It might be a good idea to have some event support in the cases where a dump is created because of a machine crash.</div><div><br></div><div>Regards,</div><div>Richard</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Dec 11, 2019 at 11:08 PM Devender Rao <<a href="mailto:devenrao@in.ibm.com">devenrao@in.ibm.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr" style="font-family:Arial,Helvetica,sans-serif;font-size:10pt"><div dir="ltr">Over all the schema looks good. Few observations for clarity, also how about we have multiple collection say HostDumpCollection, BMCDumpCollection and also a new service DumpLocations similar to "CertificateLocations"</div>
<div dir="ltr"><br>Page 17: Dump Creation flow</div>
<div dir="ltr">1. The time line diagram should show that "Request to create dump" return immediatley. The redfish client will be notififed asynchronously when the dump is collected through DumpCollected event. Request for dump with resource id should be in the same time line when it gets notified of Dump collection completed.<br> </div>
<div dir="ltr">Page 19: For clarity</div>
<div dir="ltr">"List Dumps" should be shown as part of DumpColletion rather than under "Operations on dump"<br>"Get Dump details" should be shown under dump service</div>
<div dir="ltr">"Delete Dumps" should be shown under DumpService<br> </div>
<blockquote dir="ltr" style="border-left:2px solid rgb(170,170,170);margin-left:5px;padding-left:5px;direction:ltr;margin-right:0px">----- Original message -----<br>From: Ratan Gupta <<a href="mailto:ratagupt@linux.vnet.ibm.com" target="_blank">ratagupt@linux.vnet.ibm.com</a>><br>Sent by: "openbmc" <openbmc-bounces+devenrao=<a href="mailto:in.ibm.com@lists.ozlabs.org" target="_blank">in.ibm.com@lists.ozlabs.org</a>><br>To: "<a href="mailto:openbmc@lists.ozlabs.org" target="_blank">openbmc@lists.ozlabs.org</a>" <<a href="mailto:openbmc@lists.ozlabs.org" target="_blank">openbmc@lists.ozlabs.org</a>><br>Cc:<br>Subject: [EXTERNAL] Redfish Dump Service Proposal<br>Date: Thu, Dec 12, 2019 5:09 AM<br>
<div><font face="Default Monospace,Courier New,Courier,monospace" size="2">Hi All,<br><br>Please find the redfish dump service proposal for the DMTF attached.<br><br>Kindly review and provide your inputs.<br><br>Ratan</font><br><br><br> </div>
<div id="gmail-m_-4222119677397271989MIMEAttachInfoDiv" style="display:none" title="vnd.openxmlformats-officedocument.presentationml.presentation|DumpOffload_DMTF_Proposal.pptx"> </div></blockquote>
<div dir="ltr"> </div></div><br>
</blockquote></div>