<div dir="ltr">Hi Joel,<div><br></div><div>Thanks for upstream the Olympus RunBMC device tree files.</div><div><br></div><div>When we compile the device tree in the OpenBMC we didn't see these warnings, but I can see it in other DTC.</div><div><br></div><div>Sorry we are on vacation until Wednesday, I will work on it as soon we will be back on work.</div><div><br></div><div>Cheers</div><div><br></div><div>Tomer</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, 26 Sep 2019 at 11:46, Joel Stanley <<a href="mailto:joel@jms.id.au">joel@jms.id.au</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Wed, 25 Sep 2019 at 12:26, Tomer Maimon <<a href="mailto:tmaimon77@gmail.com" target="_blank">tmaimon77@gmail.com</a>> wrote:<br>
><br>
> Add Nuvoton NPCM7xx RunBMC Olympus Quanta board<br>
> device tree.<br>
><br>
> Signed-off-by: Tomer Maimon <<a href="mailto:tmaimon77@gmail.com" target="_blank">tmaimon77@gmail.com</a>><br>
<br>
Thanks Tomer, I've applied this to dev-5.3. Please test it when you<br>
get a chance as I do not have access to RunBMC hardware.<br>
<br>
There's some warnings that are produced if you're using a recent<br>
device tree compiler version:<br>
<br>
$ dtc --version<br>
Version: DTC 1.5.0<br>
<br>
DTC arch/arm/boot/dts/nuvoton-npcm750-runbmc-olympus.dtb<br>
../arch/arm/boot/dts/nuvoton-npcm750-runbmc-olympus.dts:428.6-25:<br>
Warning (i2c_bus_reg):<br>
/ahb/apb/i2c@85000/i2c-slave-mqueue@40000010:reg: I2C address must be<br>
less than 10-bits, got "0x40000010"<br>
../arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi:222.22-231.5: Warning<br>
(spi_bus_bridge): /ahb/fiu@fb000000: node name for SPI buses should be<br>
'spi'<br>
also defined at<br>
../arch/arm/boot/dts/nuvoton-npcm750-runbmc-olympus.dts:134.22-195.5<br>
../arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi:233.22-244.5: Warning<br>
(spi_bus_bridge): /ahb/fiu@c0000000: node name for SPI buses should be<br>
'spi'<br>
also defined at<br>
../arch/arm/boot/dts/nuvoton-npcm750-runbmc-olympus.dts:197.22-220.5<br>
arch/arm/boot/dts/nuvoton-npcm750-runbmc-olympus.dtb: Warning<br>
(spi_bus_reg): Failed prerequisite 'spi_bus_bridge'<br>
<br>
If you could send a follow up patch that fixes this that would be great.<br>
<br>
Cheers,<br>
<br>
Joel<br>
</blockquote></div>