<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=big5">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<p>Hi Patrick,</p>
<p><br>
</p>
<p></p>
<div>{<br>
"sensors" : [<br>
{<br>
"name": "fan1",<br>
"type": "fan",<br>
"readPath": "/xyz/openbmc_project/sensors/fan_tach/fan1",<br>
"writePath": "/sys/devices/platform/ahb/ahb:apb/1e786000.pwm-tacho-controller/hwmon/**/pwm1",<br>
"min": 0,<br>
"max": 255<br>
},<br>
{<br>
"name": "temp1",<br>
"type": "temp",<br>
"readPath": "/xyz/openbmc_project/sensors/temperature/temp1",<br>
"writePath": "",<br>
"min": 0,<br>
"max": 0<br>
}<br>
],<br>
"zones" : [<br>
{<br>
"id": 1,<br>
"minThermalOutput": 3000.0,<br>
"failsafePercent": 75.0,<br>
"pids": [<br>
{<br>
"name": "fan1",<br>
"type": "fan",<br>
"inputs": ["fan1"],<br>
"setpoint": 90.0,<br>
"pid": {<br>
"samplePeriod": 0.1,<br>
"proportionalCoeff": -1.0,<br>
"integralCoeff": -0.2,<br>
"feedFwdOffsetCoeff": 0.0,<br>
"feedFwdGainCoeff": <span>0.010</span>,<br>
"integralLimit_min": 0.0,<br>
"integralLimit_max": 0.0,<br>
"outLim_min": 30.0,<br>
"outLim_max": 100.0,<br>
"slewNeg": 0.0,<br>
"slewPos": 0.0<br>
}<br>
},<br>
{<br>
"name": "temp1",<br>
"type": "temp",<br>
"inputs": ["temp1"],<br>
"setpoint": 50.0,
<br>
"pid": {
<br>
"samplePeriod": 0.1,
<br>
"proportionalCoeff": -1.0,
<br>
"integralCoeff": -0.2, <br>
"feedFwdOffsetCoeff": 0.0,<br>
"feedFwdGainCoeff": <span style="font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols; font-size: 16px;">
0.010</span>, <br>
"integralLimit_min": 0.0, <br>
"integralLimit_max": 0.0, <br>
"outLim_min": 500.0, <br>
"outLim_max": 1500.0, <br>
"slewNeg": 0.0, <br>
"slewPos": 0.0<br>
} <br>
}<br>
] <br>
} <br>
] <br>
} <br>
<br>
</div>
<p></p>
<p>Sincerely,</p>
<p><br>
</p>
<p>Hank Liou</p>
<br>
<div style="color:rgb(0,0,0)">
<div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Patrick Venture <venture@google.com><br>
<b>Sent:</b> Thursday, March 28, 2019 10:33 PM<br>
<b>To:</b> Hank Liou (¼B®Ê¿«)<br>
<b>Cc:</b> openbmc@lists.ozlabs.org<br>
<b>Subject:</b> Re: [phosphor-pid-control] scaling issue</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:10pt">
<div class="PlainText">On Thu, Mar 28, 2019 at 3:55 AM Hank Liou (¼B®Ê¿«) <Hank.Liou@quantatw.com> wrote:<br>
><br>
> Hi All,<br>
><br>
><br>
> This issue is related to the repository phosphor-pid-control.<br>
><br>
><br>
> It is in commit dbuspassive: allow scaling that one added scaling mechanism. However when it comes to pid.cpp, it may encounter scaling mismatch. That is to say, (in fan control stage) the pid takes the scaled values as inputs, but it utilizes unscaled setpoints
resulting wrong error terms. Or just change the setpoint value?<br>
<br>
Can you share your configuration? That might simplify the conversation.<br>
<br>
><br>
><br>
> Thanks,<br>
><br>
><br>
> Hank Liou<br>
><br>
> Quanta Computer Inc.<br>
</div>
</span></font></div>
</div>
</body>
</html>