<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<title></title>
</head>
<body>
<div name="messageBodySection" style="font-size: 14px; font-family: -apple-system, BlinkMacSystemFont, sans-serif;">
<div>Apologize for sending out no content mail first.<br /></div>
<div><br /></div>
<div>Jae,</div>
<div>The aspeed_gates in clk-aspeed.c perhaps as todo suggest asking Aspeed the actual parent data for check initializing?<br /></div>
<div><br /></div>
<div>Vijay,</div>
<div>I traced lpc-ctrl module, it seems direct update the same ASPEED_CLK_GATE_LCLK register map bit to enable. If parent data is disabled, it could enable in dts.</div>
<div>The device tree detail, I reference it from aspeed-g5.dtsi. Hope it could help you for work.<br /></div>
</div>
<div name="messageSignatureSection" style="font-size: 14px; font-family: -apple-system, BlinkMacSystemFont, sans-serif;"><br />
Thanks,
<div><br /></div>
<div>Samuel Jiang</div>
</div>
<div name="messageReplySection" style="font-size: 14px; font-family: -apple-system, BlinkMacSystemFont, sans-serif;">On Dec 1, 2018, 7:04 AM +0800, Jae Hyun Yoo , wrote:<br />
<blockquote type="cite" style="margin: 5px 5px; padding-left: 10px; border-left: thin solid #1abc9c;">On 11/30/2018 4:39 PM, Vijay Khemka wrote:<br />
<blockquote type="cite" style="margin: 5px 5px; padding-left: 10px; border-left: thin solid #e67e22;"><br />
<br />
On 11/30/18, 11:29 AM, "Jae Hyun Yoo" <jae.hyun.yoo@linux.intel.com> wrote:<br />
<br />
On 11/30/2018 12:57 PM, Vijay Khemka wrote:<br />
<blockquote type="cite" style="margin: 5px 5px; padding-left: 10px; border-left: thin solid #3498db;"><br />
On 11/30/18, 7:31 AM, "Jae Hyun Yoo" <jae.hyun.yoo@linux.intel.com> wrote:<br />
<br />
On 11/29/2018 9:00 PM, Samuel Jiang wrote:<br />
<blockquote type="cite" style="margin: 5px 5px; padding-left: 10px; border-left: thin solid #d35400;">Hi Jae,<br />
<br />
We also encountered the same situation a month ago.<br />
We try to enable the LPC clock on devicetree to resolve this problem not<br />
direct modify clock driver.<br />
<br />
lpc_ctrl: lpc-ctrl@0 {<br />
compatible = "aspeed,ast2500-lpc-ctrl”;<br />
reg = <0x0 0x80>;<br />
clocks = <&syscon ASPEED_CLK_GATE_LCLK>;<br />
status = “okay”;<br />
};<br />
<br />
However, I’m not sure which is better for LPC_CLCK setting.<br />
Whether we should modify driver if original data is enabled or should<br />
enable on the device tree, correct?<br />
<br />
<br /></blockquote>
<br />
Hi Samuel,<br />
<br />
Yes, you are right. I realized that kcs_bmc_aspeed.c doesn't have any<br />
clock control code so adding a clocks setting into kcs dtsi code doesn't<br />
make any help. Also, it was the reason why the change is needed on<br />
clk-aspeed.c. Enabling lpc_ctrl node you suggested seems a right way.<br />
<br />
Hi Vijay,<br />
Can you please try the way Samuel suggested after removing changes I<br />
gave you. Samuel's solution looks good to me.<br />
<br />
Thanks,<br />
Jae<br />
<br />
Jae,<br />
I can try. We can certainly enable lpc_ctrl node but in my understanding that<br />
we still need this below patch to redefine ASPEED_CLK_GATE_LCLK value to<br />
add CRITICAL. I might be missing something here.<br />
- [ASPEED_CLK_GATE_LCLK] = { 8, 5, "lclk-gate", NULL, 0 }, /* LPC */<br />
+ [ASPEED_CLK_GATE_LCLK] = { 8, 5, "lclk-gate", NULL, CLK_IS_CRITICAL }, /* LPC */<br />
<br /></blockquote>
<br />
Vijay,<br />
<br />
I checked that lpc_ctrl module has clocks dt property handling code in<br />
the module so I think the LCLK would be enabled without the clk-aspeed.c<br />
fix. I can't test it now because I'm in a business trip so please test<br />
it. I'll also check it when I back to office a week after.<br />
<br />
Thanks,<br />
Jae<br />
<br />
Jae,<br />
I removed above aspeed clock driver patch, and enabled lpc-ctrl node in dts also removed clock definition from kcs. And I don't see host is getting powered on. It works only with clock driver change.<br />
<br />
And I still didn't understand how enabling lpc-ctrl node will initialize ASPEED_CLK_GATE_LCLK to CRITICAL.<br />
<br />
-Vijay<br />
<br /></blockquote>
<br />
Vijay,<br />
<br />
Thanks Vijay for sharing the test result. I'll also check it on my<br />
hardware when I get back to office. Will share my test result too.<br />
<br />
Thanks again,<br />
Jae<br /></blockquote>
<div></div>
</div>
</body>
</html>