<div dir="ltr"><div dir="ltr">Hi,<div><br></div><div>it also fails for aarch64:</div><div><br></div><div><div>| ../../git/src/ptrace.cc: In function 'user_regs_struct pyflame::PtraceGetRegs(pid_t)':</div><div>| ../../git/src/ptrace.cc:127:14: error: 'PTRACE_GETREGS' was not declared in this scope</div><div>| if (ptrace(PTRACE_GETREGS, pid, 0, ®s)) {</div><div>| ^~~~~~~~~~~~~~</div><div>| ../../git/src/ptrace.cc:127:14: note: suggested alternative: 'PTRACE_GETREGSET'</div><div>| if (ptrace(PTRACE_GETREGS, pid, 0, ®s)) {</div><div>| ^~~~~~~~~~~~~~</div><div>| PTRACE_GETREGSET</div><div>| ../../git/src/ptrace.cc: In function 'void pyflame::PtraceSetRegs(pid_t, user_regs_struct)':</div><div>| ../../git/src/ptrace.cc:136:14: error: 'PTRACE_SETREGS' was not declared in this scope</div><div>| if (ptrace(PTRACE_SETREGS, pid, 0, ®s)) {</div><div>| ^~~~~~~~~~~~~~</div><div>| ../../git/src/ptrace.cc:136:14: note: suggested alternative: 'PTRACE_SETREGSET'</div><div>| if (ptrace(PTRACE_SETREGS, pid, 0, ®s)) {</div><div>| ^~~~~~~~~~~~~~</div><div>| PTRACE_SETREGSET</div><div>| Makefile:524: recipe for target 'ptrace.o' failed</div><div>| make[2]: *** [ptrace.o] Error 1</div></div><div><br></div><div>I don't plan to use it, so I'm ok with aarch64 removal from compatible archs if the fix turns to be complicated.</div><div><br></div><div>Cheers,</div></div></div><br><div class="gmail_quote"><div dir="ltr">On Thu, May 31, 2018 at 6:49 PM Khem Raj <<a href="mailto:raj.khem@gmail.com">raj.khem@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">fails to build on qemumips<br>
<br>
| ../../git/src/ptrace.cc: In function 'user_regs_struct<br>
pyflame::PtraceGetRegs(pid_t)':<br>
| ../../git/src/ptrace.cc:125:41: error: return type 'user_regs_struct<br>
{aka struct user_regs_struct}' is incomplete<br>
| user_regs_struct PtraceGetRegs(pid_t pid) {<br>
| ^<br>
| ../../git/src/ptrace.cc:125:18: error: ambiguating new declaration<br>
of 'void pyflame::PtraceGetRegs(pid_t)'<br>
| user_regs_struct PtraceGetRegs(pid_t pid) {<br>
| ^~~~~~~~~~~~~<br>
| In file included from ../../git/src/ptrace.cc:15:0:<br>
| ../../git/src/./ptrace.h:48:18: note: old declaration<br>
'user_regs_struct pyflame::PtraceGetRegs(pid_t)'<br>
| user_regs_struct PtraceGetRegs(pid_t pid);<br>
| ^~~~~~~~~~~~~<br>
| ../../git/src/ptrace.cc:126:20: error: aggregate 'user_regs_struct<br>
regs' has incomplete type and cannot be defined<br>
| user_regs_struct regs;<br>
| ^~~~<br>
| ../../git/src/ptrace.cc: In function 'void<br>
pyflame::PtraceSetRegs(pid_t, user_regs_struct)':<br>
| ../../git/src/ptrace.cc:135:48: error: 'regs' has incomplete type<br>
| void PtraceSetRegs(pid_t pid, user_regs_struct regs) {<br>
| ^~~~<br>
| In file included from ../../git/src/ptrace.cc:15:0:<br>
| ../../git/src/./ptrace.h:29:16: note: forward declaration of<br>
'user_regs_struct {aka struct user_regs_struct}'<br>
| typedef struct user_regs_struct user_regs_struct;<br>
| ^~~~~~~~~~~~~~~~<br>
| make[2]: *** [ptrace.o] Error 1<br>
| make[2]: *** Waiting for unfinished jobs....<br>
| make[2]: Leaving directory<br>
`/mnt/jenkins/workspace/OpenEmbedded/build/tmp/work/mips32r2-bec-linux/python-pyflame/1.6.6-r0/build/src'<br>
<br>
On Tue, May 29, 2018 at 4:48 AM, Andrew Jeffery <<a href="mailto:andrew@aj.id.au" target="_blank">andrew@aj.id.au</a>> wrote:<br>
> On Thu, 10 May 2018, at 16:07, Andrew Jeffery wrote:<br>
>> Signed-off-by: Andrew Jeffery <<a href="mailto:andrew@aj.id.au" target="_blank">andrew@aj.id.au</a>><br>
><br>
> Ping - is there anything I need to revise for this patch or the following two?<br>
><br>
> Cheers,<br>
><br>
> Andrew<br>
><br>
>> ---<br>
>> meta-python/recipes-devtools/python/python-pyflame.inc | 12 ++++++++++++<br>
>> meta-python/recipes-devtools/python/<a href="http://python-pyflame_1.6.6.bb" rel="noreferrer" target="_blank">python-pyflame_1.6.6.bb</a> | 1 +<br>
>> 2 files changed, 13 insertions(+)<br>
>> create mode 100644 meta-python/recipes-devtools/python/python-pyflame.inc<br>
>> create mode 100644 meta-python/recipes-devtools/python/<a href="http://python-pyflame_1.6.6.bb" rel="noreferrer" target="_blank">python-pyflame_1.6.6.bb</a><br>
>><br>
>> diff --git a/meta-python/recipes-devtools/python/python-pyflame.inc b/<br>
>> meta-python/recipes-devtools/python/python-pyflame.inc<br>
>> new file mode 100644<br>
>> index 000000000000..3b84a7e8f8e3<br>
>> --- /dev/null<br>
>> +++ b/meta-python/recipes-devtools/python/python-pyflame.inc<br>
>> @@ -0,0 +1,12 @@<br>
>> +SUMMARY = "Pyflame: A Ptracing Profiler For Python"<br>
>> +HOMEPAGE = "<a href="https://github.com/uber/pyflame" rel="noreferrer" target="_blank">https://github.com/uber/pyflame</a>"<br>
>> +SECTION = "devel/python"<br>
>> +LICENSE = "Apache-2.0"<br>
>> +LIC_FILES_CHKSUM = "file://${S}/<br>
>> LICENSE;md5=2ee41112a44fe7014dce33e26468ba93"<br>
>> +DEPENDS = "python"<br>
>> +<br>
>> +SRC_URI = "git://<a href="http://github.com/uber/pyflame.git;protocol=https;tag=v$%7BPV%7D" rel="noreferrer" target="_blank">github.com/uber/pyflame.git;protocol=https;tag=v${PV}</a>"<br>
>> +S = "${WORKDIR}/git"<br>
>> +<br>
>> +inherit pkgconfig autotools<br>
>> +<br>
>> diff --git a/meta-python/recipes-devtools/python/<a href="http://python-pyflame_1.6.6.bb" rel="noreferrer" target="_blank">python-pyflame_1.6.6.bb</a><br>
>> b/meta-python/recipes-devtools/python/<a href="http://python-pyflame_1.6.6.bb" rel="noreferrer" target="_blank">python-pyflame_1.6.6.bb</a><br>
>> new file mode 100644<br>
>> index 000000000000..96f03305f883<br>
>> --- /dev/null<br>
>> +++ b/meta-python/recipes-devtools/python/<a href="http://python-pyflame_1.6.6.bb" rel="noreferrer" target="_blank">python-pyflame_1.6.6.bb</a><br>
>> @@ -0,0 +1 @@<br>
>> +require python-pyflame.inc<br>
>> --<br>
>> 2.14.1<br>
>><br>
> --<br>
> _______________________________________________<br>
> Openembedded-devel mailing list<br>
> <a href="mailto:Openembedded-devel@lists.openembedded.org" target="_blank">Openembedded-devel@lists.openembedded.org</a><br>
> <a href="http://lists.openembedded.org/mailman/listinfo/openembedded-devel" rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-devel</a><br>
-- <br>
_______________________________________________<br>
Openembedded-devel mailing list<br>
<a href="mailto:Openembedded-devel@lists.openembedded.org" target="_blank">Openembedded-devel@lists.openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-devel" rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-devel</a><br>
</blockquote></div>