<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"\@SimSun";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p
{mso-style-priority:99;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
span.EmailStyle18
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:#1F497D;}
span.EmailStyle20
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.25in 1.0in 1.25in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Hi Brad/Andrew,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">As we discussed, I will upgrade Chassis based on C++ & sdbusplus by 3 steps.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Now, the step 1 is almost ready (Patch got two +1), so we can move on the step 2 “upstream the chassis implementation”.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Can you help create a repo “chassis-manager” for chassis implementation?<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">More info attached:<o:p></o:p></span></p>
<p class="MsoNormal"><img width="951" height="531" id="Picture_x0020_1" src="cid:image002.jpg@01D41E83.F326C3A0"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">
</span><img width="948" height="568" id="Picture_x0020_2" src="cid:image004.jpg@01D41E83.F326C3A0"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Thanks,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Kuiying.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> Andrew Geissler (Code Review) [<a href="mailto:gerrit@openbmc-project.xyz">mailto:gerrit@openbmc-project.xyz</a>]
<br>
<b>Sent:</b> Thursday, June 28, 2018 9:44 PM<br>
<b>To:</b> Wang, Kuiying <<a href="mailto:kuiying.wang@intel.com">kuiying.wang@intel.com</a>><br>
<b>Cc:</b> Jenkins <<a href="mailto:openbmc-ci-admin@ozlabs.org">openbmc-ci-admin@ozlabs.org</a>>; Brad Bishop <<a href="mailto:bradleyb@fuzziesquirrel.com">bradleyb@fuzziesquirrel.com</a>>; Tom Joseph <<a href="mailto:tomjoseph@in.ibm.com">tomjoseph@in.ibm.com</a>>;
Yong Li <<a href="mailto:yong.b.li@linux.intel.com">yong.b.li@linux.intel.com</a>>; Tanous, Ed <<a href="mailto:ed.tanous@intel.com">ed.tanous@intel.com</a>>; Richard Marian Thomaiyar <<a href="mailto:richard.marian.thomaiyar@linux.intel.com">richard.marian.thomaiyar@linux.intel.com</a>><br>
<b>Subject:</b> Change in openbmc/phosphor-dbus-interfaces[master]: Upgrade D-Bus API about Chassis Power Control from “/org/openbmc” to ...<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p>Andrew Geissler <strong>posted comments</strong> on this change.<o:p></o:p></p>
<p><a href="https://gerrit.openbmc-project.xyz/11278">View Change</a><o:p></o:p></p>
<p>Patch set 4:<o:p></o:p></p>
<p style="white-space:pre-wrap;word-wrap: break-word">ok, this is making more sense. I think what's a bit confusing is we'd pretty much completely deprecated pychassisctl with the new chassis and host state dbus interfaces I linked below. So if you want this
review to go quicker, removing that aspect from this review would be best (i.e. just stick with the Buttons). Otherwise we can bang it out in the community call in a few weeks. Breaking it up into smaller, more specific reviews is better in general anyway
I think. Thanks for refactoring these into C++ and defining their sdbusplus interfaces, it has always been on our TODO list but never made it to the top.<o:p></o:p></p>
<p>To view, visit <a href="https://gerrit.openbmc-project.xyz/11278">change 11278</a>. To unsubscribe, visit
<a href="https://gerrit.openbmc-project.xyz/settings">settings</a>.<o:p></o:p></p>
<div>
<p class="MsoNormal">Gerrit-Project: openbmc/phosphor-dbus-interfaces <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Gerrit-Branch: master <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Gerrit-MessageType: comment <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Gerrit-Change-Id: Iaf8990d19633d2df2beeb4b2c22f30f1abad6a45 <o:p>
</o:p></p>
</div>
<div>
<p class="MsoNormal">Gerrit-Change-Number: 11278 <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Gerrit-PatchSet: 4 <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Gerrit-Owner: <a href="mailto:kuiying.wang@intel.com">kuiying.wang@intel.com</a>
<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Gerrit-Reviewer: Andrew Geissler <<a href="mailto:geissonator@yahoo.com">geissonator@yahoo.com</a>>
<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Gerrit-Reviewer: Brad Bishop <<a href="mailto:bradleyb@fuzziesquirrel.com">bradleyb@fuzziesquirrel.com</a>>
<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Gerrit-Reviewer: Ed Tanous <<a href="mailto:ed.tanous@intel.com">ed.tanous@intel.com</a>>
<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Gerrit-Reviewer: Jenkins <<a href="mailto:openbmc-ci-admin@ozlabs.org">openbmc-ci-admin@ozlabs.org</a>>
<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Gerrit-Reviewer: Jia, Chunhui <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Gerrit-Reviewer: Richard Marian Thomaiyar <<a href="mailto:richard.marian.thomaiyar@linux.intel.com">richard.marian.thomaiyar@linux.intel.com</a>>
<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Gerrit-Reviewer: Tom Joseph <<a href="mailto:tomjoseph@in.ibm.com">tomjoseph@in.ibm.com</a>>
<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Gerrit-Reviewer: Yong Li <<a href="mailto:yong.b.li@linux.intel.com">yong.b.li@linux.intel.com</a>>
<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Gerrit-Reviewer: <a href="mailto:kuiying.wang@intel.com">kuiying.wang@intel.com</a>
<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Gerrit-Comment-Date: Thu, 28 Jun 2018 13:44:21 +0000 <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Gerrit-HasComments: No <o:p></o:p></p>
</div>
</div>
</body>
</html>