<div dir="ltr">Hi Rob,<br><div class="gmail_extra"><br><div class="gmail_quote">On 16 July 2018 at 20:48, Rob Herring <span dir="ltr"><<a href="mailto:robh@kernel.org" target="_blank">robh@kernel.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On Fri, Jul 13, 2018 at 12:42:02AM +0300, Tomer Maimon wrote:<br>
> Added device tree binding documentation for Nuvoton BMC<br>
> NPCM750/730/715/705 pinmux and GPIO controller.<br>
> <br>
> Signed-off-by: Tomer Maimon <<a href="mailto:tmaimon77@gmail.com">tmaimon77@gmail.com</a>><br>
> ---<br>
> .../bindings/pinctrl/nuvoton,<wbr>npcm7xx-pinctrl.txt | 216 +++++++++++++++++++++<br>
> 1 file changed, 216 insertions(+)<br>
> create mode 100644 Documentation/devicetree/<wbr>bindings/pinctrl/nuvoton,<wbr>npcm7xx-pinctrl.txt<br>
> <br>
> diff --git a/Documentation/devicetree/<wbr>bindings/pinctrl/nuvoton,<wbr>npcm7xx-pinctrl.txt b/Documentation/devicetree/<wbr>bindings/pinctrl/nuvoton,<wbr>npcm7xx-pinctrl.txt<br>
> new file mode 100644<br>
> index 000000000000..83f4bbac94bb<br>
> --- /dev/null<br>
> +++ b/Documentation/devicetree/<wbr>bindings/pinctrl/nuvoton,<wbr>npcm7xx-pinctrl.txt<br>
> @@ -0,0 +1,216 @@<br>
> +Nuvoton NPCM7XX Pin Controllers<br>
> +<br>
> +The Nuvoton BMC NPCM7XX Pin Controller multi-function routed through<br>
> +the multiplexing block, Each pin supports GPIO functionality (GPIOx)<br>
> +and multiple functions that directly connect the pin to different<br>
> +hardware blocks.<br>
> +<br>
> +Required properties:<br>
> +- #address-cells : should be 1.<br>
> +- #size-cells : should be 1.<br>
> +- compatible : "nuvoton,npcm750-pinctrl" for Poleg NPCM7XX.<br>
> +- ranges : defines mapping ranges between pin controller node (parent)<br>
> + to GPIO bank node (children).<br>
> +<br>
> +=== GPIO Bank Subnode ===<br>
> +<br>
> +The NPCM7XX has 8 GPIO Banks each GPIO bank supports 32 GPIO.<br>
> +<br>
> +Required GPIO Bank subnode-properties:<br>
> +- reg : specifies physical base address and size of the GPIO<br>
> + bank registers.<br>
> +- gpio-controller : Marks the device node as a GPIO controller.<br>
> +- #gpio-cells : Must be <2>. The first cell is the gpio pin number<br>
> + and the second cell is used for optional parameters.<br>
> +- interrupts : contain the GPIO bank interrupt with flags for falling edge.<br>
> +- gpio-ranges : defines the range of pins managed by the GPIO bank controller.<br>
> +<br>
> +For example, GPIO bank subnodes like the following:<br>
> + gpio0: gpio@f0010000 {<br>
> + gpio-controller;<br>
> + #gpio-cells = <2>;<br>
> + reg = <0x0 0x80>;<br>
> + interrupts = <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>;<br>
> + gpio-ranges = <&pinctrl 0 0 32>;<br>
> + };<br>
> +<br>
> +=== Pin Mux Subnode ===<br>
> +<br>
> +- pin: A string containing the name of the pin<br>
> + An array of strings, each string containing the name of a pin.<br>
> + These pin are used for selecting pin configuration.<br>
> +<br>
> +The following are the list of pins available:<br>
> + "GPIO0/IOX1DI", "GPIO1/IOX1LD", "GPIO2/IOX1CK", "GPIO3/IOX1D0",<br>
> + "GPIO4/IOX2DI/SMB1DSDA", "GPIO5/IOX2LD/SMB1DSCL", "GPIO6/IOX2CK/SMB2DSDA",<br>
> + "GPIO7/IOX2D0/SMB2DSCL", "GPIO8/LKGPO1", "GPIO9/LKGPO2", "GPIO10/IOXHLD",<br>
> + "GPIO11/IOXHCK", "GPIO12/GSPICK/SMB5BSCL", "GPIO13/GSPIDO/SMB5BSDA",<br>
> + "GPIO14/GSPIDI/SMB5CSCL", "GPIO15/GSPICS/SMB5CSDA", "GPIO16/LKGPO0",<br>
> + "GPIO17/PSPI2DI/SMB4DEN","<wbr>GPIO18/PSPI2D0/SMB4BSDA", "GPIO19/PSPI2CK/SMB4BSCL",<br>
> + "GPIO20/SMB4CSDA/SMB15SDA", "GPIO21/SMB4CSCL/SMB15SCL", "GPIO22/SMB4DSDA/SMB14SDA",<br>
> + "GPIO23/SMB4DSCL/SMB14SCL", "GPIO24/IOXHDO", "GPIO25/IOXHDI", "GPIO26/SMB5SDA",<br>
> + "GPIO27/SMB5SCL", "GPIO28/SMB4SDA", "GPIO29/SMB4SCL", "GPIO30/SMB3SDA",<br>
> + "GPIO31/SMB3SCL", "GPIO32/nSPI0CS1","SPI0D2", "SPI0D3", "GPIO37/SMB3CSDA",<br>
> + "GPIO38/SMB3CSCL", "GPIO39/SMB3BSDA", "GPIO40/SMB3BSCL", "GPIO41/BSPRXD",<br>
> + "GPO42/BSPTXD/STRAP11", "GPIO43/RXD1/JTMS2/BU1RXD", "GPIO44/nCTS1/JTDI2/BU1CTS",<br>
> + "GPIO45/nDCD1/JTDO2", "GPIO46/nDSR1/JTCK2", "GPIO47/nRI1/JCP_RDY2",<br>
> + "GPIO48/TXD2/BSPTXD", "GPIO49/RXD2/BSPRXD", "GPIO50/nCTS2", "GPO51/nRTS2/STRAP2",<br>
> + "GPIO52/nDCD2", "GPO53/nDTR2_BOUT2/STRAP1", "GPIO54/nDSR2", "GPIO55/nRI2",<br>
> + "GPIO56/R1RXERR", "GPIO57/R1MDC", "GPIO58/R1MDIO", "GPIO59/SMB3DSDA",<br>
> + "GPIO60/SMB3DSCL", "GPO61/nDTR1_BOUT1/STRAP6", "GPO62/nRTST1/STRAP5",<br>
> + "GPO63/TXD1/STRAP4", "GPIO64/FANIN0", "GPIO65/FANIN1", "GPIO66/FANIN2",<br>
> + "GPIO67/FANIN3", "GPIO68/FANIN4", "GPIO69/FANIN5", "GPIO70/FANIN6", "GPIO71/FANIN7",<br>
> + "GPIO72/FANIN8", "GPIO73/FANIN9", "GPIO74/FANIN10", "GPIO75/FANIN11",<br>
> + "GPIO76/FANIN12", "GPIO77/FANIN13","GPIO78/<wbr>FANIN14", "GPIO79/FANIN15",<br>
> + "GPIO80/PWM0", "GPIO81/PWM1", "GPIO82/PWM2", "GPIO83/PWM3", "GPIO84/R2TXD0",<br>
> + "GPIO85/R2TXD1", "GPIO86/R2TXEN", "GPIO87/R2RXD0", "GPIO88/R2RXD1", "GPIO89/R2CRSDV",<br>
> + "GPIO90/R2RXERR", "GPIO91/R2MDC", "GPIO92/R2MDIO", "GPIO93/GA20/SMB5DSCL",<br>
> + "GPIO94/nKBRST/SMB5DSDA", "GPIO95/nLRESET/nESPIRST", "GPIO96/RG1TXD0",<br>
> + "GPIO97/RG1TXD1", "GPIO98/RG1TXD2", "GPIO99/RG1TXD3","GPIO100/<wbr>RG1TXC",<br>
> + "GPIO101/RG1TXCTL", "GPIO102/RG1RXD0", "GPIO103/RG1RXD1", "GPIO104/RG1RXD2",<br>
> + "GPIO105/RG1RXD3", "GPIO106/RG1RXC", "GPIO107/RG1RXCTL", "GPIO108/RG1MDC",<br>
> + "GPIO109/RG1MDIO", "GPIO110/RG2TXD0/DDRV0", "GPIO111/RG2TXD1/DDRV1",<br>
> + "GPIO112/RG2TXD2/DDRV2", "GPIO113/RG2TXD3/DDRV3", "GPIO114/SMB0SCL",<br>
> + "GPIO115/SMB0SDA", "GPIO116/SMB1SCL", "GPIO117/SMB1SDA", "GPIO118/SMB2SCL",<br>
> + "GPIO119/SMB2SDA", "GPIO120/SMB2CSDA", "GPIO121/SMB2CSCL", "GPIO122/SMB2BSDA",<br>
> + "GPIO123/SMB2BSCL", "GPIO124/SMB1CSDA", "GPIO125/SMB1CSCL","GPIO126/<wbr>SMB1BSDA",<br>
> + "GPIO127/SMB1BSCL", "GPIO128/SMB8SCL", "GPIO129/SMB8SDA", "GPIO130/SMB9SCL",<br>
> + "GPIO131/SMB9SDA", "GPIO132/SMB10SCL", "GPIO133/SMB10SDA","GPIO134/<wbr>SMB11SCL",<br>
> + "GPIO135/SMB11SDA", "GPIO136/SD1DT0", "GPIO137/SD1DT1", "GPIO138/SD1DT2",<br>
> + "GPIO139/SD1DT3", "GPIO140/SD1CLK", "GPIO141/SD1WP", "GPIO142/SD1CMD",<br>
> + "GPIO143/SD1CD/SD1PWR", "GPIO144/PWM4", "GPIO145/PWM5", "GPIO146/PWM6",<br>
> + "GPIO147/PWM7", "GPIO148/MMCDT4", "GPIO149/MMCDT5", "GPIO150/MMCDT6",<br>
> + "GPIO151/MMCDT7", "GPIO152/MMCCLK", "GPIO153/MMCWP", "GPIO154/MMCCMD",<br>
> + "GPIO155/nMMCCD/nMMCRST", "GPIO156/MMCDT0", "GPIO157/MMCDT1", "GPIO158/MMCDT2",<br>
> + "GPIO159/MMCDT3", "GPIO160/CLKOUT/RNGOSCOUT", "GPIO161/nLFRAME/nESPICS",<br>
> + "GPIO162/SERIRQ", "GPIO163/LCLK/ESPICLK", "GPIO164/LAD0/ESPI_IO0",<br>
> + "GPIO165/LAD1/ESPI_IO1", "GPIO166/LAD2/ESPI_IO2", "GPIO167/LAD3/ESPI_IO3",<br>
> + "GPIO168/nCLKRUN/nESPIALERT", "GPIO169/nSCIPME", "GPIO170/nSMI", "GPIO171/SMB6SCL",<br>
> + "GPIO172/SMB6SDA", "GPIO173/SMB7SCL", "GPIO174/SMB7SDA", "GPIO175/PSPI1CK/FANIN19",<br>
> + "GPIO176/PSPI1DO/FANIN18", "GPIO177/PSPI1DI/FANIN17", "GPIO178/R1TXD0",<br>
> + "GPIO179/R1TXD1", "GPIO180/R1TXEN", "GPIO181/R1RXD0", "GPIO182/R1RXD1",<br>
> + "GPIO183/SPI3CK", "GPO184/SPI3D0/STRAP9", "GPO185/SPI3D1/STRAP10",<br>
> + "GPIO186/nSPI3CS0", "GPIO187/nSPI3CS1", "GPIO188/SPI3D2/nSPI3CS2",<br>
> + "GPIO189/SPI3D3/nSPI3CS3", "GPIO190/nPRD_SMI", "GPIO191", "GPIO192", "GPIO193/R1CRSDV",<br>
> + "GPIO194/SMB0BSCL", "GPIO195/SMB0BSDA", "GPIO196/SMB0CSCL", "GPIO197/SMB0DEN",<br>
> + "GPIO198/SMB0DSDA", "GPIO199/SMB0DSCL", "GPIO200/R2CK", "GPIO201/R1CK",<br>
> + "GPIO202/SMB0CSDA", "GPIO203/FANIN16", "GPIO204/DDC2SCL", "GPIO205/DDC2SDA",<br>
> + "GPIO206/HSYNC2", "GPIO207/VSYNC2", "GPIO208/RG2TXC/DVCK", "GPIO209/RG2TXCTL/DDRV4",<br>
> + "GPIO210/RG2RXD0/DDRV5", "GPIO211/RG2RXD1/DDRV6", "GPIO212/RG2RXD2/DDRV7",<br>
> + "GPIO213/RG2RXD3/DDRV8", "GPIO214/RG2RXC/DDRV9", "GPIO215/RG2RXCTL/DDRV10",<br>
> + "GPIO216/RG2MDC/DDRV11", "GPIO217/RG2MDIO/DVHSYNC", "GPIO218/nWDO1",<br>
> + "GPIO219/nWDO2", "GPIO220/SMB12SCL", "GPIO221/SMB12SDA", "GPIO222/SMB13SCL",<br>
> + "GPIO223/SMB13SDA", "GPIO224/SPIXCK", "GPO225/SPIXD0/STRAP12", "GPO226/SPIXD1/STRAP13",<br>
> + "GPIO227/nSPIXCS0", "GPIO228/nSPIXCS1", "GPO229/SPIXD2/STRAP3", "GPIO230/SPIXD3",<br>
> + "GPIO231/nCLKREQ", "GPI255/DACOSEL"<br>
> +<br>
> +Optional Properties:<br>
> + bias-disable, bias-pull-down, bias-pull-up, input-enable,<br>
> + input-disable, output-high, output-low, drive-push-pull,<br>
> + drive-open-drain, input-debounce, slew-rate, drive-strength<br>
> +<br>
> + slew-rate valid arguments are:<br>
> + <0> - slow<br>
> + <1> - fast<br>
> + drive-strength valid arguments are:<br>
> + <2> - 2mA<br>
> + <4> - 4mA<br>
> + <8> - 8mA<br>
> + <12> - 12mA<br>
> + <16> - 16mA<br>
> + <24> - 24mA<br>
> +<br>
> +For example, pinctrl might have pinmux subnodes like the following:<br>
> +<br>
> + gpio0_iox1d1_pin: gpio0-iox1d1-pin {<br>
> + pins = "GPIO0/IOX1DI";<br>
> + output-high;<br>
> + };<br>
> + gpio0_iox1ck_pin: gpio0-iox1ck-pin {<br>
> + pins = "GPIO2/IOX1CK";<br>
> + output_high;<br>
> + };<br>
> +<br>
> +=== Pin Group Subnode ===<br>
> +<br>
> +Required pin group subnode-properties:<br>
> +- groups : A string containing the name of the group to mux.<br>
> +- function: A string containing the name of the function to mux to the<br>
> + group.<br>
> +<br>
> +The following are the list of the available groups and functions :<br>
> + smb0, smb0b, smb0c, smb0d, smb0den, smb1, smb1b, smb1c, smb1d,<br>
> + smb2, smb2b, smb2c, smb2d, smb3, smb3b, smb3c, smb3d, smb4, smb4b,<br>
> + smb4c, smb4d, smb4den, smb5, smb5b, smb5c, smb5d, ga20kbc, smb6,<br>
> + smb7, smb8, smb9, smb10, smb11, smb12, smb13, smb14, smb15, fanin0,<br>
> + fanin1, fanin2, fanin3, fanin4, fanin5, fanin6, fanin7, fanin8,<br>
> + fanin9, fanin10, fanin11 fanin12 fanin13, fanin14, fanin15, faninx,<br>
> + pwm0, pwm1, pwm2, pwm3, pwm4, pwm5, pwm6, pwm7, rg1, rg1mdio, rg2,<br>
> + rg2mdio, ddr, uart1, uart2, bmcuart0a, bmcuart0b, bmcuart1, iox1,<br>
> + iox2, ioxh, gspi, mmc, mmcwp, mmccd, mmcrst, mmc8, r1, r1err, r1md,<br>
> + r2, r2err, r2md, sd1, sd1pwr, wdog1, wdog2, scipme, sci, serirq,<br>
> + jtag2, spix, spixcs1, pspi1, pspi2, ddc, clkreq, clkout, spi3, spi3cs1,<br>
> + spi3quad, spi3cs2, spi3cs3, spi0cs1, lpc, lpcclk, espi, lkgpo0, lkgpo1,<br>
> + lkgpo2, nprd_smi<br>
> +<br>
> +For example, pinctrl might have group subnodes like the following:<br>
> + r1err_pins: r1err-pins {<br>
> + groups = "r1err";<br>
> + function = "r1err";<br>
> + };<br>
> + r1md_pins: r1md-pins {<br>
> + groups = "r1md";<br>
> + function = "r1md";<br>
> + };<br>
> + r1_pins: r1-pins {<br>
> + groups = "r1";<br>
> + function = "r1";<br>
> + };<br>
> +<br>
> +Examples<br>
> +========<br>
> +pinctrl: pinctrl@f0800000 {<br>
<br>
</div></div>reg is missing or this doesn't match ranges.<br></blockquote><div><br></div><div>the Control of the Pinmux is through the GCR (General control register), and because the GCR controlling also on other things</div><div>in the BMC we have a separate node for the GCR and it handled by regmap.</div><div>GCR node in our device tree:<br></div><div><br></div><div><span style="color:rgb(0,0,0);font-family:"Courier New";font-size:11pt"> gcr: gcr@800000 {</span><br></div><div><div style="font-family:"Courier New";font-size:11pt;color:rgb(0,0,0);background-color:rgb(255,255,255);font-weight:normal;text-decoration:none"><pre> compatible = "nuvoton,npcm750-gcr", "syscon",
"simple-mfd";
reg = <0x800000 0x1000>;
};</pre><pre><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;white-space:normal;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial">The address of the GCR is f0800000 this is why the pinctrl name pinctrl@f0800000</div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;white-space:normal;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial">please let me know if it is better to modify it to the GPIO address.</div></pre></div></div><div style="font-size:small;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial">the ranges is address GPIO ranges </div><br class="gmail-Apple-interchange-newline">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5"><br>
> + #address-cells = <1>;<br>
> + #size-cells = <1>;<br>
> + compatible = "nuvoton,npcm750-pinctrl";<br>
> + ranges = <0 0xf0010000 0x8000>;<br>
> +<br>
> + gpio0: gpio@f0010000 {<br>
> + gpio-controller;<br>
> + #gpio-cells = <2>;<br>
> + reg = <0x0 0x80>;<br>
> + interrupts = <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>;<br>
> + gpio-ranges = <&pinctrl 0 0 32>;<br>
> + };<br>
> +<br>
> + ....<br>
> +<br>
> + gpio7: gpio@f0017000 {<br>
> + gpio-controller;<br>
> + #gpio-cells = <2>;<br>
> + reg = <0x7000 0x80>;<br>
> + interrupts = <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>;<br>
> + gpio-ranges = <&pinctrl 0 224 32>;<br>
> + };<br>
> +<br>
> + gpio0_iox1d1_pin: gpio0-iox1d1-pin {<br>
> + pins = "GPIO0/IOX1DI";<br>
> + output-high;<br>
> + };<br>
> +<br>
> + iox1_pins: iox1-pins {<br>
> + groups = "iox1";<br>
> + function = "iox1";<br>
> + };<br>
> + iox2_pins: iox2-pins {<br>
> + groups = "iox2";<br>
> + function = "iox2";<br>
> + };<br>
> +<br>
> + ....<br>
> +<br>
> + clkreq_pins: clkreq-pins {<br>
> + groups = "clkreq";<br>
> + function = "clkreq";<br>
> + };<br>
> +};<br>
> \ No newline at end of file<br>
<br>
</div></div>^^^<br></blockquote><div><br></div><div>Thanks,</div><div><br></div><div>Tomer </div></div><br></div></div>