<div dir="ltr">Hi Rob,<div><br></div><div>Thanks for your review</div><div class="gmail_extra"><br><div class="gmail_quote">On 3 July 2018 at 19:45, Rob Herring <span dir="ltr"><<a href="mailto:robh@kernel.org" target="_blank">robh@kernel.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-">On Tue, Jul 03, 2018 at 12:47:00PM +0300, Tomer Maimon wrote:<br>
> Added device tree binding documentation for Nuvoton BMC<br>
> NPCM7xx Pulse Width Modulation (PWM) and Fan tach controller.<br>
> The PWM controller can support upto 8 PWM output ports.<br>
> The Fan tach controller can support upto 16 tachometer inputs.<br>
> <br>
> Signed-off-by: Tomer Maimon <<a href="mailto:tmaimon77@gmail.com">tmaimon77@gmail.com</a>><br>
> ---<br>
> .../devicetree/bindings/hwmon/<wbr>npcm750-pwm-fan.txt | 87 ++++++++++++++++++++++<br>
> 1 file changed, 87 insertions(+)<br>
> create mode 100644 Documentation/devicetree/<wbr>bindings/hwmon/npcm750-pwm-<wbr>fan.txt<br>
> <br>
> diff --git a/Documentation/devicetree/<wbr>bindings/hwmon/npcm750-pwm-<wbr>fan.txt b/Documentation/devicetree/<wbr>bindings/hwmon/npcm750-pwm-<wbr>fan.txt<br>
> new file mode 100644<br>
> index 000000000000..c56d72d03717<br>
> --- /dev/null<br>
> +++ b/Documentation/devicetree/<wbr>bindings/hwmon/npcm750-pwm-<wbr>fan.txt<br>
> @@ -0,0 +1,87 @@<br>
> +Nuvoton NPCM7xx PWM and Fan Tacho controller device<br>
> +<br>
> +The NPCM7xx has two identical Pulse-width modulation (PWM) controller modules,<br>
> +Each PWM module has four PWM controller outputs, Totally 8 PWM controller outputs.<br>
<br>
</span>Kind of sounds like this should be 2 nodes then?<br></blockquote><div><br></div><div>we preferred one node, I think the channel description it little confusing... i will rewrite it to</div><div>" The Nuvoton BMC NPCM7XX supports 8 Pulse-width modulation (PWM)</div><div>controller outputs and 16 Fan tachometer controller inputs."</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<span class="gmail-"><br>
> +<br>
> +The NPCM7xx has eight identical Fan tachometer controller modules,<br>
> +Each Fan module has two Fan controller inputs, Totally 16 Fan controller inputs.<br>
> +<br>
> +Required properties for pwm-fan node<br>
> +- #address-cells : should be 1.<br>
> +- #size-cells : should be 0.<br>
> +- compatible : "nuvoton,npcm750-pwm-fan" for Poleg NPCM7XX.<br>
> +- reg : specifies physical base address and size of the registers.<br>
> +- reg-names : must contain:<br>
> + * "pwm" for the PWM registers.<br>
> + * "fan" for the Fan registers.<br>
> +- clocks : phandle of reference clocks.<br>
> +- clock-names : must contain<br>
> + * "clk_apb3" for clock of PWM controller.<br>
> + * "clk_apb4" for clock of Fan controller.<br>
<br>
</span>The "clk_" part is redundant.<br>
<br>
Also, this should be the names of the clocks in the module, not the name <br>
of the source clocks. It seems like these may be the latter?<br></blockquote><div>will change to "pwm" and "fan"</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div><div class="gmail-h5"><br>
> +- interrupts : contain the Fan interrupts with flags for falling edge.<br>
> +- pinctrl-names : a pinctrl state named "default" must be defined.<br>
> +- pinctrl-0 : phandle referencing pin configuration of the PWM and Fan<br>
> + controller ports.<br>
> +<br>
> +fan subnode format:<br>
> +===================<br>
> +Under fan subnode can be upto 8 child nodes, each child node representing a fan.<br>
> +Each fan subnode must have one PWM channel and atleast one Fan tach channel.<br>
> +<br>
> +For PWM channel can be configured cooling-levels to create cooling device.<br>
> +Cooling device could be bound to a thermal zone for the thermal control.<br>
> +<br>
> +Required properties for each child node:<br>
> +- reg : specify the PWM output channel.<br>
> + integer value in the range 0 through 7, that represent<br>
> + the PWM channel number that used.<br>
> +<br>
> +- fan-tach-ch : specify the Fan tach input channel.<br>
> + integer value in the range 0 through 15, that represent<br>
> + the fan tach channel number that used.<br>
> +<br>
> + At least one Fan tach input channel is required<br>
> +<br>
> +Optional property for each child node:<br>
> +- cooling-levels: PWM duty cycle values in a range from 0 to 255<br>
> + which correspond to thermal cooling states.<br>
> +<br>
> +Examples:<br>
> +<br>
> +pwm_fan:pwm-fan-controller@<wbr>103000 {<br>
> + #address-cells = <1>;<br>
> + #size-cells = <0>;<br>
> + compatible = "nuvoton,npcm750-pwm-fan";<br>
> + reg = <0x103000 0x2000>,<br>
> + <0x180000 0x8000>;<br>
> + reg-names = "pwm", "fan";<br>
> + clocks = <&clk NPCM7XX_CLK_APB3>,<br>
> + <&clk NPCM7XX_CLK_APB4>;<br>
> + clock-names = "clk_apb3","clk_apb4";<br>
> + interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>,<br>
> + <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>,<br>
> + <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>,<br>
> + <GIC_SPI 99 IRQ_TYPE_LEVEL_HIGH>,<br>
> + <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>,<br>
> + <GIC_SPI 101 IRQ_TYPE_LEVEL_HIGH>,<br>
> + <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>,<br>
> + <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;<br>
> + pinctrl-names = "default";<br>
> + pinctrl-0 = <&pwm0_pins &pwm1_pins &pwm2_pins<br>
> + &fanin0_pins &fanin1_pins &fanin2_pins<br>
> + &fanin3_pins &fanin4_pins>;<br>
> + fan@0 {<br>
> + reg = <0x00>;<br>
> + fan-ch = /bits/ 8 <0x00 0x01>;<br>
<br>
</div></div>Doesn't match the doc.<br>
<div class="gmail-HOEnZb"><div class="gmail-h5"><br>
> + cooling-levels = <127 255>;<br>
> + };<br>
> + fan@1 {<br>
> + reg = <0x01>;<br>
> + fan-ch = /bits/ 8 <0x02 0x03>;<br>
> + };<br>
> + fan@2 {<br>
> + reg = <0x02>;<br>
> + fan-ch = /bits/ 8 <0x04>;<br>
> + };<br>
> +<br>
> +};<br>
> \ No newline at end of file<br>
> -- <br>
> 2.14.1<br>
> <br>
</div></div></blockquote></div><br></div><div class="gmail_extra">Thanks a lot</div><div class="gmail_extra"><br></div><div class="gmail_extra">Tomer</div></div>