<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On 16 March 2018 at 07:52, Brendan Higgins <span dir="ltr"><<a href="mailto:brendanhiggins@google.com" target="_blank">brendanhiggins@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>On Thu, Mar 15, 2018 at 4:16 PM Tomer Maimon <<a href="mailto:tmaimon77@gmail.com" target="_blank">tmaimon77@gmail.com</a>> wrote:<br>
<br>
> Enable L2 Cache in Nuvoton NPCM7xx BMC.<br>
<br>
> Signed-off-by: Tomer Maimon <<a href="mailto:tmaimon77@gmail.com" target="_blank">tmaimon77@gmail.com</a>><br>
> ---<br>
>   arch/arm/mach-npcm/npcm7xx.c | 2 ++<br>
>   1 file changed, 2 insertions(+)<br>
<br>
> diff --git a/arch/arm/mach-npcm/npcm7xx.c b/arch/arm/mach-npcm/npcm7xx.c<br>
> index 5f7cd88103ef..c5f77d854c4f 100644<br>
> --- a/arch/arm/mach-npcm/npcm7xx.c<br>
> +++ b/arch/arm/mach-npcm/npcm7xx.c<br>
> @@ -17,4 +17,6 @@ static const char *const npcm7xx_dt_match[] = {<br>
>   DT_MACHINE_START(NPCM7XX_DT, "NPCM7XX Chip family")<br>
>          .atag_offset    = 0x100,<br>
>          .dt_compat      = npcm7xx_dt_match,<br>
> +       .l2c_aux_val    = 0x0,<br>
> +       .l2c_aux_mask   = ~0x0,<br>
<br>
</span>You need to limit this to the specific bit(s) you want to set and verify<br>
that<br>
the l2c driver does not already manage that bit appropriately and that it<br>
can<br>
not be specified via the dtsi.<br></blockquote><div><br></div><div>Do you mean that I need to specify it the same as been done in V7?</div><div>because when I run with the above <span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration-style:initial;text-decoration-color:initial;background-color:rgb(255,255,255);float:none;display:inline">l2c_aux_val and <span> </span><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">l2c_aux_mask parameters</span></span>

 I get the same result.</div><div><br></div><div>Also if I am not adding the <span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">l2c_aux_val and 

<span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">l2c_aux_mask parameters to the 

<span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">DT_MACHINE_START</span>

</span></span><br></div><div><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline"><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">the L2C cache does not initialize. </span></span></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
We discussed this a little while ago with Rob here:<br>
<a href="https://www.spinics.net/lists/arm-kernel/msg613372.html" rel="noreferrer" target="_blank">https://www.spinics.net/lists/<wbr>arm-kernel/msg613372.html</a></blockquote><div><br></div><div>Sorry in this link I see only Russel king comment regarding the L2C </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
<br>
>   MACHINE_END<br>
> --<br>
> 2.14.1<br>
<br>
<br>
Cheers<br></blockquote><div><br></div><div>Cheers </div></div><br></div></div>