<div dir="rtl"><div style="text-align:left" dir="ltr"><br></div><div class="gmail_extra" dir="ltr"><div style="text-align:left"><br></div><div class="gmail_quote"><div>2017-09-06 11:07 GMT+03:00 Brendan Higgins <span dir="ltr"><<a href="mailto:brendanhiggins@google.com" target="_blank">brendanhiggins@google.com</a>></span>:</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="text-align:left">Adds basic support for the Nuvoton NPCM750 BMC.</div><span class="gmail-"><div style="text-align:left"><br></div>
<div style="text-align:left">Signed-off-by: Brendan Higgins <<a href="mailto:brendanhiggins@google.com">brendanhiggins@google.com</a>></div><div style="text-align:left">---</div><div style="text-align:left"> arch/arm/Kconfig | 2 +</div><div style="text-align:left"> arch/arm/Makefile | 1 +</div>
</span><div style="text-align:left"> arch/arm/mach-npcm/Kconfig | 50 +++++++++++++++++++++++++</div><div style="text-align:left"> arch/arm/mach-npcm/Makefile | 3 ++</div><div style="text-align:left"> arch/arm/mach-npcm/headsmp.S | 17 +++++++++</div><div style="text-align:left"> arch/arm/mach-npcm/npcm7xx.c | 34 +++++++++++++++++</div><div style="text-align:left"> arch/arm/mach-npcm/platsmp.c | 89 ++++++++++++++++++++++++++++++<wbr>++++++++++++++</div><div style="text-align:left"> 7 files changed, 196 insertions(+)</div>
<div><div class="gmail-h5"><div style="text-align:left"> create mode 100644 arch/arm/mach-npcm/Kconfig</div><div style="text-align:left"> create mode 100644 arch/arm/mach-npcm/Makefile</div><div style="text-align:left"> create mode 100644 arch/arm/mach-npcm/headsmp.S</div><div style="text-align:left"> create mode 100644 arch/arm/mach-npcm/npcm7xx.c</div><div style="text-align:left"> create mode 100644 arch/arm/mach-npcm/platsmp.c</div>
<div style="text-align:left"><br></div><div style="text-align:left">diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig</div><div style="text-align:left">index 61a0cb15067e..05543f1cfbde 100644</div><div style="text-align:left">--- a/arch/arm/Kconfig</div><div style="text-align:left">+++ b/arch/arm/Kconfig</div><div style="text-align:left">@@ -782,6 +782,8 @@ source "arch/arm/mach-netx/Kconfig"</div>
<div style="text-align:left"><br></div><div style="text-align:left"> source "arch/arm/mach-nomadik/<wbr>Kconfig"</div>
<div style="text-align:left"><br></div><div style="text-align:left">+source "arch/arm/mach-npcm/Kconfig"</div><div style="text-align:left">+</div><div style="text-align:left"> source "arch/arm/mach-nspire/Kconfig"</div>
<div style="text-align:left"><br></div><div style="text-align:left"> source "arch/arm/plat-omap/Kconfig"</div><div style="text-align:left">diff --git a/arch/arm/Makefile b/arch/arm/Makefile</div><div style="text-align:left">index 47d3a1ab08d2..60ca50c7d762 100644</div><div style="text-align:left">--- a/arch/arm/Makefile</div><div style="text-align:left">+++ b/arch/arm/Makefile</div><div style="text-align:left">@@ -191,6 +191,7 @@ machine-$(CONFIG_ARCH_<wbr>MEDIATEK) += mediatek</div><div style="text-align:left"> machine-$(CONFIG_ARCH_MXS) += mxs</div><div style="text-align:left"> machine-$(CONFIG_ARCH_NETX) += netx</div><div style="text-align:left"> machine-$(CONFIG_ARCH_NOMADIK) += nomadik</div><div style="text-align:left">+machine-$(CONFIG_ARCH_NPCM) += npcm</div><div style="text-align:left"> machine-$(CONFIG_ARCH_NSPIRE) += nspire</div><div style="text-align:left"> machine-$(CONFIG_ARCH_OXNAS) += oxnas</div><div style="text-align:left"> machine-$(CONFIG_ARCH_OMAP1) += omap1</div><div style="text-align:left">diff --git a/arch/arm/mach-npcm/Kconfig b/arch/arm/mach-npcm/Kconfig</div><div style="text-align:left">new file mode 100644</div>
</div></div><div style="text-align:left">index 000000000000..d47061855439</div><div style="text-align:left">--- /dev/null</div><div style="text-align:left">+++ b/arch/arm/mach-npcm/Kconfig</div><div style="text-align:left">@@ -0,0 +1,50 @@</div>
<span class="gmail-"><div style="text-align:left">+menuconfig ARCH_NPCM</div><div style="text-align:left">+ bool "Nuvoton NPCM Architecture"</div><div style="text-align:left">+ select ARCH_REQUIRE_GPIOLIB</div><div style="text-align:left">+ select USE_OF</div><div style="text-align:left">+ select PINCTRL</div><div style="text-align:left">+ select PINCTRL_NPCM7XX</div><div style="text-align:left">+</div><div style="text-align:left">+if ARCH_NPCM</div><div style="text-align:left">+</div><div style="text-align:left">+comment "NPCMX50 CPU type"</div><div style="text-align:left">+</div><div style="text-align:left">+config CPU_NPCM750</div><div style="text-align:left">+ depends on ARCH_NPCM && ARCH_MULTI_V7</div>
</span><span class="gmail-"><div style="text-align:left">+ bool "Support for NPCM750 BMC CPU (Poleg)"</div><div style="text-align:left">+ select CACHE_L2X0</div><div style="text-align:left">+ select CPU_V7</div><div style="text-align:left">+ select ARM_GIC</div>
</span><div style="text-align:left">+ select HAVE_SMP</div><div style="text-align:left">+ select SMP</div><div style="text-align:left">+ select SMP_ON_UP</div><div style="text-align:left">+ select HAVE_ARM_SCU</div>
<span class="gmail-"><div style="text-align:left">+ select HAVE_ARM_TWD if SMP</div>
</span><div style="text-align:left">+ select ARM_ERRATA_458693</div><div style="text-align:left">+ select ARM_ERRATA_720789</div><div style="text-align:left">+ select ARM_ERRATA_742231</div>
<span class="gmail-"><div style="text-align:left">+ select ARM_ERRATA_754322</div><div style="text-align:left">+ select ARM_ERRATA_764369</div>
</span><span class="gmail-"><div style="text-align:left">+ select ARM_ERRATA_794072</div><div style="text-align:left">+ select PL310_ERRATA_588369</div><div style="text-align:left">+ select PL310_ERRATA_727915</div>
</span><span class="gmail-"><div style="text-align:left">+ select USB_EHCI_ROOT_HUB_TT</div><div style="text-align:left">+ select USB_ARCH_HAS_HCD</div><div style="text-align:left">+ select USB_ARCH_HAS_EHCI</div><div style="text-align:left">+ select USB_EHCI_HCD</div><div style="text-align:left">+ select USB_ARCH_HAS_OHCI</div><div style="text-align:left">+ select USB_OHCI_HCD</div><div style="text-align:left">+ select USB</div><div style="text-align:left">+ select FIQ</div><div style="text-align:left">+ select CPU_USE_DOMAINS</div>
</span><div style="text-align:left">+ select GENERIC_CLOCKEVENTS</div>
<span class="gmail-"><div style="text-align:left">+ select CLKDEV_LOOKUP</div><div style="text-align:left">+ select COMMON_CLK if OF</div>
</span><span class="gmail-"><div style="text-align:left">+ select NPCM750_TIMER</div><div style="text-align:left">+ select MFD_SYSCON</div><div style="text-align:left">+ help</div>
</span><div style="text-align:left">+ Support for NPCM750 BMC CPU (Poleg).</div><div style="text-align:left">+</div><div style="text-align:left">+ Nuvoton NPCM750 BMC based on the Cortex A9.</div><div style="text-align:left">+</div>
<span class="gmail-"><div style="text-align:left">+endif</div><div style="text-align:left">diff --git a/arch/arm/mach-npcm/Makefile b/arch/arm/mach-npcm/Makefile</div>
</span><div style="text-align:left">new file mode 100644</div><div style="text-align:left">index 000000000000..78416055b854</div>
<span class="gmail-"><div style="text-align:left">--- /dev/null</div><div style="text-align:left">+++ b/arch/arm/mach-npcm/Makefile</div><div style="text-align:left">@@ -0,0 +1,3 @@</div>
</span><div style="text-align:left">+AFLAGS_headsmp.o += -march=armv7-a</div><div style="text-align:left">+</div><div style="text-align:left">+obj-$(CONFIG_CPU_NPCM750) += npcm7xx.o platsmp.o headsmp.o</div>
<span class="gmail-"><div style="text-align:left">diff --git a/arch/arm/mach-npcm/headsmp.S b/arch/arm/mach-npcm/headsmp.S</div><div style="text-align:left">new file mode 100644</div>
</span><div style="text-align:left">index 000000000000..9fccbbd49ed4</div><div style="text-align:left">--- /dev/null</div><div style="text-align:left">+++ b/arch/arm/mach-npcm/headsmp.S</div><div style="text-align:left">@@ -0,0 +1,17 @@</div><div style="text-align:left">+/*</div>
<span class="gmail-"><div style="text-align:left">+ * Copyright 2017 Google, Inc.</div><div style="text-align:left">+ *</div><div style="text-align:left">+ * This program is free software; you can redistribute it and/or modify</div>
</span><span class="gmail-"><div style="text-align:left">+ * it under the terms of the GNU General Public License version 2 as</div><div style="text-align:left">+ * published by the Free Software Foundation.</div><div style="text-align:left">+ */</div><div style="text-align:left">+</div><div style="text-align:left">+#include <linux/linkage.h></div><div style="text-align:left">+#include <linux/init.h></div>
</span><div style="text-align:left">+#include <asm/assembler.h></div><div style="text-align:left">+</div><div style="text-align:left">+ENTRY(npcm7xx_secondary_<wbr>startup)</div><div style="text-align:left">+ safe_svcmode_maskall r0</div></blockquote><div><br></div><div>I saw you answered to Florian Fainelli that the BootRom is not starting the secondary CPU in SVC mode. Are you sure? In our engineering npcm7xx revision, Z1, the BootRom indeed started to run it in IRQ mode but we fixed it in the production version, A1, (quite long time ago), I hope you didn't get an EB with Z1 you can check that in BootBlock console print:</div><div><div>> ADC CLK is set to 25000000</div><div>>Last reset was CORST</div><div>>vgaioen=1 and mux gspi.</div><div>>A1 <<====== this is what you should see, if you see Z1 we need to replace your EB</div></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="text-align:left">+</div><div style="text-align:left">+ b secondary_startup</div><div style="text-align:left">+ENDPROC(npcm7xx_secondary_<wbr>startup)</div>
<span class="gmail-"><div style="text-align:left">diff --git a/arch/arm/mach-npcm/npcm7xx.c b/arch/arm/mach-npcm/npcm7xx.c</div><div style="text-align:left">new file mode 100644</div>
</span><div style="text-align:left">index 000000000000..132e9d587857</div>
<span class="gmail-"><div style="text-align:left">--- /dev/null</div><div style="text-align:left">+++ b/arch/arm/mach-npcm/npcm7xx.c</div><div style="text-align:left">@@ -0,0 +1,34 @@</div><div style="text-align:left">+/*</div>
</span><div style="text-align:left">+ * Copyright (c) 2017 Nuvoton Technology corporation.</div>
<span class="gmail-"><div style="text-align:left">+ * Copyright 2017 Google, Inc.</div><div style="text-align:left">+ *</div><div style="text-align:left">+ * This program is free software; you can redistribute it and/or modify</div>
</span><span class="gmail-"><div style="text-align:left">+ * it under the terms of the GNU General Public License version 2 as</div><div style="text-align:left">+ * published by the Free Software Foundation.</div><div style="text-align:left">+ */</div><div style="text-align:left">+</div>
</span><div><div class="gmail-h5"><div style="text-align:left">+#include <linux/kernel.h></div><div style="text-align:left">+#include <linux/types.h></div><div style="text-align:left">+#include <asm/mach/arch.h></div><div style="text-align:left">+#include <asm/mach-types.h></div><div style="text-align:left">+#include <asm/mach/map.h></div><div style="text-align:left">+#include <asm/hardware/cache-l2x0.h></div><div style="text-align:left">+</div><div style="text-align:left">+#define NPCM7XX_AUX_VAL (L310_AUX_CTRL_INSTR_PREFETCH | \</div><div style="text-align:left">+ L310_AUX_CTRL_DATA_PREFETCH | \</div><div style="text-align:left">+ L310_AUX_CTRL_NS_LOCKDOWN | \</div><div style="text-align:left">+ L310_AUX_CTRL_CACHE_REPLACE_RR | \</div><div style="text-align:left">+ L2C_AUX_CTRL_SHARED_OVERRIDE | \</div><div style="text-align:left">+ L310_AUX_CTRL_FULL_LINE_ZERO)</div><div style="text-align:left">+</div><div style="text-align:left">+static const char *const npcm7xx_dt_match[] = {</div><div style="text-align:left">+ "nuvoton,npcm750",</div><div style="text-align:left">+ NULL</div><div style="text-align:left">+};</div><div style="text-align:left">+</div><div style="text-align:left">+DT_MACHINE_START(NPCM7XX_DT, "NPCMX50 Chip family")</div><div style="text-align:left">+ .atag_offset = 0x100,</div><div style="text-align:left">+ .dt_compat = npcm7xx_dt_match,</div><div style="text-align:left">+ .l2c_aux_val = NPCM7XX_AUX_VAL,</div><div style="text-align:left">+ .l2c_aux_mask = ~NPCM7XX_AUX_VAL,</div><div style="text-align:left">+MACHINE_END</div><div style="text-align:left">diff --git a/arch/arm/mach-npcm/platsmp.c b/arch/arm/mach-npcm/platsmp.c</div><div style="text-align:left">new file mode 100644</div>
</div></div><div style="text-align:left">index 000000000000..144e3e7ec7e6</div><div style="text-align:left">--- /dev/null</div><div style="text-align:left">+++ b/arch/arm/mach-npcm/platsmp.c</div><div style="text-align:left">@@ -0,0 +1,89 @@</div><div style="text-align:left">+/*</div>
<span class="gmail-"><div style="text-align:left">+ * Copyright 2017 Google, Inc.</div><div style="text-align:left">+ *</div><div style="text-align:left">+ * This program is free software; you can redistribute it and/or modify</div>
</span><span class="gmail-"><div style="text-align:left">+ * it under the terms of the GNU General Public License version 2 as</div><div style="text-align:left">+ * published by the Free Software Foundation.</div><div style="text-align:left">+ */</div><div style="text-align:left">+</div><div style="text-align:left">+#define pr_fmt(fmt) "PLATSMP: " fmt</div><div style="text-align:left">+</div><div style="text-align:left">+#include <linux/delay.h></div><div style="text-align:left">+#include <linux/device.h></div><div style="text-align:left">+#include <linux/smp.h></div><div style="text-align:left">+#include <linux/io.h></div><div style="text-align:left">+#include <linux/of.h></div><div style="text-align:left">+#include <linux/of_device.h></div><div style="text-align:left">+#include <linux/of_platform.h></div><div style="text-align:left">+#include <linux/of_address.h></div><div style="text-align:left">+#include <asm/cacheflush.h></div><div style="text-align:left">+#include <asm/smp.h></div><div style="text-align:left">+#include <asm/smp_plat.h></div><div style="text-align:left">+#include <asm/smp_scu.h></div><div style="text-align:left">+</div><div style="text-align:left">+#define NPCM7XX_SCRPAD_REG 0x13c</div><div style="text-align:left">+</div>
</span><div style="text-align:left">+extern void npcm7xx_secondary_startup(<wbr>void);</div>
<span class="gmail-"><div style="text-align:left">+</div><div style="text-align:left">+static int npcm7xx_smp_boot_secondary(<wbr>unsigned int cpu,</div>
</span><div style="text-align:left">+ struct task_struct *idle)</div><div style="text-align:left">+{</div><div style="text-align:left">+ struct device_node *gcr_np;</div><div style="text-align:left">+ void __iomem *gcr_base;</div><div style="text-align:left">+ int ret = 0;</div>
<span class="gmail-"><div style="text-align:left">+</div><div style="text-align:left">+ gcr_np = of_find_compatible_node(NULL, NULL, "nuvoton,npcm750-gcr");</div><div style="text-align:left">+ if (!gcr_np) {</div><div style="text-align:left">+ pr_err("no gcr device node\n");</div>
</span><div style="text-align:left">+ ret = -EFAULT;</div><div style="text-align:left">+ goto out;</div>
<span class="gmail-"><div style="text-align:left">+ }</div><div style="text-align:left">+ gcr_base = of_iomap(gcr_np, 0);</div><div style="text-align:left">+ if (!gcr_base) {</div><div style="text-align:left">+ pr_err("could not iomap gcr at: 0x%llx\n", gcr_base);</div>
</span><div style="text-align:left">+ ret = -EFAULT;</div><div style="text-align:left">+ goto out;</div><div style="text-align:left">+ }</div><div style="text-align:left">+</div><div style="text-align:left">+ /* give boot ROM kernel start address. */</div><div style="text-align:left">+ iowrite32(__pa_symbol(npcm7xx_<wbr>secondary_startup), gcr_base +</div><div style="text-align:left">+ NPCM7XX_SCRPAD_REG);</div>
<span class="gmail-"><div style="text-align:left">+ /* make sure npcm7xx_secondary_startup is seen by all observers. */</div><div style="text-align:left">+ smp_wmb();</div><div style="text-align:left">+ dsb_sev();</div><div style="text-align:left">+ /* make sure write buffer is drained */</div><div style="text-align:left">+ mb();</div><div style="text-align:left">+</div>
</span><div style="text-align:left">+out:</div><div style="text-align:left">+ iounmap(gcr_base);</div><div style="text-align:left">+ return ret;</div>
<span class="gmail-"><div style="text-align:left">+}</div><div style="text-align:left">+</div><div style="text-align:left">+static void __init npcm7xx_smp_prepare_cpus(<wbr>unsigned int max_cpus)</div><div style="text-align:left">+{</div>
</span><div style="text-align:left">+ struct device_node *scu_np;</div><div style="text-align:left">+ void __iomem *scu_base;</div>
<span class="gmail-"><div style="text-align:left">+</div><div style="text-align:left">+ scu_np = of_find_compatible_node(NULL, NULL, "arm,cortex-a9-scu");</div><div style="text-align:left">+ if (!scu_np) {</div><div style="text-align:left">+ pr_err("no scu device node\n");</div><div style="text-align:left">+ return;</div><div style="text-align:left">+ }</div><div style="text-align:left">+ scu_base = of_iomap(scu_np, 0);</div><div style="text-align:left">+ if (!scu_base) {</div>
</span><div style="text-align:left">+ pr_err("could not iomap scu at: 0x%llx\n", scu_base);</div>
<span class="gmail-"><div style="text-align:left">+ return;</div><div style="text-align:left">+ }</div><div style="text-align:left">+</div><div style="text-align:left">+ scu_enable(scu_base);</div><div style="text-align:left">+</div>
</span><div style="text-align:left">+out:</div><div style="text-align:left">+ iounmap(scu_base);</div>
<span class="gmail-im gmail-HOEnZb"><div style="text-align:left">+}</div><div style="text-align:left">+</div><div style="text-align:left">+static struct smp_operations npcm7xx_smp_ops __initdata = {</div><div style="text-align:left">+ .smp_prepare_cpus = npcm7xx_smp_prepare_cpus,</div><div style="text-align:left">+ .smp_boot_secondary = npcm7xx_smp_boot_secondary,</div>
</span><div class="gmail-HOEnZb"><div class="gmail-h5"><div style="text-align:left">+};</div><div style="text-align:left">+</div><div style="text-align:left">+CPU_METHOD_OF_DECLARE(<wbr>npcm7xx_smp, "nuvoton,npcm7xx-smp", &npcm7xx_smp_ops);</div><div style="text-align:left">--</div><div style="text-align:left">2.14.1.581.gf28d330327-goog</div>
<div style="text-align:left"><br></div>
</div></div></blockquote></div><div style="text-align:left"><br></div></div></div>