<div dir="auto"><div><br><div class="gmail_extra"><br><div class="gmail_quote">On 4 Jul. 2017 19:43, "Andrew Jeffery" <<a href="mailto:andrew@aj.id.au">andrew@aj.id.au</a>> wrote:<br type="attribution"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="quoted-text">On Tue, 2017-07-04 at 15:35 +0930, Joel Stanley wrote:<br>
> From the timeriomem_rng bindings:<br>
><br>
>  quality: estimated number of bits of true entropy per 1024 bits read<br>
>  from the rng.  Defaults to zero which causes the kernel's default<br>
>  quality to be used instead.  Note that the default quality is usually<br>
>  zero which disables using this rng to automatically fill the kernel's<br>
>  entropy pool.<br>
<br>
</div>This does not appear in the 4.12 kernel's bindings at<br>
Documentation/devicetree/<wbr>bindings/rng/timeriomem_rng.<wbr>txt, and doesn't<br>
appear in Ted T'so's dev branch[1].<br>
<br>
Where did you find this binding description?<br></blockquote></div></div></div><div dir="auto"><br></div><div dir="auto">Herbet's tree. They will be in 4.13.</div><div dir="auto"><br></div><div dir="auto">Cheers,</div><div dir="auto"><br></div><div dir="auto">Joel</div><div dir="auto"><br></div><div dir="auto"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Andrew<br>
<br>
[1] <a href="https://git.kernel.org/pub/scm/linux/kernel/git/tytso/random.git/tree/Documentation/devicetree/bindings/rng/timeriomem_rng.txt?h=dev" rel="noreferrer" target="_blank">https://git.kernel.org/pub/<wbr>scm/linux/kernel/git/tytso/<wbr>random.git/tree/Documentation/<wbr>devicetree/bindings/rng/<wbr>timeriomem_rng.txt?h=dev</a><br>
<div class="elided-text"><br>
><br>
> As to the recommended value for us to use:<br>
><br>
> > Rick Altherr <<a href="mailto:raltherr@google.com">raltherr@google.com</a>> wrote:<br>
> > Quality is #bit of entropy per 1000 bits read.  100 is a<br>
> > conservative value that was suggested by those in the know.<br>
><br>
> Signed-off-by: Joel Stanley <<a href="mailto:joel@jms.id.au">joel@jms.id.au</a>><br>
> ---<br>
>  arch/arm/boot/dts/aspeed-g4.<wbr>dtsi | 1 +<br>
>  arch/arm/boot/dts/aspeed-g5.<wbr>dtsi | 1 +<br>
>  2 files changed, 2 insertions(+)<br>
><br>
> diff --git a/arch/arm/boot/dts/aspeed-g4.<wbr>dtsi b/arch/arm/boot/dts/aspeed-g4.<wbr>dtsi<br>
> index 9cc959fccfa0..470a6335399a 100644<br>
> --- a/arch/arm/boot/dts/aspeed-g4.<wbr>dtsi<br>
> +++ b/arch/arm/boot/dts/aspeed-g4.<wbr>dtsi<br>
> @@ -193,6 +193,7 @@<br>
> >                                     compatible = "timeriomem_rng";<br>
> >                                     reg = <0x1e6e2078 0x4>;<br>
> >                                     period = <1>;<br>
> > +                                   quality = <100>;<br>
> >                             };<br>
>  <br>
> > >                           pinctrl: pinctrl@1e6e2000 {<br>
> diff --git a/arch/arm/boot/dts/aspeed-g5.<wbr>dtsi b/arch/arm/boot/dts/aspeed-g5.<wbr>dtsi<br>
> index 992242d3b22e..466b322951e1 100644<br>
> --- a/arch/arm/boot/dts/aspeed-g5.<wbr>dtsi<br>
> +++ b/arch/arm/boot/dts/aspeed-g5.<wbr>dtsi<br>
> @@ -232,6 +232,7 @@<br>
> >                             compatible = "timeriomem_rng";<br>
> >                             reg = <0x1e6e2078 0x4>;<br>
> >                             period = <1>;<br>
> > +                           quality = <100>;<br>
> >                     };<br>
>  <br>
> > >                   gfx: display@1e6e6000 {</div></blockquote></div><br></div></div></div>