<font face="Default Sans Serif,Verdana,Arial,Helvetica,sans-serif" size="2"><br>On 05/24/2017 at 03:33PM in some timezone,  Eddie James wrote:<br>><br>>Prevented BMC from booting on Barreleye in 4.10 kernel, with new<br>>aspeed-smc driver.<br>><br>>Signed-off-by: Edward A. James <<a href="mailto:eajames@us.ibm.com" target="_blank">eajames@us.ibm.com</a>><br>>---<br>> arch/arm/boot/dts/aspeed-bmc-opp-barreleye.dts | 7 +++++++<br>> 1 file changed, 7 insertions(+)<br>><br>>diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-barreleye.dts<br>>b/arch/arm/boot/dts/aspeed-bmc-opp-barreleye.dts<br>>index be1f2d1..9b59587 100644<br>>--- a/arch/arm/boot/dts/aspeed-bmc-opp-barreleye.dts<br>>+++ b/arch/arm/boot/dts/aspeed-bmc-opp-barreleye.dts<br>>@@ -37,10 +37,14 @@<br>>                                 0x20000000 0x02000000 >;<br>>                         #address-cells = <1>;<br>>                         #size-cells = <0>;<br>>+                        interrupts = <19>;<br>>                         compatible = "aspeed,ast2400-fmc";<br>>+                        clocks = <&clk_ahb>;<br>>+                        clock-names = "ahb";<br>>                         flash@0 {<br>>                                 reg = < 0 >;<br>>                                 compatible = "jedec,spi-nor" ;<br>>+                                m25p,fast-read;<br>> #include "aspeed-bmc-opp-flash-layout.dtsi"<br>>                         };<br><br>Since the clocks and interrupts are all inside the SOC they should be part of the aspeed-g4 dtsi.<br><br>It looks like this was factored better on the g5 vs the g4 dtsi.<br><br>>                 };<br>>@@ -51,10 +55,13 @@<br>>                         #address-cells = <1>;<br>>                         #size-cells = <0>;<br>>                         compatible = "aspeed,ast2400-spi";<br>>+                        clocks = <&clk_ahb>;<br>>+                        clock-names = "ahb";<br>>                         flash@0 {<br>>                                 reg = < 0 >;<br>>                                 compatible = "jedec,spi-nor" ;<br>>                                 label = "pnor";<br>>+                                m25p,fast-read;<br><br><br>milton<br></font><BR>