<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On May 16, 2017, at 1:01 AM, Cédric Le Goater <<a href="mailto:clg@kaod.org" class="">clg@kaod.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><span style="font-family: ArialUnicodeMS; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">On 05/15/2017 02:41 AM, Adriana Kobylak wrote:</span><br style="font-family: ArialUnicodeMS; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><blockquote type="cite" style="font-family: ArialUnicodeMS; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class=""><br class=""><blockquote type="cite" class="">On May 13, 2017, at 3:49 PM, Cédric Le Goater <<a href="mailto:clg@kaod.org" class="">clg@kaod.org</a>> wrote:<br class=""><br class="">On 05/11/2017 02:12 PM, Joel Stanley wrote:<br class=""><blockquote type="cite" class="">On Thu, May 11, 2017 at 7:31 AM, Adriana Kobylak<br class=""><<a href="mailto:anoo@linux.vnet.ibm.com" class="">anoo@linux.vnet.ibm.com</a>> wrote:<br class=""><blockquote type="cite" class="">Milton stopped by and mentioned that you had tried to modify the 4K erase<br class="">sector previously for a perhaps bmc chip and saw some flash corruption when<br class="">moving to an image that changed it?<br class=""><br class="">Just wanted to add that this change only changes the pnor setting and I<br class="">didn’t see any issues powering on a system after updating the BMC with an<br class="">image with this change. Then I updated the pnor with an image that had the<br class="">mbox enabled. Also checked with AndrewJ and the hostboot team and there’s no<br class="">hard-coded assumptions in their side about the erase size.<br class=""><br class="">With all this info let me know if you have any thoughts or concerns.<br class=""></blockquote><br class="">I recall issues relating to this option. I didn't record what they were<span class="Apple-converted-space"> </span><br class="">though.<br class=""></blockquote><br class="">We tried to activate 4K erase on some chips, which supported it,<span class="Apple-converted-space"> </span><br class="">and that the OpenPOWER systems use. That was because the PNOR<span class="Apple-converted-space"> </span><br class="">sections were not aligned with the erase size and that caused<span class="Apple-converted-space"> </span><br class="">some issues in pflash. But it breaks the compatibility with<span class="Apple-converted-space"> </span><br class="">previously created jffs2 filesystems. jffs2 stores the erase<span class="Apple-converted-space"> </span><br class="">size. So we stepped back.<br class=""><br class=""><blockquote type="cite" class="">Cedric, can you remind me what the issues are with the 4K kconfig option?<br class=""></blockquote><br class="">CONFIG_MTD_SPI_NOR_USE_4K_SECTORS enables the 4K erase commands,<span class="Apple-converted-space"> </span><br class="">and without it, the driver will use the sector erase command, most<br class="">likely 64K. I suppose we could have the same problem as described<span class="Apple-converted-space"> </span><br class="">above, as it can change the default erase size of a chip. to be<br class="">checked.<br class=""><br class=""></blockquote>Thanks Cedric for the info. It appears there are no issues when<span class="Apple-converted-space"> </span><br class="">disabling the 4K sectors for the pnor chip (yes, the erase size<span class="Apple-converted-space"> </span><br class="">is then 64K), probably because the pnor is not formatted with<span class="Apple-converted-space"> </span><br class="">a jffs2 filesystem. We might need to clear the pnor chip anyways<br class="">to be able to format it as a UBI volume. So would you say we’re<span class="Apple-converted-space"> </span><br class="">ok with this patch?<br class=""></blockquote><br style="font-family: ArialUnicodeMS; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: ArialUnicodeMS; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Well, what if the BMC is using a flash module with a 4K erase size ?<span class="Apple-converted-space"> </span></span><br style="font-family: ArialUnicodeMS; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""></div></blockquote><div><br class=""></div>All the mtd devices except PNOR in the P8 and P9 systems running openbmc have already an erase size of 64K.</div><div><br class=""></div><div>Ex witherspoon:</div><div><div><font face="Courier" class="">root@witherspoon:~# cat /proc/mtd </font></div><div><font face="Courier" class="">dev: size erasesize name</font></div><div><font face="Courier" class="">mtd0: 02000000 00010000 "bmc"</font></div><div><font face="Courier" class="">mtd1: 00060000 00010000 "u-boot"</font></div><div><font face="Courier" class="">mtd2: 00020000 00010000 "u-boot-env"</font></div><div><font face="Courier" class="">mtd3: 00440000 00010000 "kernel"</font></div><div><font face="Courier" class="">mtd4: 01740000 00010000 "rofs"</font></div><div><font face="Courier" class="">mtd5: 00400000 00010000 "rwfs"</font></div><div><font face="Courier" class="">mtd6: 02000000 00010000 "alt"</font></div><div><font face="Courier" class="">mtd7: 08000000 00001000 “pnor”</font></div><div><font face="Courier" class=""><br class=""></font></div><div>Ex barreleye:</div><div><font face="Courier" class=""><div>root@barreleye:~# cat /proc/mtd </div><div>dev: size erasesize name</div><div>mtd0: 02000000 00010000 "bmc"</div><div>mtd1: 00060000 00010000 "u-boot"</div><div>mtd2: 00020000 00010000 "u-boot-env"</div><div>mtd3: 00440000 00010000 "kernel"</div><div>mtd4: 01740000 00010000 "rofs"</div><div>mtd5: 00400000 00010000 "rwfs"</div><div>mtd6: 04000000 00001000 "pnor"</div></font></div><div><br class=""></div><blockquote type="cite" class=""><div class=""><br style="font-family: ArialUnicodeMS; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: ArialUnicodeMS; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">C.</span></div></blockquote></div><br class=""></body></html>