<div dir="auto">Sounds good to me.</div><div class="gmail_extra"><br><div class="gmail_quote">On Feb 16, 2017 7:41 PM, "Joel Stanley" <<a href="mailto:joel@jms.id.au">joel@jms.id.au</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Fri, Feb 17, 2017 at 2:03 PM, Rick Altherr <<a href="mailto:raltherr@google.com">raltherr@google.com</a>> wrote:<br>
> Current Zaius and Barreleye G2 boards have AST2500 which has VGA support.<br>
> Google hasn't tried the VGA but it is there. We plan to switch to 2520 later<br>
> for our own designs but it's only a BOM option to switch between the two.<br>
<br>
I think detecting the board revision GPIOs in u-boot and performing a<br>
fixup of the device tree is a good way to handle these kind of things.<br>
<br>
Perhaps we will end up having different device trees if the systems<br>
end up with vastly different configurations, or configs that aren't<br>
detectable from software.<br>
<br>
<br>
><br>
> On Feb 16, 2017 7:15 PM, "Cyril Bur" <<a href="mailto:cyrilbur@gmail.com">cyrilbur@gmail.com</a>> wrote:<br>
><br>
> Zaius platform doesn't use VGA so don't reserve that memory<br>
><br>
> Signed-off-by: Cyril Bur <<a href="mailto:cyrilbur@gmail.com">cyrilbur@gmail.com</a>><br>
> ---<br>
> v2: Drop reserving the framebuffer on Zaius<br>
>     Both platforms have 1GB not 512MB - adjust numbers<br>
>     Add comment requested by Joel.<br>
><br>
>  arch/arm/boot/dts/aspeed-bmc-<wbr>opp-witherspoon.dts | 15 +++++++++++++--<br>
>  arch/arm/boot/dts/aspeed-bmc-<wbr>opp-zaius.dts       | 12 ++++++++++--<br>
>  2 files changed, 23 insertions(+), 4 deletions(-)<br>
><br>
> diff --git a/arch/arm/boot/dts/aspeed-<wbr>bmc-opp-witherspoon.dts<br>
> b/arch/arm/boot/dts/aspeed-<wbr>bmc-opp-witherspoon.dts<br>
> index 4b2d8aa8abb6..b79cadb2f6d7 100644<br>
> --- a/arch/arm/boot/dts/aspeed-<wbr>bmc-opp-witherspoon.dts<br>
> +++ b/arch/arm/boot/dts/aspeed-<wbr>bmc-opp-witherspoon.dts<br>
> @@ -25,9 +25,20 @@<br>
>                 #size-cells = <1>;<br>
>                 ranges;<br>
><br>
> -               flash_memory: region@94000000 {<br>
> +               /*<br>
> +                * The addreses for the flash_memory reserved range are the<br>
> +                * highest allowable for the size of the mapping (ie, the<br>
> +                * address has no set bits greater than the size)<br>
> +                */<br>
> +<br>
> +               flash_memory: region@b8000000 {<br>
> +                       no-map;<br>
> +                       reg = <0xb8000000 0x04000000>; /* 64M */<br>
> +               };<br>
> +<br>
> +               vga_memory: framebuffer@bc000000 {<br>
>                         no-map;<br>
> -                       reg = <0x94000000 0x04000000>; /* 64M */<br>
> +                       reg = <0xbc000000 0x04000000>; /* 64M */<br>
>                 };<br>
>         };<br>
><br>
> diff --git a/arch/arm/boot/dts/aspeed-<wbr>bmc-opp-zaius.dts<br>
> b/arch/arm/boot/dts/aspeed-<wbr>bmc-opp-zaius.dts<br>
> index e1c9b3f4fe44..5a06da43801b 100644<br>
> --- a/arch/arm/boot/dts/aspeed-<wbr>bmc-opp-zaius.dts<br>
> +++ b/arch/arm/boot/dts/aspeed-<wbr>bmc-opp-zaius.dts<br>
> @@ -25,10 +25,18 @@<br>
>                 #size-cells = <1>;<br>
>                 ranges;<br>
><br>
> -               flash_memory: region@94000000 {<br>
> +               /*<br>
> +                * The addreses for the flash_memory reserved range are the<br>
> +                * highest allowable for the size of the mapping (ie, the<br>
> +                * address has no set bits greater than the size)<br>
> +                */<br>
> +<br>
> +               flash_memory: region@bc000000 {<br>
>                         no-map;<br>
> -                       reg = <0x94000000 0x04000000>; /* 64M */<br>
> +                       reg = <0xbc000000 0x04000000>; /* 64M */<br>
>                 };<br>
> +<br>
> +               /* Zaius doesn't use VGA so don't reserve VGA buffer */<br>
>         };<br>
><br>
>         onewire0 {<br>
> --<br>
> 2.11.1<br>
><br>
><br>
</blockquote></div></div>