<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
On 01/18/2017 08:14 PM, Patrick Williams wrote:<br>
<blockquote cite="mid:20170118144408.GA5120@heinlein.lan"
type="cite">
<pre wrap="">On Tue, Jan 17, 2017 at 03:51:39PM +0800, Mine wrote:
</pre>
<blockquote type="cite">
<pre wrap="">On Tue, Jan 17, 2017 at 3:44 AM, Patrick Williams <a class="moz-txt-link-rfc2396E" href="mailto:patrick@stwcx.xyz"><patrick@stwcx.xyz></a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">On Fri, Jan 13, 2017 at 03:42:50PM +0800, Mine wrote:
</pre>
</blockquote>
</blockquote>
<pre wrap="">
</pre>
<blockquote type="cite">
<pre wrap="">I should be meant to create two "instances" on the bus, eventually it looks
something like:
```
xyz.openbmc_project.Time.Manager
/xyz/openbmc_project/time/host_epoch
org.freedesktop.DBus.Peer
org.freedesktop.DBus.Introspectable
org.freedesktop.DBus.Properties
xyz.openbmc_project.Time.EpochTime
/xyz/openbmc_project/time/bmc_epoch
org.freedesktop.DBus.Peer
org.freedesktop.DBus.Introspectable
org.freedesktop.DBus.Properties
xyz.openbmc_project.Time.EpochTime
</pre>
</blockquote>
<pre wrap="">
There isn't a reason to name the object path "epoch". /time/bmc and
/time/host0 is probably more appropriate.
</pre>
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">And there will be no “curr_time_mode/owner” or “requested_time_mode/owner”
properties on DBUS.
</pre>
</blockquote>
<pre wrap="">
So these are only stored in phosphor-settingsd now or are they also used
internally for decisions? I believe the previous implementation had
them exposed more for debug purposes. Are you going to add them to the
journal at least?
</pre>
</blockquote>
<pre wrap="">
Yes, the time_mode and time_owner are still stored in
phosphor-settingsd, and they
are used internally by phosphor-time-manager, which will register
callback for the
settings' change and handled accordingly.
The difference from the previous implementation is that we do not expose these
settings in time-manager's DBus now.
</pre>
</blockquote>
<pre wrap="">
There are two aspects for consideration here:
1. The current time manager defers changing the host policies until
the next boot. We need to continue this behavior.</pre>
</blockquote>
There was a concern from test team on 'why do we need to defer
applying any settings that are used by time manager'.<br>
<br>
I thought and partially agree to their concern. For changing the
owner *away from SPLIT*, we can actually consume that readily. Its
only the change * TO SPLIT* that needs to delayed until off.<br>
<br>
Also, the time_mode changes can be applied readily ( although time
manager may not like HOST and NTP and in that case, its in pending
state anyway ).<br>
<br>
<br>
<blockquote cite="mid:20170118144408.GA5120@heinlein.lan"
type="cite">
<pre wrap="">
2. If the process restarts we need it to go back into the "current
state" and not the "requested state". How do we make this
happen? The current implementation might also have a flaw here
so maybe we log it as an issue for follow up.</pre>
</blockquote>
<br>
<br>
The current implementation only sets the values based on what was
set prior to reset.<br>
It does that by consuming the saved data in /var/lib/obmc/saved_*.
So there is not an issue there.<br>
<br>
<br>
<blockquote cite="mid:20170118144408.GA5120@heinlein.lan"
type="cite">
<pre wrap="">
</pre>
<blockquote type="cite">
<pre wrap="">What do you mean by "add them to the journal"?
</pre>
</blockquote>
<pre wrap="">
Use phosphor-logging.
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
openbmc mailing list
<a class="moz-txt-link-abbreviated" href="mailto:openbmc@lists.ozlabs.org">openbmc@lists.ozlabs.org</a>
<a class="moz-txt-link-freetext" href="https://lists.ozlabs.org/listinfo/openbmc">https://lists.ozlabs.org/listinfo/openbmc</a>
</pre>
</blockquote>
<br>
</body>
</html>