<div dir="ltr">Hi Jagha,<br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Oct 12, 2016 at 5:41 PM, Jaghathiswari Rankappagounder Natarajan <span dir="ltr"><<a href="mailto:jaghu@google.com" target="_blank">jaghu@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Add clock, data and clear signal lines to control POST card display on zaius<br>
<br>
Signed-off-by: Jaghathiswari Rankappagounder Natarajan <<a href="mailto:jaghu@google.com">jaghu@google.com</a>><br>
---<br>
 .../devicetree/bindings/misc/<wbr>postcard-disp.txt         | 18 ++++++++++++++++++<br>
 arch/arm/boot/dts/aspeed-bmc-<wbr>opp-zaius.dts             |  8 ++++++++<br>
 2 files changed, 26 insertions(+)<br>
 create mode 100644 Documentation/devicetree/<wbr>bindings/misc/postcard-disp.<wbr>txt<br>
<br>
diff --git a/Documentation/devicetree/<wbr>bindings/misc/postcard-disp.<wbr>txt b/Documentation/devicetree/<wbr>bindings/misc/postcard-disp.<wbr>txt<br>
new file mode 100644<br>
index 0000000..164449e<br>
--- /dev/null<br>
+++ b/Documentation/devicetree/<wbr>bindings/misc/postcard-disp.<wbr>txt<br></blockquote><div><br></div><div>This doc file belongs in the same commit as the driver that it describes. The Zaius dts change should stand alone.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
@@ -0,0 +1,18 @@<br>
+POST card display (two seven segment LEDs) connected to GPIO lines<br>
+<br>
+Required properties:<br>
+- compatible : should be "postcard-display".<br>
+- clk-gpios :  Should specify the GPIO pin connected to the Clock line on the POST card.<br></blockquote><div><br></div><div>For consistency and readability, please don't abbreviate these names. We should use "clock-gpios" instead of "clk-gpios."<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
+- data-gpios : Should specify the GPIO pin connected to Data line on the POST card.<br>
+- clear-gpios : Should specify the GPIO pin connected to Clear line on the POST card.<br></blockquote><div><br></div><div>Ex. you wrote "clear-gpios" here but the code uses "clr-gpios," which looks visually similar to "clk-gpios."<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
+<br>
+Examples:<br>
+<br>
+#include <dt-bindings/gpio/gpio.h><br>
+<br>
+postcard {<br>
+       compatible = "postcard-display";<br>
+       clk-gpios = <&gpio 0 GPIO_ACTIVE_LOW>;<br>
+       data-gpios = <&gpio 1 GPIO_ACTIVE_HIGH>;<br>
+       clear-gpios = <&gpio 1 GPIO_ACTIVE_HIGH>;<br></blockquote><div><br></div><div>This uses the same gpio designator (1) as the second -gpios property. I know it's example code but...</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
+};<br>
diff --git a/arch/arm/boot/dts/aspeed-<wbr>bmc-opp-zaius.dts b/arch/arm/boot/dts/aspeed-<wbr>bmc-opp-zaius.dts<br>
index 4c4754b..d555ff1 100644<br>
--- a/arch/arm/boot/dts/aspeed-<wbr>bmc-opp-zaius.dts<br>
+++ b/arch/arm/boot/dts/aspeed-<wbr>bmc-opp-zaius.dts<br>
@@ -1,6 +1,7 @@<br>
 /dts-v1/;<br>
<br>
 #include "aspeed-g5.dtsi"<br>
+#include <dt-bindings/gpio/aspeed-gpio.<wbr>h><br>
<br>
 / {<br>
        model = "Zaius BMC";<br>
@@ -58,6 +59,13 @@<br>
                        };<br>
                };<br>
        };<br>
+<br>
+       postcard {<br>
+               compatible = "postcard-display";<br>
+               clk-gpios = <&gpio ASPEED_GPIO(J, 0) GPIO_ACTIVE_HIGH>;<br>
+               data-gpios = <&gpio ASPEED_GPIO(J, 2) GPIO_ACTIVE_HIGH>;<br>
+               clr-gpios = <&gpio ASPEED_GPIO(J, 1) GPIO_ACTIVE_HIGH>;<br></blockquote><div><br></div><div>This property should match up to the documentation.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
+       };<br>
 };<br>
<br>
 &uart5 {<br>
--<br>
2.8.0.rc3.226.g39d4020<br>
<br>
______________________________<wbr>_________________<br>
openbmc mailing list<br>
<a href="mailto:openbmc@lists.ozlabs.org">openbmc@lists.ozlabs.org</a><br>
<a href="https://lists.ozlabs.org/listinfo/openbmc" rel="noreferrer" target="_blank">https://lists.ozlabs.org/<wbr>listinfo/openbmc</a><br>
</blockquote></div><br></div><div class="gmail_extra">cheers</div><div class="gmail_extra">xo</div><div class="gmail_extra"><br></div></div>