<div dir="ltr">I'm willing to help with reviews in any of those groups. I've had a career that's plunged me into all of those languages quite deeply.</div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jun 28, 2016 at 9:39 AM, Patrick Williams <span dir="ltr"><<a href="mailto:patrick@stwcx.xyz" target="_blank">patrick@stwcx.xyz</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Joel,<br>
<br>
Both of these questions make me realize we should add the "answers" to<br>
the documentation. I'll get it added after Adriana's initial Gerrit<br>
documentation is in.<br>
<span class=""><br>
On Tue, Jun 28, 2016 at 01:22:57PM +0930, Joel Stanley wrote:<br>
> How do we get notifications when a patch is proposed for review?<br>
<br>
</span>The overall documentation for it can be found here:<br>
<a href="https://gerrit-review.googlesource.com/Documentation/user-notify.html#user" rel="noreferrer" target="_blank">https://gerrit-review.googlesource.com/Documentation/user-notify.html#user</a><br>
<br>
Also, you can view the documentation directly on our Gerrit server:<br>
<a href="https://gerrit.openbmc-project.xyz/Documentation/user-notify.html#user" rel="noreferrer" target="_blank">https://gerrit.openbmc-project.xyz/Documentation/user-notify.html#user</a><br>
<br>
The net is that you probably want to go to "Settings > Watched Projects"<br>
and add All-Projects to your subscription. You can otherwise subscribe<br>
to individual repositories.<br>
<br>
Direct link:<br>
<a href="https://gerrit.openbmc-project.xyz/#/settings/projects" rel="noreferrer" target="_blank">https://gerrit.openbmc-project.xyz/#/settings/projects</a><br>
<span class=""><br>
> Do we have owners of each component that must review before a patch<br>
> can be merged?<br>
<br>
</span>Yes. We should document the code-review process now that we can have<br>
one.<br>
<br>
Here are the current settings and what has worked well for us in the<br>
past with Gerrit. Open to suggestions.<br>
<br>
1. All users are able to +1 / -1 code.<br>
2. A set of "maintainers" are able to +2 / -2 and submit code.<br>
3. All commits should have (at least) two +1 reviews.<br>
3a. Ideally the maintainer is not one of the +1.<br>
4. Commits should not be merged with a -1 (or -2) unless there has<br>
been a discussion by the maintainer to justify the merge.<br>
5. The maintainer should ensure that all past -1 review comments<br>
have been addressed in a follow-up patch set. This is usually<br>
handled by having the original -1 reviewer now give a +1.<br>
<br>
What I did initially was divide the repositories up based on their<br>
primary language and assign a maintainer group in Github. Maybe I<br>
should make these groups public?<br>
<br>
a. Bitbake recipes.<br>
* Brad Bishop, Patrick Williams<br>
b. Python repositories.<br>
* Brad Bishop, Patrick Williams<br>
c. C repositories.<br>
* Joel Stanley, Jeremy Kerr<br>
d. C++ repositories.<br>
* Patrick Williams<br>
<br>
Over time I expect the repositories to be grouped more along functional<br>
lines and subsystem-style maintainers to come about based on their<br>
contributions. (I know next to nothing about Python, so I'd be<br>
especially willing to add someone else in my place there to work with<br>
Brad.)<br>
<br>
You can see the current "maintainer group" assigned to a repository by<br>
going to "Projects > List > (select repo) > Access" and seeing the<br>
"Rights Inherit From" line. By direct link, you can see 'obmc-console'<br>
is maintained by the 'openbmc-c-repos' group:<br>
<a href="https://gerrit.openbmc-project.xyz/#/admin/projects/openbmc/obmc-console,access" rel="noreferrer" target="_blank">https://gerrit.openbmc-project.xyz/#/admin/projects/openbmc/obmc-console,access</a><br>
<br>
That 'openbmc-c-repos' group corresponds to the 'openbmc/c-maintainers' group<br>
on Github as evidenced by this:<br>
<a href="https://gerrit.openbmc-project.xyz/#/admin/projects/openbmc-c-repos,access" rel="noreferrer" target="_blank">https://gerrit.openbmc-project.xyz/#/admin/projects/openbmc-c-repos,access</a><br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
Patrick Williams<br>
</font></span><br>_______________________________________________<br>
openbmc mailing list<br>
<a href="mailto:openbmc@lists.ozlabs.org">openbmc@lists.ozlabs.org</a><br>
<a href="https://lists.ozlabs.org/listinfo/openbmc" rel="noreferrer" target="_blank">https://lists.ozlabs.org/listinfo/openbmc</a><br>
<br></blockquote></div><br></div>