<font size=2 face="sans-serif">Hi Vishwanatha,</font><br><br><font size=2 face="sans-serif">Its PR:</font><br><a href="https://github.com/openbmc/phosphor-host-ipmid/pull/88"><font size=2 color=blue face="sans-serif">https://github.com/openbmc/phosphor-host-ipmid/pull/88</font></a><br><br><font size=3 color=#424282 face="Calibri">Regards,</font><br><br><font size=3 color=#424282 face="Calibri">William Li ( Li Nan, Àîéª
) </font><br><font size=3 color=#424282 face="Calibri"> </font><br><br><font size=3 color=#424282 face="Calibri">Firmware Engineering Professional</font><br><font size=3 color=#424282 face="Calibri">OpenPower AE Team | IBM System
& Technology Lab</font><br><font size=3 color=#424282 face="Calibri">Mobile: +86-186-1081 6605</font><br><br><font size=3 color=#424282 face="Calibri">Beijing, China</font><br><br><br><br><font size=1 color=#5f5f5f face="sans-serif">From:
</font><font size=1 face="sans-serif">Vishwanatha Subbanna/India/IBM</font><br><font size=1 color=#5f5f5f face="sans-serif">To:
</font><font size=1 face="sans-serif">OpenBMC Members</font><br><font size=1 color=#5f5f5f face="sans-serif">Cc:
</font><font size=1 face="sans-serif">openbmc@lists.ozlabs.org,
Nan Li <bjlinan@cn.ibm.com></font><br><font size=1 color=#5f5f5f face="sans-serif">Date:
</font><font size=1 face="sans-serif">05/24/2016 21:02</font><br><font size=1 color=#5f5f5f face="sans-serif">Subject:
</font><font size=1 face="sans-serif">Re: [PATCH phosphor-host-ipmid]
Returning correct value from handle_ipmid_command in ipmid.C</font><br><hr noshade><br><br><font size=2 face="sans-serif">hello Nan Li,</font><br><br><font size=2 face="sans-serif">I wonder if there is a github pull request
for this ?</font><br><font size=2 face="sans-serif"><br>Thanks<br><br>-------------------------------------------------------------------------------------<br>Thanks and Regards,<br>Vishwanath.<br>Advisory Software Engineer,<br>Power Firmware Development, <br>Systems &Technology Lab,<br>MG2-6F-255 , Manyata Embassy Business Park, <br>Bangalore , KA , 560045<br>Ph: +91-80-46678255<br>E-mail: vishwanath@in.ibm.com<br>----------------------------------------------------------------------------------</font><br><br><br><br><br><font size=1 color=#5f5f5f face="sans-serif">From:
</font><font size=1 face="sans-serif">OpenBMC Patches <openbmc-patches@stwcx.xyz></font><br><font size=1 color=#5f5f5f face="sans-serif">To:
</font><font size=1 face="sans-serif">openbmc@lists.ozlabs.org</font><br><font size=1 color=#5f5f5f face="sans-serif">Cc:
</font><font size=1 face="sans-serif">Nan Li <bjlinan@cn.ibm.com></font><br><font size=1 color=#5f5f5f face="sans-serif">Date:
</font><font size=1 face="sans-serif">24/05/2016 02:11 pm</font><br><font size=1 color=#5f5f5f face="sans-serif">Subject:
</font><font size=1 face="sans-serif">[PATCH phosphor-host-ipmid]
Returning correct value from handle_ipmid_command in ipmid.C</font><br><font size=1 color=#5f5f5f face="sans-serif">Sent by:
</font><font size=1 face="sans-serif">"openbmc"
<openbmc-bounces+vishwanath=in.ibm.com@lists.ozlabs.org></font><br><hr noshade><br><br><br><tt><font size=2>From: Nan Li <bjlinan@cn.ibm.com><br><br>Instead of -1, we return 0xFF(Unspecified error) to the bus.<br><br>Signed-off-by: Nan Li <bjlinan@cn.ibm.com><br>---<br> ipmid.C | 4 ++++<br> 1 file changed, 4 insertions(+)<br><br>diff --git a/ipmid.C b/ipmid.C<br>index 728ba0b..9009cd6 100644<br>--- a/ipmid.C<br>+++ b/ipmid.C<br>@@ -267,6 +267,10 @@ static int handle_ipmi_command(sd_bus_message *m,
void *user_data, sd_bus_error<br> if(r != 0)<br> {<br> fprintf(stderr,"ERROR:[0x%X] handling
NetFn:[0x%X], Cmd:[0x%X]\n",r, netfn, cmd);<br>+<br>+ if(r == -1) {<br>+ response[0] = IPMI_CC_UNSPECIFIED_ERROR;<br>+ }<br> }<br> <br> fprintf(ipmiio, "IPMI Response:\n");<br>-- <br>2.8.3<br><br><br>_______________________________________________<br>openbmc mailing list<br>openbmc@lists.ozlabs.org<br></font></tt><a href=https://lists.ozlabs.org/listinfo/openbmc><tt><font size=2>https://lists.ozlabs.org/listinfo/openbmc</font></tt></a><tt><font size=2><br></font></tt><br><br><BR>