<font size=2 face="sans-serif">Hi Ken,</font><br><br><font size=2 face="sans-serif">Could you reply to Joel if you have
any questions about his comments or make a new pull request so that the
change can be merged? Specifically is provide more info regarding the changes,
I'm copying the comments here. Thanks.</font><br><br><br><tt><font size=2>>> From: Ken <ken.sk.lai@mail.foxconn.com></font></tt><br><tt><font size=2>> We need to include a description of why this
change is being made.<br>> What does it fix? Why does the previous behaviour need to be modified?</font></tt><br><br><tt><font size=2>>> + writel(0x00001080,
AST_IO(AST_BASE_GPIO | 0x84));<br>> We have a GPIO driver that handles setting this register.</font></tt><br><br><tt><font size=2>>> + writel(0x010FFFFF,
AST_IO(AST_BASE_SCU | 0xA8));<br>> Can you explain each of these you're setting each of these bits?</font></tt><br><br><br><br><br><font size=1 color=#5f5f5f face="sans-serif">From:
</font><font size=1 face="sans-serif">Joel Stanley <joel@jms.id.au></font><br><font size=1 color=#5f5f5f face="sans-serif">To:
</font><font size=1 face="sans-serif">OpenBMC Patches <openbmc-patches@stwcx.xyz>,
ken.th.liu@foxconn.com</font><br><font size=1 color=#5f5f5f face="sans-serif">Cc:
</font><font size=1 face="sans-serif">OpenBMC Maillist <openbmc@lists.ozlabs.org></font><br><font size=1 color=#5f5f5f face="sans-serif">Date:
</font><font size=1 face="sans-serif">05/12/2016 02:11 AM</font><br><font size=1 color=#5f5f5f face="sans-serif">Subject:
</font><font size=1 face="sans-serif">Re: [PATCH linux]
Add debounce for power button, pull down gpioQ7 to unlock identify LED</font><br><font size=1 color=#5f5f5f face="sans-serif">Sent by:
</font><font size=1 face="sans-serif">"openbmc"
<openbmc-bounces+anoo=us.ibm.com@lists.ozlabs.org></font><br><hr noshade><br><br><br><tt><font size=2>ping<br><br>On Mon, May 2, 2016 at 11:12 AM, Joel Stanley <joel@jms.id.au> wrote:<br>> On Fri, Apr 29, 2016 at 3:10 PM, OpenBMC Patches<br>> <openbmc-patches@stwcx.xyz> wrote:<br>>> From: Ken <ken.sk.lai@mail.foxconn.com><br>>><br>><br>> We need to include a description of why this change is being made.<br>> What does it fix? Why does the previous behaviour need to be modified?<br>><br>>> ---<br>>> arch/arm/mach-aspeed/aspeed.c | 8 ++++++--<br>>> 1 file changed, 6 insertions(+), 2 deletions(-)<br>>> mode change 100644 => 100755 arch/arm/mach-aspeed/aspeed.c<br>>><br>>> diff --git a/arch/arm/mach-aspeed/aspeed.c b/arch/arm/mach-aspeed/aspeed.c<br>>> old mode 100644<br>>> new mode 100755<br>>> index 594a781..fa5d467<br>>> --- a/arch/arm/mach-aspeed/aspeed.c<br>>> +++ b/arch/arm/mach-aspeed/aspeed.c<br>>> @@ -138,9 +138,10 @@ static void __init do_barreleye_setup(void)<br>>> /* GPIO setup */<br>>> writel(0x9E82FCE7, AST_IO(AST_BASE_GPIO
| 0x00));<br>>> writel(0x0370E677, AST_IO(AST_BASE_GPIO
| 0x04));<br>>> -<br>>> + writel(0x00001080, AST_IO(AST_BASE_GPIO
| 0x84));<br>><br>> We have a GPIO driver that handles setting this register.<br>><br>>> /* SCU setup */<br>>> writel(0x01C00000, AST_IO(AST_BASE_SCU
| 0x88));<br>>> + writel(0x010FFFFF, AST_IO(AST_BASE_SCU
| 0xA8));<br>><br>> Can you explain each of these you're setting each of these bits?<br>><br>>> /*<br>>> * Do read/modify/write on power
gpio to prevent resetting power on<br>>> @@ -150,7 +151,10 @@ static void __init do_barreleye_setup(void)<br>>> reg |= 0xCFC8F7FD;<br>>> writel(reg, AST_IO(AST_BASE_GPIO |
0x20));<br>>> writel(0xC738F20A, AST_IO(AST_BASE_GPIO
| 0x24));<br>>> - writel(0x0031FFAF, AST_IO(AST_BASE_GPIO
| 0x80));<br>>> + writel(0x0031FF2F, AST_IO(AST_BASE_GPIO
| 0x80));<br>>> + writel(0x00000001, AST_IO(AST_BASE_GPIO
| 0x48));<br>>> + writel(0x00000001, AST_IO(AST_BASE_GPIO
| 0x4C));<br>>> + writel(0x00075300, AST_IO(AST_BASE_GPIO
| 0x58));<br>><br>> As above; we have a GPIO driver that handles setting this register.<br>> Changing these states needs to be done from userspace. See<br>> </font></tt><a href=https://github.com/openbmc/skeleton/blob/master/bin/Barreleye.py#L531><tt><font size=2>https://github.com/openbmc/skeleton/blob/master/bin/Barreleye.py#L531</font></tt></a><tt><font size=2><br>_______________________________________________<br>openbmc mailing list<br>openbmc@lists.ozlabs.org<br></font></tt><a href=https://lists.ozlabs.org/listinfo/openbmc><tt><font size=2>https://lists.ozlabs.org/listinfo/openbmc</font></tt></a><tt><font size=2><br></font></tt><br><br><BR>