<html><body><p>Hi Vishwa,<br><br>Thanks for the comments. I've create a new dbus API based on your suggestions.<br>Please have a look:<br><a href="https://github.com/openbmc/skeleton/pull/62">https://github.com/openbmc/skeleton/pull/62</a><br><a href="https://github.com/openbmc/ipmi-fru-parser/pull/14/files">https://github.com/openbmc/ipmi-fru-parser/pull/14/files</a><br><br>Thanks,<br>-Yi<br><br><tt>Vishwanatha Subbanna/India/IBM wrote on 04/11/2016 05:49:54 PM:<br><br>> From: Vishwanatha Subbanna/India/IBM</tt><br><tt>> To: OpenBMC Patches <openbmc-patches@stwcx.xyz>, OpenBMC Members, Yi<br>> TZ Li/China/IBM@IBMCN</tt><br><tt>> Cc: openbmc@lists.ozlabs.org</tt><br><tt>> Date: 04/11/2016 05:49 PM</tt><br><tt>> Subject: Re: [PATCH skeleton] skeleton: Add new API <br>> SystemManager::getFRUObject()</tt><br><tt>> <br>> Hello Yi,</tt><br><tt>> <br>> Thanks for the patch. Here are my comments.</tt><br><tt>> <br>> "openbmc" <openbmc-bounces+vishwanath=in.ibm.com@lists.ozlabs.org> <br>> wrote on 11/04/2016 02:40:52 pm:<br>> <br>> > From: OpenBMC Patches <openbmc-patches@stwcx.xyz></tt><br><tt>> > To: openbmc@lists.ozlabs.org</tt><br><tt>> > Date: 11/04/2016 02:41 pm</tt><br><tt>> > Subject: [PATCH skeleton] skeleton: Add new API <br>> SystemManager::getFRUObject()</tt><br><tt>> > Sent by: "openbmc" <openbmc-bounces+vishwanath=in.ibm.com@lists.ozlabs.org></tt><br><tt>> > <br>> > ipmi-fru-parser uses getObjectFromId('FRU_STR', fru_area_name) to<br>> > ask for the dbus object path of the 'fru_area_name'. The returned<br>> > value is also used to check the 'present' status of FRU. Sometimes<br>> > the 'fru_area_name' does not defined in Skeleton's ID_LOOKUP table.<br>> > system_manager will report a "ERROR: lookup not found" error message.<br>> > </tt><br><tt>> <br>> <br>> > This patch added an API similiar with getObjectFromId().<br>> > It does not report error when the 'fru_area_name' is not defined.<br>> > It can be used by ipmi-fru-parser to replace getObjectFromId().<br>> > </tt><br><tt>> <br>> If something is not there, it is still an error. So masking the <br>> error may not be a right approach.</tt><br><tt>> <br>> <br>> > Also the orignal "ERROR" message is changed to "WARNING".<br>> > </tt><br><tt>> <br>> IMO, we may not be solving the root cause here.. "WARNING", -or- <br>> "ERROR" would still bother whoever looking into it. </tt><br><tt>> So, I still feel that we need to make the actual change.</tt><br><tt>> <br>> When I initially proposed a solution to Norm to remove those ERRORs,<br>> he had an opinion that "something not there is not there, so its an error".</tt><br><tt>> <br>> Here is how I look into it ( one of the implementations .. )</tt><br><tt>> <br>> 1: writefru data will make a call into a new API passing the fru id.</tt><br><tt>> 2: Skeleton code will return the available sections for that fru id.<br>> ( example: chassis, board / board, product etc )</tt><br><tt>> 3: writefru will use that and then make getObjectFromByteId for a <br>> particular fruid_<area></tt><br><tt>> <br></tt><br><tt>> > Signed-off-by: Yi Li <adamliyi@msn.com><br>> > <br>> > <!-- Reviewable:start --><br>> > ---<br>> > This change is <img src="https://reviewable.io/review_button.svg"
> > height="35" align="absmiddle" alt="Reviewable"/>(https://<br>> > reviewable.io/reviews/openbmc/skeleton/60)<br>> > <!-- Reviewable:end --><br>> > <br>> > <br>> > <a href="https://github.com/openbmc/skeleton/pull/60">https://github.com/openbmc/skeleton/pull/60</a><br>> > <br>> > Yi Li (1):<br>> > skeleton: Add new API SystemManager::getFRUObject()<br>> > <br>> > bin/system_manager.py | 40 +++++++++++++++++++++++++++-------------<br>> > 1 file changed, 27 insertions(+), 13 deletions(-)<br>> > <br>> > -- <br>> > 2.7.1<br>> > <br>> > <br>> > _______________________________________________<br>> > openbmc mailing list<br>> > openbmc@lists.ozlabs.org<br>> > <a href="https://lists.ozlabs.org/listinfo/openbmc">https://lists.ozlabs.org/listinfo/openbmc</a><br></tt><BR>
</body></html>