<html><body><p>Hi Jeremy,<br><br>Thanks for the comments. I agree with all and will soon update the doc to address the comments.<br><br>I don't quite get what I need to be doing for your last comment:<br> <tt>Also, a signed-off-by line is required, to indicate that you've agreed<br> to the Developers Certificate of Origin.</tt><br><br>Thanks,<br>rhari !<br><br>Hariharasubramanian R.<br>Power Firmware Development<br>IBM India Systems & Technology Lab, Bangalore, India<br>Phone: +91 80 4025 6950 <br><br><img width="16" height="16" src="cid:1__=EABBF5E4DFB8FBE98f9e8a93df938690918cEAB@" border="0" alt="Inactive hide details for Jeremy Kerr ---03/15/2016 08:44:00 AM---Hi Hari, > From: Hariharasubramanian R <hramasub@in.ibm.com>"><font color="#424282">Jeremy Kerr ---03/15/2016 08:44:00 AM---Hi Hari, > From: Hariharasubramanian R <hramasub@in.ibm.com></font><br><br><font size="2" color="#5F5F5F">From: </font><font size="2">Jeremy Kerr <jk@ozlabs.org></font><br><font size="2" color="#5F5F5F">To: </font><font size="2">openbmc@lists.ozlabs.org</font><br><font size="2" color="#5F5F5F">Date: </font><font size="2">03/15/2016 08:44 AM</font><br><font size="2" color="#5F5F5F">Subject: </font><font size="2">Re: [PATCH docs] REST API documentation for OpenBMC user management.</font><br><font size="2" color="#5F5F5F">Sent by: </font><font size="2">"openbmc" <openbmc-bounces+hramasub=in.ibm.com@lists.ozlabs.org></font><br><hr width="100%" size="2" align="left" noshade style="color:#8091A5; "><br><br><br><tt>Hi Hari,<br><br>> From: Hariharasubramanian R <hramasub@in.ibm.com><br>> <br>> ---<br>> obmc-userman.md | 82 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++<br><br>Thanks for this! It's great to have this document. A couple of comments.<br>They're pretty minor though:<br><br>The doc makes reference to the REST API, but is this also applicable to<br>DBUS? If so, we might want to split this up a little:<br><br> - formal DBUS specs should do into the dbus-interfaces.md document<br><br> - informal usage guides can be a separate document<br><br>It seems that this is more the latter, which is fine. However, you may<br>also want to consider adding a spec to the dbus-interfaces doc as an<br>additional change.<br><br>The term 'userman' could be interpreted to mean "User Manual", not "User<br>Management". We don't really need to contract filenames this much,<br>calling it something like user-management.md would be fine.<br><br>Could you wrap lines at 80 chars? This makes things easier to read in<br>text form. Also, can you also add a reference to this to the main<br>README.md doc?<br><br>Also, a signed-off-by line is required, to indicate that you've agreed<br>to the Developers Certificate of Origin.<br><br>Cheers,<br><br><br>Jeremy<br>_______________________________________________<br>openbmc mailing list<br>openbmc@lists.ozlabs.org<br></tt><tt><a href="https://lists.ozlabs.org/listinfo/openbmc">https://lists.ozlabs.org/listinfo/openbmc</a></tt><tt><br></tt><br><BR>
</body></html>