<html><body><p><tt>Shouldn't the value of rc be something that is an ipmi_ret_t ?</tt><br><br>Yes : It needs to be even though CC_OK and 0 are same.<br><br>Thanks<br><br>-------------------------------------------------------------------------------------<br>Thanks and Regards,<br>Vishwanath.<br>Advisory Software Engineer,<br>Power Firmware Development, <br>Systems &Technology Lab,<br>MG2-6F-255 , Manyata Embassy Business Park, <br>Bangalore , KA , 560045<br>Ph: +91-80-46678255<br>E-mail: vishwanath@in.ibm.com<br>----------------------------------------------------------------------------------<br><br><img width="16" height="16" src="cid:1__=EABBF5E2DFB3DBFD8f9e8a93df938690918cEAB@" border="0" alt="Inactive hide details for Stewart Smith ---09/03/2016 10:56:02 am---OpenBMC Patches <openbmc-patches@stwcx.xyz> writes: > From:"><font color="#424282">Stewart Smith ---09/03/2016 10:56:02 am---OpenBMC Patches <openbmc-patches@stwcx.xyz> writes: > From: Norman James <njames@us.ibm.com></font><br><br><font size="2" color="#5F5F5F">From: </font><font size="2">Stewart Smith <stewart@linux.vnet.ibm.com></font><br><font size="2" color="#5F5F5F">To: </font><font size="2">OpenBMC Patches <openbmc-patches@stwcx.xyz>, openbmc@lists.ozlabs.org</font><br><font size="2" color="#5F5F5F">Cc: </font><font size="2">Norman James <nkskjames@gmail.com></font><br><font size="2" color="#5F5F5F">Date: </font><font size="2">09/03/2016 10:56 am</font><br><font size="2" color="#5F5F5F">Subject: </font><font size="2">Re: [PATCH phosphor-host-ipmid v2] DCMI GET_POWER_LEVEL bad return code</font><br><font size="2" color="#5F5F5F">Sent by: </font><font size="2">"openbmc" <openbmc-bounces+vishwanath=in.ibm.com@lists.ozlabs.org></font><br><hr width="100%" size="2" align="left" noshade style="color:#8091A5; "><br><br><br><tt>OpenBMC Patches <openbmc-patches@stwcx.xyz> writes:<br><br>> From: Norman James <njames@us.ibm.com><br>><br>> This function uses static data and should always<br>> return a good return code. This was causing OCC<br>> not to start.<br>><br>> Signed-off-by: Norman James <nkskjames@gmail.com><br>> ---<br>> dcmihandler.C | 3 +--<br>> 1 file changed, 1 insertion(+), 2 deletions(-)<br>><br>> diff --git a/dcmihandler.C b/dcmihandler.C<br>> index fafebdc..5e7d879 100644<br>> --- a/dcmihandler.C<br>> +++ b/dcmihandler.C<br>> @@ -11,7 +11,7 @@ ipmi_ret_t ipmi_dcmi_get_power_limit(ipmi_netfn_t netfn, ipmi_cmd_t cmd,<br>> ipmi_request_t request, ipmi_response_t response, <br>> ipmi_data_len_t data_len, ipmi_context_t context)<br>> {<br>> - ipmi_ret_t rc = IPMI_DCMI_CC_NO_ACTIVE_POWER_LIMIT;<br>> + ipmi_ret_t rc = 0;<br>> <br>> // dcmi-v1-5-rev-spec.pdf 6.6.2.<br><br>Shouldn't the value of rc be something that is an ipmi_ret_t ?<br><br>> // This is good enough for OpenBMC support for OpenPOWER based systems<br>> @@ -37,4 +37,3 @@ void register_netfn_dcmi_functions()<br>> ipmi_register_callback(NETFUN_GRPEXT, IPMI_CMD_DCMI_GET_POWER, NULL, ipmi_dcmi_get_power_limit);<br>> return;<br>> }<br>> -// 956379<br>> \ No newline at end of file<br><br>Above hunk is irrelevant.<br><br>-- <br>Stewart Smith<br>OPAL Architect, IBM.<br><br>_______________________________________________<br>openbmc mailing list<br>openbmc@lists.ozlabs.org<br></tt><tt><a href="https://lists.ozlabs.org/listinfo/openbmc">https://lists.ozlabs.org/listinfo/openbmc</a></tt><tt><br></tt><br><br><BR>
</body></html>