<div class="socmaildefaultfont" dir="ltr" style="font-family:Arial;font-size:10.5pt" ><div dir="ltr" >if you make this a success (which really should be IPMI_OK_CC) are there other response bytes that are expected to be valid?
<div> </div>
<div><a href="http://www.intel.com/content/dam/www/public/us/en/documents/technical-specifications/dcmi-v1-5-rev-spec.pdf" >http://www.intel.com/content/dam/www/public/us/en/documents/technical-specifications/dcmi-v1-5-rev-spec.pdf</a> page 43 shows a lot of bytes that need a value now that you returned success. Don't drop the code until you added those response bytes
<div><br>Chris Austen<br>POWER Systems Enablement Manager<br>(512) 286-5184 (T/L: 363-5184)
<div> </div>
<div> </div>
<blockquote data-history-content-modified="1" style="border-left:solid #aaaaaa 2px; margin-left:5px; padding-left:5px; direction:ltr; margin-right:0px" >----- Original message -----<br>From: OpenBMC Patches <openbmc-patches@stwcx.xyz><br>Sent by: "openbmc" <openbmc-bounces+austenc=us.ibm.com@lists.ozlabs.org><br>To: openbmc@lists.ozlabs.org<br>Cc: Norman James <nkskjames@gmail.com><br>Subject: [PATCH phosphor-host-ipmid v2] DCMI GET_POWER_LEVEL bad return code<br>Date: Tue, Mar 8, 2016 11:02 AM<br>
<div><font face="Default Monospace,Courier New,Courier,monospace" size="2" >From: Norman James <njames@us.ibm.com><br><br>This function uses static data and should always<br>return a good return code. This was causing OCC<br>not to start.<br><br>Signed-off-by: Norman James <nkskjames@gmail.com><br>---<br> dcmihandler.C | 3 +--<br> 1 file changed, 1 insertion(+), 2 deletions(-)<br><br>diff --git a/dcmihandler.C b/dcmihandler.C<br>index fafebdc..5e7d879 100644<br>--- a/dcmihandler.C<br>+++ b/dcmihandler.C<br>@@ -11,7 +11,7 @@ ipmi_ret_t ipmi_dcmi_get_power_limit(ipmi_netfn_t netfn, ipmi_cmd_t cmd,<br> ipmi_request_t request, ipmi_response_t response,<br> ipmi_data_len_t data_len, ipmi_context_t context)<br> {<br>- ipmi_ret_t rc = IPMI_DCMI_CC_NO_ACTIVE_POWER_LIMIT;<br>+ ipmi_ret_t rc = 0;<br> <br> // dcmi-v1-5-rev-spec.pdf 6.6.2. <br> // This is good enough for OpenBMC support for OpenPOWER based systems<br>@@ -37,4 +37,3 @@ void register_netfn_dcmi_functions()<br> ipmi_register_callback(NETFUN_GRPEXT, IPMI_CMD_DCMI_GET_POWER, NULL, ipmi_dcmi_get_power_limit);<br> return;<br> }<br>-// 956379<br>\ No newline at end of file<br>--<br>2.7.1<br><br><br>_______________________________________________<br>openbmc mailing list<br>openbmc@lists.ozlabs.org<br><a href="https://lists.ozlabs.org/listinfo/openbmc" target="_blank" >https://lists.ozlabs.org/listinfo/openbmc</a></font></div></blockquote></div></div></div></div><BR>