<html><body><p>I've tested it pretty well too. I have powered on/off several times and made sure boot makes it to petitboot and console behaves normal with the menu. I would add Tested-by flag if someone could tell me how to do that.<br><br>The only strange thing is that the screen utility hangs for several seconds when exiting (Ctrl-a k) console which it didn't do with regular UART.<br><br><br>Regards,<br>Norman James<br>IBM - POWER Systems Architect<br>Phone: 1-512-286-6807 (T/L: 363-6807)<br>Internet: njames@us.ibm.com<br><br><br><img width="16" height="16" src="cid:1__=09BBF5C6DFD640E78f9e8a93df938690918c09B@" border="0" alt="Inactive hide details for Joel Stanley ---02/09/2016 11:40:39 PM---On Wed, Feb 10, 2016 at 12:55 AM, Jeremy Kerr <jk@ozlabs.org"><font color="#424282">Joel Stanley ---02/09/2016 11:40:39 PM---On Wed, Feb 10, 2016 at 12:55 AM, Jeremy Kerr <jk@ozlabs.org> wrote: > If host TX discard mode is en</font><br><br><font size="2" color="#5F5F5F">From: </font><font size="2">Joel Stanley <joel@jms.id.au></font><br><font size="2" color="#5F5F5F">To: </font><font size="2">Jeremy Kerr <jk@ozlabs.org></font><br><font size="2" color="#5F5F5F">Cc: </font><font size="2">OpenBMC Maillist <openbmc@lists.ozlabs.org></font><br><font size="2" color="#5F5F5F">Date: </font><font size="2">02/09/2016 11:40 PM</font><br><font size="2" color="#5F5F5F">Subject: </font><font size="2">Re: [PATCH] serial/aspeed-vuart: Disable host TX discard mode during init</font><br><font size="2" color="#5F5F5F">Sent by: </font><font size="2">"openbmc" <openbmc-bounces+njames=us.ibm.com@lists.ozlabs.org></font><br><hr width="100%" size="2" align="left" noshade style="color:#8091A5; "><br><br><br><tt>On Wed, Feb 10, 2016 at 12:55 AM, Jeremy Kerr <jk@ozlabs.org> wrote:<br>> If host TX discard mode is enabled, we don't see the LSR[RBR} bit<br>> getting set on new characters written on the host side. This makes the<br>> VUART a little useless.<br>><br>> This change set this bit during VUART initialisation, to disable host<br>> TX discard.<br><br>Thanks! I've pulled it in; I'll push it out once I've given it a spin.<br><br>Do you have some notes on how you tested it?<br><br>><br>> Signed-off-by: Jeremy Kerr <jk@ozlabs.org><br><br>Reviewed-by: Joel Stanley <joel@jms.id.au><br>> ---<br>> drivers/tty/serial/aspeed-vuart.c | 15 ++++++++++++++-<br>> 1 file changed, 14 insertions(+), 1 deletion(-)<br>><br>> diff --git a/drivers/tty/serial/aspeed-vuart.c b/drivers/tty/serial/aspeed-vuart.c<br>> index f1988dd..a56d3a9 100644<br>> --- a/drivers/tty/serial/aspeed-vuart.c<br>> +++ b/drivers/tty/serial/aspeed-vuart.c<br>> @@ -20,7 +20,8 @@<br>> #include "8250/8250.h"<br>><br>> #define AST_VUART_GCRA 0x20<br>> -#define AST_VUART_GCRA_VUART_EN 0x1<br>> +#define AST_VUART_GCRA_VUART_EN 0x01<br>> +#define AST_VUART_GCRA_HOST_TX_DISCARD 0x20<br>> #define AST_VUART_GCRB 0x24<br>> #define AST_VUART_GCRB_HOST_SIRQ_MASK 0xf0<br>> #define AST_VUART_GCRB_HOST_SIRQ_SHIFT 4<br>> @@ -143,6 +144,17 @@ static ssize_t ast_vuart_set_sirq(struct device *dev,<br>> static DEVICE_ATTR(sirq, S_IWUSR | S_IRUGO,<br>> ast_vuart_show_sirq, ast_vuart_set_sirq);<br>><br>> +static void ast_vuart_setup(struct ast_vuart *vuart)<br>> +{<br>> + u8 reg;<br>> +<br>> + /* disable TX discard mode */<br>> + reg = readb(vuart->regs + AST_VUART_GCRA);<br>> + reg |= AST_VUART_GCRA_HOST_TX_DISCARD;<br>> + writeb(reg, vuart->regs + AST_VUART_GCRA);<br>> +}<br>> +<br>> +<br>> /**<br>> * The device tree parsinc code here is heavily based on that of the of_serial<br>> * driver, but we have a few core differences, as we need to use our own<br>> @@ -261,6 +273,7 @@ static int ast_vuart_probe(struct platform_device *pdev)<br>><br>> vuart->line = rc;<br>> platform_set_drvdata(pdev, vuart);<br>> + ast_vuart_setup(vuart);<br>><br>> /* extra sysfs control */<br>> rc = device_create_file(&pdev->dev, &dev_attr_lpc_address);<br>> --<br>> 2.5.0<br>><br>> _______________________________________________<br>> openbmc mailing list<br>> openbmc@lists.ozlabs.org<br>> </tt><tt><a href="https://lists.ozlabs.org/listinfo/openbmc">https://lists.ozlabs.org/listinfo/openbmc</a></tt><tt><br>_______________________________________________<br>openbmc mailing list<br>openbmc@lists.ozlabs.org<br></tt><tt><a href="https://lists.ozlabs.org/listinfo/openbmc">https://lists.ozlabs.org/listinfo/openbmc</a></tt><tt><br></tt><br><BR>
</body></html>