Proposal: Removing redundant EpochTime interface from dump entry

Lei Yu yulei.sh at bytedance.com
Thu Sep 21 13:34:41 AEST 2023


On Thu, Sep 21, 2023 at 11:23 AM dhruvaraj S <dhruvaraj at gmail.com> wrote:
>
> Hi,
>
> In the current implementation, objects implementing the dump entry
> interface implement both xyz.openbmc_project.Common.Progress (for dump
> creation start time, end time, and status) and
> xyz.openbmc_project.Time.Epoch (for dump creation time, which is
> effectively the end time). This leads to a redundancy in specifying
> the dump creation end time.
>
> My proposed change updates the documentation of the interface,
> removing the reference to xyz.openbmc_project.Time.Epoch and adding a
> reference to xyz.openbmc_project.Common.Progress. This is to remove
> the need for updating the creation time in multiple locations.
>
> You can review the change here:
> https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/66680
>
> Please note that this change will have an impact on any applications
> that are currently reading the dump creation time from the EpochTime
> interface. These applications will need to be updated to read the
> creation time from the xyz.openbmc_project.Common.Progress interface
> instead.

Could you please list the impact applications in the openbmc organization?
And could you propose changes to the applications to use
`xyz.openbmc_project.Common.Progress` instead of
`xyz.openbmc_project.Time.Epoch`, so that we get a smooth transition?
Thanks!

-- 
BRs,
Lei YU


More information about the openbmc mailing list