[PATCH v4 2/2] mmc: sdhci-npcm: Add NPCM SDHCI driver

Tomer Maimon tmaimon77 at gmail.com
Tue Oct 3 07:07:39 AEDT 2023


Hi Andy

Thank a lot Address in V5

On Mon, 2 Oct 2023 at 22:46, Andy Shevchenko <andy.shevchenko at gmail.com> wrote:
>
> On Mon, Oct 2, 2023 at 10:41 PM Tomer Maimon <tmaimon77 at gmail.com> wrote:
> >
> > Add Nuvoton NPCM BMC sdhci-pltfm controller driver.
>
> ...
>
> > +       pltfm_host->clk = devm_clk_get_optional_enabled(dev, NULL);
> > +       if (IS_ERR(pltfm_host->clk)) {
> > +               ret = PTR_ERR(pltfm_host->clk);
> > +               goto err_sdhci;
> > +       }
>
> ...
>
> > +err_sdhci_clk:
> > +       clk_disable_unprepare(pltfm_host->clk);
>
> Now this is leftover that leads to unbalanced reference counting.
>
> --
> With Best Regards,
> Andy Shevchenko


More information about the openbmc mailing list