phosphor-buttons multihost control

Patrick Williams patrick at stwcx.xyz
Tue Sep 27 02:26:23 AEST 2022


Hi Zehra,

On Mon, Sep 26, 2022 at 07:38:39PM +0530, Naveen Moses wrote:
> The host Selector object is not strictly required. The host selector object
> check was only added to identify if the system is single host or multi host
> system based on host selector availability.
> Thanks.
> 
> On Mon, Sep 26, 2022 at 12:58 PM <zehra.ozdemir at inventron.com.tr> wrote:
> 
> > Hello,
> >
> >
> >
> > There is an isMultiHost() method to control to return true in case the
> > host selector object is available in button-handler.cpp of the
> > phosphor-buttons. And if it is not available, it does not return false and
> > the project gets an error. So we covered this return line with try catch
> > and it works.

Based on what Naveen wrote, it would be helpful if you could submit a
change to improve the implementation to not have this issue.  I'm
surprised no one else has ran into the issues you are seeing.

> >
> > But my question is, does this host selector object has to be strictly
> > defined for the project to run properly?
> >
> >
> >
> > Thanks.
> >

-- 
Patrick Williams
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20220926/eb6b37fb/attachment.sig>


More information about the openbmc mailing list