[PATCH] ipmi: kcs: aspeed: Update port address comments

ChiaWei Wang chiawei_wang at aspeedtech.com
Fri Sep 23 11:12:52 AEST 2022


> From: Corey Minyard <tcminyard at gmail.com> On Behalf Of Corey Minyard
> Sent: Friday, September 23, 2022 8:47 AM
> 
> On Fri, Sep 23, 2022 at 12:38:08AM +0000, ChiaWei Wang wrote:
> > > From: Corey Minyard <tcminyard at gmail.com> On Behalf Of Corey
> Minyard
> > > Sent: Friday, September 23, 2022 8:21 AM
> > >
> > > On Fri, Sep 23, 2022 at 12:08:07AM +0000, ChiaWei Wang wrote:
> > > > Hi Corey,
> > > >
> > > > > From: Corey Minyard <tcminyard at gmail.com> On Behalf Of Corey
> > > Minyard
> > > > > Sent: Friday, September 23, 2022 2:58 AM
> > > > >
> > > > > On Tue, Sep 20, 2022 at 10:03:33AM +0800, Chia-Wei Wang wrote:
> > > > > > Remove AST_usrGuide_KCS.pdf as it is no longer maintained.
> > > > >
> > > > > Even if it's no longer maintained, is it useful?  It seems
> > > > > better to leave in useful documentation unless it has been
> > > > > replaced with something
> > > else.
> > > >
> > > > This document has no permeant public link to access.
> > > > Aspeed has dropped this file but we keep receiving customer
> > > > request asking
> > > for this document.
> > > > The most important part regarding KCS port rule is still kept in
> > > > the updated
> > > comment.
> > >
> > > I mean, if you have code that is implementing what is documented,
> > > why did you remove the document?  I don't understand why you would
> > > retire documentation that people still want to use.
> > >
> > > I could put it on the IPMI sourceforge or github page as a historical
> document.
> >
> > This document is a personal note of one of our former employee.
> > It is known to only the owner and his supporting customers.
> > Most of us has no access to this document.
> > In addition, after chip revision, certain information is not guaranteed
> anymore.
> 
> Ok, I'll take the patch.  Thanks.

Thanks!

Regards,
Chiawei



More information about the openbmc mailing list