[PATCH linux dev-4.10 v4 28/31] drivers: fsi: occ: Add cancel to remove() and fix probe()

[Joel Stanley]

On Mon, Oct 9, 2017 at 10:35 AM, Brad Bishop
<bradleyb at fuzziesquirrel.com> wrote:
>
>> On Oct 5, 2017, at 10:05 PM, Eddie James <eajames at linux.vnet.ibm.com> wrote:
>> -static void occ_enqueue_xfr(struct occ_xfr *xfr)
>> +static int occ_enqueue_xfr(struct occ_xfr *xfr)
>> {
>>       int empty;
>>       struct occ_client *client = to_client(xfr);
>>       struct occ *occ = client->occ;
>>
>> +     if (occ->cancel)
>> +             return -ECANCELED;
>
> Can we have ENODEV here?  That seems to be typical for this scenario and
> ECANCELED seems to be for canceled AIO operations.

I agree.

Eddie, I will fold this change in when I merge if you're okay with it?

Cheers,

Joel