<!DOCTYPE html>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p><br>
</p>
<div class="moz-cite-prefix">On 31/03/26 03:41, Andrew Morton wrote:<br>
</div>
<blockquote type="cite"
cite="mid:20260330151125.d0b6cbb24b273bc963b05116@linux-foundation.org">
<pre wrap="" class="moz-quote-pre">On Mon, 30 Mar 2026 11:27:04 +0530 Sayali Patil <a class="moz-txt-link-rfc2396E" href="mailto:sayalip@linux.ibm.com"><sayalip@linux.ibm.com></a> wrote:
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="" class="moz-quote-pre">I don't want to risk breaking selftests so I'll set v3 aside until
you're confident we should proceed.
Thanks.
</pre>
</blockquote>
<pre wrap="" class="moz-quote-pre">
This line continuation pattern has been used in selftests for quite some
time. For example, a similar usage exists in
|charge_reserved_hugetlb.sh|, introduced here:
<a class="moz-txt-link-freetext" href="https://lore.kernel.org/all/20200211213128.73302-8-almasrymina@google.com/T/#u">https://lore.kernel.org/all/20200211213128.73302-8-almasrymina@google.com/T/#u</a>
<a class="moz-txt-link-rfc2396E" href="https://lore.kernel.org/all/20200211213128.73302-8-almasrymina@google.com/T/#u"><https://lore.kernel.org/all/20200211213128.73302-8-almasrymina@google.com/T/#u></a>
echo "$reservation_limit" > \
$cgroup_path/$name/hugetlb.${MB}MB.$reservation_limit_file
In this case, it was primarily used to keep line length within 100
characters. I’ve tested the script and it behaved as expected.
</pre>
</blockquote>
<pre wrap="" class="moz-quote-pre">
Great, thanks for checking.
Series is nicely reviewed and an earlier version spent time in mm.git.
And the bar tends to be lower for selftests. So I *could* break my rule
(<a class="moz-txt-link-freetext" href="https://lkml.kernel.org/r/20260323202941.08ddf2b0411501cae801ab4c@linux-foundation.org">https://lkml.kernel.org/r/20260323202941.08ddf2b0411501cae801ab4c@linux-foundation.org</a>)
but would prefer not. What do others think?
Did Venkat's report
(<a class="moz-txt-link-freetext" href="https://lkml.kernel.org/r/cf815c21-138e-44c8-986d-d8496503ee32@linux.ibm.com">https://lkml.kernel.org/r/cf815c21-138e-44c8-986d-d8496503ee32@linux.ibm.com</a>)
get addressed? I'm not seeing that in the v2->v3 changelogging.
</pre>
</blockquote>
<font face="monospace">Hi Andrew,<br>
I am making changes as per AI review comments and will include
them in v4.<br>
The comments were helpful and should improve the overall quality
of the series.<br>
Also venkat's report has been addressed in v3 <span
style="white-space: pre-wrap">in "selftest/mm: fix cgroup task placement and drop memory.current checks</span><span
style="white-space: pre-wrap"> in hugetlb_reparenting_test.sh" patch.</span><br>
<br>
Thanks,<br>
Sayali</font>
</body>
</html>