<html class="apple-mail-supports-explicit-dark-mode"><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div dir="ltr"><br></div><div dir="ltr"><br><blockquote type="cite">On 01 November 2025 at 06:40 am, Christian Zigotzky <chzigotzky@xenosoft.de> wrote:<br><br></blockquote></div><blockquote type="cite"><div dir="ltr"><span></span><br><span>> Bjorn Helgaas <helgaas@kernel.org> wrote:</span><br><span>></span><br><span>> Oops, I made that fixup run too late. Instead of the patch above, can</span><br><span>> you test the one below?</span><br><span>></span><br><span>> You'll likely see something like this, which is a little misleading</span><br><span>> because even though we claim "default L1" for 01:00.0 (or whatever</span><br><span>> your Radeon is), the fact that L0s and L1 are disabled at the other</span><br><span>> end of the link (00:00.0) should prevent us from actually enabling it:</span><br><span>></span><br><span>> pci 0000:00:00.0: Disabling ASPM L0s/L1</span><br><span>> pci 0000:01:00.0: ASPM: default states L1</span><br><span>></span><br><span>> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c</span><br><span>> index 214ed060ca1b..27777ded9a2c 100644</span><br><span>> --- a/drivers/pci/quirks.c</span><br><span>> +++ b/drivers/pci/quirks.c</span><br><span>> @@ -2524,6 +2524,7 @@ static void quirk_disable_aspm_l0s_l1(struct pci_dev *dev)</span><br><span>> * disable both L0s and L1 for now to be safe.</span><br><span>> */</span><br><span>> DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ASMEDIA, 0x1080, quirk_disable_aspm_l0s_l1);</span><br><span>> +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_FREESCALE, 0x0451, quirk_disable_aspm_l0s_l1);</span><br><span>></span><br><span>> /*</span><br><span>> * Some Pericom PCIe-to-PCI bridges in reverse mode need the PCIe Retrain</span><br><span></span><br><span>Hi Bjorn,</span><br><span></span><br><span>Thanks for your patch. I patched the RC3 of kernel 6.18 with your new patch and compiled it again. Unfortunately the FSL Cyrus+ board doesn't boot with your new patch.</span><br><span></span><br><span>Sorry,</span><br><span></span><br><span>Christian</span><br><span></span><br><span>-- </span><br><span>Sent with BrassMonkey 33.9.1 (https://github.com/chzigotzky/Web-Browsers-and-Suites-for-Linux-PPC/releases/tag/BrassMonkey_33.9.1)</span><br><span></span><br></div></blockquote><br><div><div>What about with </div><div><br></div><div>+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, PCI_ANY_ID, quirk_disable_aspm_l0s_l1);</div><div><br></div><div>?</div><div><br></div><div>- Christian</div></div><div><pre class="notranslate" style="box-sizing: border-box; font-family: var(--fontStack-monospace, ui-monospace, SFMono-Regular, SF Mono, Menlo, Consolas, Liberation Mono, monospace); font-size: 11.9px; margin-top: 0px; margin-bottom: var(--base-size-16); tab-size: var(--tab-size-preference); overflow-wrap: normal; padding: var(--base-size-16); overflow: auto; line-height: 1.45; color: rgb(240, 246, 252); border-radius: 6px; caret-color: rgb(240, 246, 252); -webkit-text-size-adjust: 100%;"><code class="notranslate" style="box-sizing: border-box; font-family: var(--fontStack-monospace, ui-monospace, SFMono-Regular, SF Mono, Menlo, Consolas, Liberation Mono, monospace); font-size: 11.9px; tab-size: var(--tab-size-preference); padding: 0px; margin: 0px; white-space: pre; background-image: none; background-position: 0% 0%; background-size: auto; background-repeat: repeat; background-attachment: scroll; background-origin: padding-box; background-clip: border-box; border-radius: 6px; word-break: normal; border: 0px; display: inline; overflow: visible; line-height: inherit; overflow-wrap: normal;"><br></code></pre></div></body></html>