<!DOCTYPE html>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Yes, checkpath was run. </p>
<p>Not sure what you mean by "<span style="white-space: pre-wrap">some indentation changes.(This can't go with fixes patch, </span><span
style="white-space: pre-wrap">will just add the noise)"</span></p>
<p>Thanks.<br>
</p>
<div class="moz-cite-prefix">On 9/13/24 1:22 AM, Kamlesh Gurudasani
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:875xr0m5ss.fsf@kamlesh.i-did-not-set--mail-host-address--so-tickle-me">
<pre wrap="" class="moz-quote-pre">Michael Ellerman <a class="moz-txt-link-rfc2396E" href="mailto:mpe@ellerman.id.au"><mpe@ellerman.id.au></a> writes:
</pre>
<blockquote type="cite">
<pre wrap="" class="moz-quote-pre">Danny Tsen <a class="moz-txt-link-rfc2396E" href="mailto:dtsen@linux.ibm.com"><dtsen@linux.ibm.com></a> writes:
</pre>
<blockquote type="cite">
<pre wrap="" class="moz-quote-pre">This patch is to fix an issue when simd is not usable that data mismatch
may occur over ipsec tunnel. The fix is to register algs as SIMD modules
so that the algorithm is excecuted when SIMD instructions is usable.
A new module rfc4106(gcm(aes)) is also added. Re-write AES/GCM assembly
codes with smaller footprints and small performance gain.
This patch has been tested with the kernel crypto module tcrypt.ko and
has passed the selftest. The patch is also tested with
CONFIG_CRYPTO_MANAGER_EXTRA_TESTS enabled.
Signed-off-by: Danny Tsen <a class="moz-txt-link-rfc2396E" href="mailto:dtsen@linux.ibm.com"><dtsen@linux.ibm.com></a>
---
arch/powerpc/crypto/Kconfig | 1 +
arch/powerpc/crypto/aes-gcm-p10-glue.c | 141 +-
arch/powerpc/crypto/aes-gcm-p10.S | 2421 +++++++++++-------------
3 files changed, 1187 insertions(+), 1376 deletions(-)
</pre>
</blockquote>
<pre wrap="" class="moz-quote-pre">
As this is a bug fix it should have a Fixes: tag, and probably a stable
Cc as well.
But that diffstat is really large for a bug fix. Is there no way to fix
the issue in a smaller patch? Even if that is just disabling the feature
until it can be fixed in subsequent commits?
cheers
</pre>
</blockquote>
<pre wrap="" class="moz-quote-pre">The commit message says "The fix is to register algs as SIMD modules"
and
"A new module rfc4106(gcm(aes)) is also added."
and I also see some indentation changes.(This can't go with fixes patch,
will just add the noise)
Would suggest to break the patch in three.
I see a big subject line, have you ran the checkpatch?
Kamlesh
</pre>
</blockquote>
</body>
</html>