<!DOCTYPE html>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p><font face="monospace">Hi Masahiro, thanks for reviewing</font>.<br>
</p>
<div class="moz-cite-prefix"><font face="monospace">On 4/22/24 5:39
PM, Masahiro Yamada wrote:</font><br>
</div>
<blockquote type="cite"
cite="mid:CAK7LNAR3R2MfP69pbXNYx3TCeQiaC-Pjb=zfnMifHRUvhCQA6w@mail.gmail.com">
<pre class="moz-quote-pre" wrap="">On Mon, Apr 22, 2024 at 6:25 PM Sathvika Vasireddy <a class="moz-txt-link-rfc2396E" href="mailto:sv@linux.ibm.com"><sv@linux.ibm.com></a> wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">
Currently, when objtool is enabled and none of the supported options
are triggered, kernel build errors out with the below error:
error: objtool: At least one command required.
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
Then, I think CONFIG_OBJTOOL should be disabled.</pre>
</blockquote>
<font face="monospace">A subsequent patch introduces --ftr-fixup as
an option to objtool to do feature fixup at build-time via
CONFIG_HAVE_OBJTOOL_FTR_FIXUP option. If CONFIG_OBJTOOL is not
selected, then objtool cannot be used to pass --ftr-fixup option.<br>
</font>
<p><font face="monospace">In cases where none of the supported
options (like --mcount on powerpc for example) is triggered, but
still require --ftr-fixup option to be passed to objtool, we see
"error: objtool: At least one command required" errors. So, to
address this, run only when either of the config options are
selected.</font><span style="white-space: pre-wrap">
</span></p>
<span style="white-space: pre-wrap">
</span><font face="monospace">Thanks,<br>
Sathvika</font><br>
</body>
</html>