<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<pre>Hi Leon,
Thanks for the ack.
</pre>
<div class="moz-cite-prefix">On 1/4/2023 12:16 PM, Leon Romanovsky
wrote:<br>
</div>
<blockquote type="cite" cite="mid:Y7Ug3F6AIhaAiqCD@unreal">
<pre class="moz-quote-pre" wrap="">On Wed, Jan 04, 2023 at 10:27:33AM +0530, Rajat Khandelwal wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">Hi Bjorn,
Thanks for the acknowledgement.
On 1/4/2023 12:44 AM, Bjorn Helgaas wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">[+cc Paul, Sasha, Leon, Frederick]
(Please cc folks who have commented on previous versions of your
patch.)
On Tue, Jan 03, 2023 at 10:25:48PM +0530, Rajat Khandelwal wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">There are many instances where correctable errors tend to inundate
the message buffer. We observe such instances during thunderbolt PCIe
tunneling.
</pre>
</blockquote>
</blockquote>
</blockquote>
<pre class="moz-quote-pre" wrap="">
<...>
</pre>
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">[54982.838808] igc 0000:2b:00.0: device [8086:5502] error status/mask=00001000/00002000
[54982.838817] igc 0000:2b:00.0: [12] Timeout
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">Please remove the timestamps; they don't contribute to understanding
the problem.
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
--> Sure.
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
Please don't add "-->" or any marker to replies. It breaks mail color
scheme.
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">This gets repeated continuously, thus inundating the buffer.
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">Did you verify that we actually clear the Correctable Error Status
register?
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
--> This patch targets only rate limiting the correctable errors since they are
non-fatal, and they kind of inundate the CPU logs, particularly during thunderbolt
connections. It doesn't have an impact anywhere else.
As per your suggestion in the igc patch, I found rate limiting as a doable option
currently. Have eradicated any kind of masking the bits.
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
You didn't answer on the asked question. "Did you verify that we actually clear
the Correctable Error Status register?".</pre>
</blockquote>
<pre>Yes, I have verified. The status is cleared successfully.
</pre>
<blockquote type="cite" cite="mid:Y7Ug3F6AIhaAiqCD@unreal">
<pre class="moz-quote-pre" wrap="">
Thanks
</pre>
</blockquote>
</body>
</html>