<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, May 26, 2022 at 9:18 AM zhangqilong <<a href="mailto:zhangqilong3@huawei.com">zhangqilong3@huawei.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Add missing pm_runtime_disable() when probe error out. It could<br>
avoid pm_runtime implementation complains when removing and probing<br>
again the driver.<br>
<br>
Fix:c590fa80b3928 ("ASoC: fsl_xcvr: register platform component before registering cpu dai")<br>
Signed-off-by: Zhang Qilong <<a href="mailto:zhangqilong3@huawei.com" target="_blank">zhangqilong3@huawei.com</a>><br>
---<br>
 sound/soc/fsl/fsl_xcvr.c | 2 ++<br>
 1 file changed, 2 insertions(+)<br>
<br>
diff --git a/sound/soc/fsl/fsl_xcvr.c b/sound/soc/fsl/fsl_xcvr.c<br>
index d0556c79fdb1..907435efe121 100644<br>
--- a/sound/soc/fsl/fsl_xcvr.c<br>
+++ b/sound/soc/fsl/fsl_xcvr.c<br>
@@ -1228,6 +1228,7 @@ static int fsl_xcvr_probe(struct platform_device *pdev)<br>
         */<br>
        ret = devm_snd_dmaengine_pcm_register(dev, NULL, 0);<br>
        if (ret) {<br>
+               pm_runtime_disable(dev);<br>
                dev_err(dev, "failed to pcm register\n");<br>
                return ret;<br>
        }<br>
@@ -1235,6 +1236,7 @@ static int fsl_xcvr_probe(struct platform_device *pdev)<br>
        ret = devm_snd_soc_register_component(dev, &fsl_xcvr_comp,<br>
                                              &fsl_xcvr_dai, 1);<br>
        if (ret) {<br>
+               pm_runtime_disable(dev);<br>
                dev_err(dev, "failed to register component %s\n",<br>
                        <a href="http://fsl_xcvr_comp.name" rel="noreferrer" target="_blank">fsl_xcvr_comp.name</a>);<br>
        }<br><br></blockquote><div>Could you please also help add remove() function and add pm_runtime_disable()</div><div>in the remove()?</div><div>Thanks.</div><div><br></div><div>best regards</div><div>wang shengjiu</div></div></div>