<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p><font face="monospace">Hi Peter, </font><br>
</p>
<div class="moz-cite-prefix"><font face="monospace">On 25/05/22
01:20, Peter Zijlstra wrote:</font><br>
</div>
<blockquote type="cite"
cite="mid:Yo03Flwa1s+o6wda@hirez.programming.kicks-ass.net">
<pre class="moz-quote-pre" wrap="">On Tue, May 24, 2022 at 06:59:50PM +0000, Christophe Leroy wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">
Le 24/05/2022 à 20:02, Peter Zijlstra a écrit :
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">On Tue, May 24, 2022 at 08:01:39PM +0200, Peter Zijlstra wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">On Tue, May 24, 2022 at 03:17:45PM +0200, Christophe Leroy wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">From: Sathvika Vasireddy <a class="moz-txt-link-rfc2396E" href="mailto:sv@linux.ibm.com"><sv@linux.ibm.com></a>
This patch makes sure objtool runs only on the object files
that have ftrace enabled, instead of running on all the object
files.
Signed-off-by: Naveen N. Rao <a class="moz-txt-link-rfc2396E" href="mailto:naveen.n.rao@linux.vnet.ibm.com"><naveen.n.rao@linux.vnet.ibm.com></a>
Signed-off-by: Sathvika Vasireddy <a class="moz-txt-link-rfc2396E" href="mailto:sv@linux.ibm.com"><sv@linux.ibm.com></a>
Signed-off-by: Christophe Leroy <a class="moz-txt-link-rfc2396E" href="mailto:christophe.leroy@csgroup.eu"><christophe.leroy@csgroup.eu></a>
---
scripts/Makefile.build | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/Makefile.build b/scripts/Makefile.build
index 2e0c3f9c1459..06ceffd92921 100644
--- a/scripts/Makefile.build
+++ b/scripts/Makefile.build
@@ -258,8 +258,8 @@ else
# 'OBJECT_FILES_NON_STANDARD_foo.o := 'y': skip objtool checking for a file
# 'OBJECT_FILES_NON_STANDARD_foo.o := 'n': override directory skip for a file
-$(obj)/%.o: objtool-enabled = $(if $(filter-out y%, \
- $(OBJECT_FILES_NON_STANDARD_$(basetarget).o)$(OBJECT_FILES_NON_STANDARD)n),y)
+$(obj)/%.o: objtool-enabled = $(and $(if $(filter-out y%, $(OBJECT_FILES_NON_STANDARD_$(basetarget).o)$(OBJECT_FILES_NON_STANDARD)n),y), \
+ $(if $(findstring $(strip $(CC_FLAGS_FTRACE)),$(_c_flags)),y),y)
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
I think this breaks x86, quite a bit of files have ftrace disabled but
very much must run objtool anyway.
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
Also; since the Changelog gives 0 clue as to what problem it's trying to
solve, I can't suggest anything.
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
I asked Sathvika on the previous series, see
<a class="moz-txt-link-freetext" href="https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20220523175548.922671-3-sv@linux.ibm.com/">https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20220523175548.922671-3-sv@linux.ibm.com/</a>
He says it is to solve the problem I reported at
<a class="moz-txt-link-freetext" href="https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20220318105140.43914-4-sv@linux.ibm.com/#2861128">https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20220318105140.43914-4-sv@linux.ibm.com/#2861128</a>
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
So on x86 we have:
arch/x86/entry/vdso/Makefile:OBJECT_FILES_NON_STANDARD := y
to kill objtool for the whole of the VDSO. When we run objtool on
vmlinux it isn't a problem, because the VDSO ends up as a data section
through linker scripts.
</pre>
</blockquote>
<font face="monospace">Right.. Like you and Christophe mentioned, </font><br>
<font face="monospace">arch/powerpc/kernel/vdso/Makefile:OBJECT_FILES_NON_STANDARD
:= y</font><br>
<font face="monospace">should solve it for powerpc as well. <br>
</font><br>
<br>
<font face="monospace">I'll drop this patch and replace it with the
above change as part of next</font><br>
<font face="monospace">revision series. <br>
</font><font face="monospace"><br>
</font><br>
<font face="monospace">Thanks for reviewing! <br>
</font><br>
<font face="monospace"><br>
</font><br>
<font face="monospace">- Sathvika</font><br>
<div class="c-message_actions__container c-message__actions"
role="group" style="box-sizing: inherit; display: inline-flex;
position: absolute; right: 17px; top: -16px; z-index: 1; color:
rgb(29, 28, 29); font-family: Slack-Lato, Slack-Fractions,
appleLogo, sans-serif; font-size: 15px; font-style: normal;
font-variant-ligatures: common-ligatures; font-variant-caps:
normal; font-weight: 400; letter-spacing: normal; orphans: 2;
text-align: start; text-indent: 0px; text-transform: none;
white-space: normal; widows: 2; word-spacing: 0px;
-webkit-text-stroke-width: 0px; background-color: rgb(248, 248,
248); text-decoration-thickness: initial; text-decoration-style:
initial; text-decoration-color: initial;">
<div class="c-message_actions__group" role="group"
aria-label="Message shortcuts" data-qa="message-actions"
style="box-sizing: inherit;
--saf-0:rgba(var(--sk_foreground_low,29,28,29),0.13);
background: rgba(var(--sk_primary_background,255,255,255),1);
border: unset; border-radius: 0.375em; box-shadow: 0 0 0 1px
var(--saf-0),0 1px 3px 0 #00000014; display: flex; line-height:
1; margin-left: 8px; padding: 2px;"><button
class="c-button-unstyled c-icon_button c-icon_button--light
c-icon_button--size_small c-message_actions__button"
aria-label="Add reaction" aria-haspopup="true"
data-qa="add_reaction_action" data-focus-key="message_actions"
data-focus-metadata="{"button":"reaction","channelId":"D028LG8V275","ts":"1653474154.964119","messageContainerType":"message-pane"}"
data-sk="tooltip_parent" type="button" tabindex="-1"
data-remove-tab-index="true" style="box-sizing: inherit;
padding: 0px; background: none; border: 0px; cursor: pointer;
font: inherit; color:
rgba(var(--sk_foreground_max,29,28,29),0.7); margin: 0px;
overflow: initial; text-align: initial; vertical-align:
initial; align-items: center; border-radius: 4px; display:
inline-flex; justify-content: center; position: relative;
height: 32px; width: 32px;"><br
class="Apple-interchange-newline">
<br>
</button></div>
</div>
</body>
</html>