<html dir="ltr"><head></head><body style="text-align:left; direction:ltr;"><div><br></div><div><br></div><div>-----Original Message-----</div><div><b>From</b>: Athira Rajeev <<a href="mailto:Athira%20Rajeev%20%3catrajeev@linux.vnet.ibm.com%3e">atrajeev@linux.vnet.ibm.com</a>></div><div><b>To</b>: <a href="mailto:acme@kernel.org">acme@kernel.org</a>, <a href="mailto:jolsa@kernel.org">jolsa@kernel.org</a>, <a href="mailto:disgoel@linux.vnet.ibm.com">disgoel@linux.vnet.ibm.com</a></div><div><b>Cc</b>: <a href="mailto:mpe@ellerman.id.au">mpe@ellerman.id.au</a>, <a href="mailto:linux-perf-users@vger.kernel.org">linux-perf-users@vger.kernel.org</a>, <a href="mailto:linuxppc-dev@lists.ozlabs.org">linuxppc-dev@lists.ozlabs.org</a>, <a href="mailto:maddy@linux.vnet.ibm.com">maddy@linux.vnet.ibm.com</a>, <a href="mailto:rnsastry@linux.ibm.com">rnsastry@linux.ibm.com</a>, <a href="mailto:kjain@linux.ibm.com">kjain@linux.ibm.com</a>, <a href="mailto:irogers@google.com">irogers@google.com</a></div><div><b>Subject</b>: [PATCH V2 0/2] Fix session topology test for powerpc and add utility function to get cpuinfo entries</div><div><b>Date</b>: Thu, 5 May 2022 15:09:58 +0530</div><div><br></div><pre>The session topology test fails in powerpc pSeries platform.</pre><pre>Test logs:</pre><pre><<>></pre><pre>Session topology : FAILED!</pre><pre><<>></pre><pre><br></pre><pre>This test uses cpu topology information and in powerpc,</pre><pre>some of the topology info is restricted in environment</pre><pre>like virtualized platform. Hence this test needs to be</pre><pre>skipped in pSeries platform for powerpc. The information</pre><pre>about platform is available in /proc/cpuinfo.</pre><pre><br></pre><pre>Patch 1 adds generic utility function in "util/header.c"</pre><pre>to read /proc/cpuinfo for any entry. Though the testcase</pre><pre>fix needs value from "platform" entry, making this as a</pre><pre>generic function to return value for any entry from the</pre><pre>/proc/cpuinfo file which can be used commonly in future</pre><pre>usecases.</pre><pre><br></pre><pre>Patch 2 uses the newly added utility function to look for</pre><pre>platform and skip the test in pSeries platform for powerpc.</pre><pre><br></pre><pre>Athira Rajeev (2):</pre><pre> tools/perf: Add utility function to read /proc/cpuinfo for any field</pre><pre> tools/perf/tests: Fix session topology test to skip the test in guest</pre><pre> environment</pre><pre><br></pre><pre>Changelog:</pre><pre> V1 -> v2:</pre><pre> Addressed review comments from Kajol.</pre><pre> Use "strim" to remove space from string. Also</pre><pre> use "feof" to check for EOF instead of using new</pre><pre> variable "ret".</pre><pre><br></pre><pre><pre style="caret-color: rgb(0, 0, 0); color: rgb(0, 0, 0);">Tested the patches on powervm and powernv, verified perf test session topology test with the patch set.</pre><pre style="caret-color: rgb(0, 0, 0); color: rgb(0, 0, 0);">Tested-by: Disha Goel <<a href="mailto:disgoel@linux.vnet.ibm.com"></a><a href="mailto:disgoel@linux.vnet.ibm.com">disgoel@linux.vnet.ibm.com</a>></pre><pre style="caret-color: rgb(0, 0, 0); color: rgb(0, 0, 0);"><br></pre></pre><pre> tools/perf/tests/topology.c | 17 ++++++++++++</pre><pre> tools/perf/util/header.c | 53 +++++++++++++++++++++++++++++++++++++</pre><pre> tools/perf/util/header.h | 1 +</pre><pre> 3 files changed, 71 insertions(+)</pre><pre><br></pre></body></html>