<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
<html>
<body>
<div dir="auto">
<div dir="auto"><br></div><div dir="auto"><br></div>
<div id="aqm-original" style="color: black;">
<div dir="auto">On 11 May 2021 21:24:55 Segher Boessenkool <segher@kernel.crashing.org> wrote:</div>
<div><br></div>
<blockquote type="cite" class="gmail_quote" style="margin: 0 0 0 0.75ex; border-left: 1px solid #808080; padding-left: 0.75ex;">
<div dir="auto">Hi!</div>
<div dir="auto"><br></div>
<div dir="auto">On Tue, May 11, 2021 at 02:48:12PM +1000, Alexey Kardashevskiy wrote:</div>
<blockquote type="cite" class="gmail_quote" style="margin: 0 0 0 0.75ex; border-left: 1px solid #0099CC; padding-left: 0.75ex;">
<div dir="auto">--- a/arch/powerpc/kernel/vdso32/Makefile</div>
<div dir="auto">+++ b/arch/powerpc/kernel/vdso32/Makefile</div>
<div dir="auto">@@ -44,7 +44,7 @@ asflags-y := -D__VDSO32__ -s</div>
<div dir="auto"><br></div>
<div dir="auto">obj-y += vdso32_wrapper.o</div>
<div dir="auto">targets += vdso32.lds</div>
<div dir="auto">-CPPFLAGS_vdso32.lds += -P -C -Upowerpc</div>
<div dir="auto">+CPPFLAGS_vdso32.lds += -C</div>
<div dir="auto"><br></div>
<div dir="auto"># link rule for the .so file, .lds has to be first</div>
<div dir="auto">$(obj)/vdso32.so.dbg: $(src)/vdso32.lds $(obj-vdso32) $(obj)/vgettimeofday.o FORCE</div>
</blockquote>
<div dir="auto"><br></div>
<blockquote type="cite" class="gmail_quote" style="margin: 0 0 0 0.75ex; border-left: 1px solid #0099CC; padding-left: 0.75ex;">
<div dir="auto">--- a/arch/powerpc/kernel/vdso64/Makefile</div>
<div dir="auto">+++ b/arch/powerpc/kernel/vdso64/Makefile</div>
<div dir="auto">@@ -30,7 +30,7 @@ ccflags-y := -shared -fno-common -fno-builtin -nostdlib \</div>
<div dir="auto">asflags-y := -D__VDSO64__ -s</div>
<div dir="auto"><br></div>
<div dir="auto">targets += vdso64.lds</div>
<div dir="auto">-CPPFLAGS_vdso64.lds += -P -C -U$(ARCH)</div>
<div dir="auto">+CPPFLAGS_vdso64.lds += -C</div>
<div dir="auto"><br></div>
<div dir="auto"># link rule for the .so file, .lds has to be first</div>
<div dir="auto">$(obj)/vdso64.so.dbg: $(src)/vdso64.lds $(obj-vdso64) $(obj)/vgettimeofday.o FORCE</div>
</blockquote>
<div dir="auto"><br></div>
<div dir="auto">Why are you removing -P and -Upowerpc here? "powerpc" is a predefined</div>
<div dir="auto">macro on powerpc-linux (no underscores or anything, just the bareword).</div>
<div dir="auto">This is historical, like "unix" and "linux". If you use the C</div>
<div dir="auto">preprocessor for things that are not C code (like the kernel does here)</div>
<div dir="auto">you need to undefine these macros, if anything in the files you run</div>
<div dir="auto">through the preprocessor contains those words, or funny / strange / bad</div>
<div dir="auto">things will happen. Presumably at some time in the past it did contain</div>
<div dir="auto">"powerpc" somewhere.</div>
<div dir="auto"><br></div>
<div dir="auto">-P is to inhibit line number output. Whatever consumes the</div>
<div dir="auto">preprocessor output will have to handle line directives if you remove</div>
<div dir="auto">this flag. Did you check if this will work for everything that uses</div>
<div dir="auto">$(CPP)?</div></blockquote></div><div dir="auto"><br></div><div dir="auto">i don't know about everything for sure but i checked few configs and in all cases (except vdso) $CPP was receiving cflags.</div><div dir="auto"><br></div><div id="aqm-original" style="color: black;" dir="auto"><blockquote type="cite" class="gmail_quote" style="margin: 0 0 0 0.75ex; border-left: 1px solid #808080; padding-left: 0.75ex;"><div dir="auto"></div>
<div dir="auto"><br></div>
<div dir="auto">In any case, please mention the reasoning (and the fact that you are</div>
<div dir="auto">removing these flags!) in the commit message. Thanks!</div></blockquote></div><div dir="auto"><br></div><div dir="auto"><br></div><div dir="auto">but i did mention this, the last paragraph... they are duplicated.</div><div dir="auto"><br></div><div id="aqm-original" style="color: black;" dir="auto"><blockquote type="cite" class="gmail_quote" style="margin: 0 0 0 0.75ex; border-left: 1px solid #808080; padding-left: 0.75ex;"><div dir="auto"></div>
<div dir="auto"><br></div>
<div dir="auto"><br></div>
<div dir="auto">Segher</div>
</blockquote>
</div><div dir="auto"><br></div>
</div></body>
</html>