<html><head></head><body dir="auto" style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;"><div class="ApplePlainTextBody"><br><br><blockquote type="cite">On Aug 25, 2020, at 10:08 AM, David Miller <davem@davemloft.net> wrote:<br><br>From: Dany Madden <drt@linux.ibm.com><br>Date: Tue, 25 Aug 2020 12:56:06 -0400<br><br><blockquote type="cite">@@ -2011,7 +2017,10 @@ static int do_reset(struct ibmvnic_adapter *adapter,<br><span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span> adapter->req_rx_add_entries_per_subcrq !=<br><span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span> old_num_rx_slots ||<br><span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span> adapter->req_tx_entries_per_subcrq !=<br>-<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span> old_num_tx_slots) {<br>+<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span> old_num_tx_slots ||<br>+<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>!adapter->rx_pool ||<br>+<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>!adapter->tso_pool ||<br>+<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>!adapter->tx_pool) {<br></blockquote><br>Please don't over indent these new lines, indent them identically as the<br>lines above where you are adding new conditions.<br><br>Thank you.<br></blockquote><br><br>Okay, good catch. thanks!<br><br>Mingming</div></body></html>