<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On 08-Jul-2020, at 4:45 PM, Michael Ellerman <<a href="mailto:mpe@ellerman.id.au" class="">mpe@ellerman.id.au</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">Athira Rajeev <</span><a href="mailto:atrajeev@linux.vnet.ibm.com" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">atrajeev@linux.vnet.ibm.com</a><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">> writes:</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">From: Madhavan Srinivasan <<a href="mailto:maddy@linux.ibm.com" class="">maddy@linux.ibm.com</a>><br class=""><br class="">Add power10 feature function to dt_cpu_ftrs.c along<br class="">with a power10 specific init() to initialize pmu sprs.<br class=""><br class="">Signed-off-by: Madhavan Srinivasan <<a href="mailto:maddy@linux.ibm.com" class="">maddy@linux.ibm.com</a>><br class="">---<br class="">arch/powerpc/include/asm/reg.h | 3 +++<br class="">arch/powerpc/kernel/cpu_setup_power.S | 7 +++++++<br class="">arch/powerpc/kernel/dt_cpu_ftrs.c | 26 ++++++++++++++++++++++++++<br class="">3 files changed, 36 insertions(+)<br class=""><br class="">diff --git a/arch/powerpc/include/asm/reg.h b/arch/powerpc/include/asm/reg.h<br class="">index 21a1b2d..900ada1 100644<br class="">--- a/arch/powerpc/include/asm/reg.h<br class="">+++ b/arch/powerpc/include/asm/reg.h<br class="">@@ -1068,6 +1068,9 @@<br class="">#define MMCR0_PMC2_LOADMISSTIME<span class="Apple-tab-span" style="white-space: pre;"> </span>0x5<br class="">#endif<br class=""><br class="">+/* BHRB disable bit for PowerISA v3.10 */<br class="">+#define MMCRA_BHRB_DISABLE<span class="Apple-tab-span" style="white-space: pre;"> </span>0x0000002000000000<br class="">+<br class="">/*<br class=""> * SPRG usage:<br class=""> *<br class="">diff --git a/arch/powerpc/kernel/cpu_setup_power.S b/arch/powerpc/kernel/cpu_setup_power.S<br class="">index efdcfa7..e8b3370c 100644<br class="">--- a/arch/powerpc/kernel/cpu_setup_power.S<br class="">+++ b/arch/powerpc/kernel/cpu_setup_power.S<br class="">@@ -233,3 +233,10 @@ __init_PMU_ISA207:<br class=""><span class="Apple-tab-span" style="white-space: pre;"> </span>li<span class="Apple-tab-span" style="white-space: pre;"> </span>r5,0<br class=""><span class="Apple-tab-span" style="white-space: pre;"> </span>mtspr<span class="Apple-tab-span" style="white-space: pre;"> </span>SPRN_MMCRS,r5<br class=""><span class="Apple-tab-span" style="white-space: pre;"> </span>blr<br class="">+<br class="">+__init_PMU_ISA31:<br class="">+<span class="Apple-tab-span" style="white-space: pre;"> </span>li<span class="Apple-tab-span" style="white-space: pre;"> </span>r5,0<br class="">+<span class="Apple-tab-span" style="white-space: pre;"> </span>mtspr<span class="Apple-tab-span" style="white-space: pre;"> </span>SPRN_MMCR3,r5<br class="">+<span class="Apple-tab-span" style="white-space: pre;"> </span>LOAD_REG_IMMEDIATE(r5, MMCRA_BHRB_DISABLE)<br class="">+<span class="Apple-tab-span" style="white-space: pre;"> </span>mtspr<span class="Apple-tab-span" style="white-space: pre;"> </span>SPRN_MMCRA,r5<br class="">+<span class="Apple-tab-span" style="white-space: pre;"> </span>blr<br class=""></blockquote><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">This doesn't seem like it belongs in this patch. It's not called?</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""></div></blockquote><div><br class=""></div>Yes, you are right, this needs to be called from `__setup_cpu_power10`.</div><div>Since we didn’t had setup part for power10 in the tree initially, missed it.</div><div>I will include this update in V3 </div><div><br class=""></div><div>Thanks</div><div>Athira<br class=""><blockquote type="cite" class=""><div class=""><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">cheers</span></div></blockquote></div><br class=""></body></html>