<html><body><p><tt><font size="2">"Linuxppc-dev" <linuxppc-dev-bounces+hbabu=us.ibm.com@lists.ozlabs.org> wrote on 11/27/2019 12:28:10 AM:</font></tt><br><tt><font size="2">> <br>> On Tue, Nov 26, 2019 at 05:03:27PM -0800, Haren Myneni wrote:<br>> > <br>> > This reverts commit 452d23c0f6bd97f2fd8a9691fee79b76040a0feb.<br>> > <br>> > User space send windows (NX GZIP compression) need vas_win_paste_addr()<br>> > to mmap window paste address and vas_win_id() to get window ID when<br>> > window address is given.<br>> <br>> Even with your full series applied vas_win_paste_addr is entirely<br>> unused, and vas_win_id is only used once in the same file it is defined.</font></tt><br><br><tt><font size="2">Thanks for the review. </font></tt><br><tt><font size="2">vas_win_paste_addr() will be used in NX compression driver and planning to post this series soon. Can I add this change later as part of this series? </font></tt><br><tt><font size="2"><br>> <br>> So instead of this patch you should just open code vas_win_id in<br>> init_winctx_for_txwin.<br>> <br>> > +static inline u32 encode_pswid(int vasid, int winid)<br>> > +{<br>> > + u32 pswid = 0;<br>> > +<br>> > + pswid |= vasid << (31 - 7);<br>> > + pswid |= winid;<br>> > +<br>> > + return pswid;<br>> <br>> This can be simplified down to:<br>> <br>> return (u32)winid | (vasid << (31 - 7));<br>> <br></font></tt><BR>
</body></html>