<html><body><p><tt><font size="2">"Linuxppc-dev" <linuxppc-dev-bounces+hbabu=us.ibm.com@lists.ozlabs.org> wrote on 11/27/2019 12:30:55 AM:<br></font></tt><br><tt><font size="2">> <br>> > +#define crb_csb_addr(c) __be64_to_cpu(c->csb_addr)<br>> > +#define crb_nx_fault_addr(c) __be64_to_cpu<br>> (c->stamp.nx.fault_storage_addr)<br>> > +#define crb_nx_flags(c) c->stamp.nx.flags<br>> > +#define crb_nx_fault_status(c) c->stamp.nx.fault_status<br>> <br>> Except for crb_nx_fault_addr all these macros are unused, and<br>> crb_nx_fault_addr probably makes more sense open coded in the only<br>> caller.</font></tt><br><br><tt><font size="2">Thanks, My mistake, code got changed and forgot to remove unused macros. </font></tt><br><tt><font size="2"><br>> <br>> Also please don't use the __ prefixed byte swap helpers in any driver<br>> or arch code.<br>> <br>> > +<br>> > +static inline uint32_t crb_nx_pswid(struct coprocessor_request_block *crb)<br>> > +{<br>> > + return __be32_to_cpu(crb->stamp.nx.pswid);<br>> > +}<br>> <br>> Same here. Also not sure what the point of the helper is except for<br>> obsfucating the code.<br>> <br></font></tt><BR>
</body></html>