<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>Hi,<br>
</p>
<div class="moz-cite-prefix">On 5/21/19 5:18 PM, Michael Ellerman
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:87sgt86na9.fsf@concordia.ellerman.id.au">
<pre class="moz-quote-pre" wrap="">Anju T Sudhakar <a class="moz-txt-link-rfc2396E" href="mailto:anju@linux.vnet.ibm.com"><anju@linux.vnet.ibm.com></a> writes:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">Currently init_imc_pmu() can be failed either because
an IMC unit with invalid domain(i.e an IMC node not
supported by the kernel) is attempted a pmu-registration
or something went wrong while registering a valid IMC unit.
In both the cases kernel provides a 'Registration failed'
error message.
Example:
Log message, when trace-imc node is not supported by the kernel, and the
skiboot supports trace-imc node.
So for kernel, trace-imc node is now an unknown domain.
[ 1.731870] nest_phb5_imc performance monitor hardware support registered
[ 1.731944] nest_powerbus0_imc performance monitor hardware support registered
[ 1.734458] thread_imc performance monitor hardware support registered
[ 1.734460] IMC Unknown Device type
[ 1.734462] IMC PMU (null) Register failed
[ 1.734558] nest_xlink0_imc performance monitor hardware support registered
[ 1.734614] nest_xlink1_imc performance monitor hardware support registered
[ 1.734670] nest_xlink2_imc performance monitor hardware support registered
[ 1.747043] Initialise system trusted keyrings
[ 1.747054] Key type blacklist registered
To avoid ambiguity on the error message, return for invalid domain
before attempting a pmu registration.
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
What do we print once the patch is applied?
</pre>
</blockquote>
<p><br>
</p>
<p>Once the patch is applied, we return for invalid domains. so we
will only have <br>
</p>
<p>`<i>IMC Unknown Device type</i>` message printed for <b>unknown
domains</b>.</p>
<p>And `<i>IMC PMU (null) Register failed</i>` message will appear
only if the <br>
</p>
<p>registration fails for a <b>known domain</b>.</p>
<p><br>
</p>
<p><br>
</p>
<p>Thanks,</p>
<p>Anju<br>
</p>
<br>
</body>
</html>