<html><head></head><body><div style="font-family:Helvetica Neue, Helvetica, Arial, sans-serif;font-size:13px;"><div></div>
<div>unscribed me <br></div><div><br></div>
<div class="yahoo_quoted" id="yahoo_quoted_2267153160">
<div style="font-family:'Helvetica Neue', Helvetica, Arial, sans-serif;font-size:13px;color:#26282a;">
<div>
On Tuesday, March 27, 2018 05:34:30 AM PDT, Michael Ellerman <mpe@ellerman.id.au> wrote:
</div>
<div><br></div>
<div><br></div>
<div><div dir="ltr">Nicholas Piggin <<a href="mailto:npiggin@gmail.com" ymailto="mailto:npiggin@gmail.com">npiggin@gmail.com</a>> writes:<br></div><div dir="ltr"><br></div><div dir="ltr">> opal_nvram_write currently just assumes success if it encounters an<br></div><div dir="ltr">> error other than OPAL_BUSY or OPAL_BUSY_EVENT. Have it return -EIO<br></div><div dir="ltr">> on other errors instead.<br></div><div dir="ltr"><br></div><div dir="ltr">Does that ever happen with current skiboot?<br></div><div dir="ltr"><br></div><div dir="ltr">Even if it doesn't I think I'm inclined to tag this for stable.<br></div><div dir="ltr"><br></div><div dir="ltr">cheers<br></div><div dir="ltr"><br></div><div dir="ltr">> diff --git a/arch/powerpc/platforms/powernv/opal-nvram.c b/arch/powerpc/platforms/powernv/opal-nvram.c<br></div><div dir="ltr">> index 9db4398ded5d..13bf625dc3e8 100644<br></div><div dir="ltr">> --- a/arch/powerpc/platforms/powernv/opal-nvram.c<br></div><div dir="ltr">> +++ b/arch/powerpc/platforms/powernv/opal-nvram.c<br></div><div dir="ltr">> @@ -59,6 +59,8 @@ static ssize_t opal_nvram_write(char *buf, size_t count, loff_t *index)<br></div><div dir="ltr">> if (rc == OPAL_BUSY_EVENT)<br></div><div dir="ltr">> opal_poll_events(NULL);<br></div><div dir="ltr">> }<br></div><div dir="ltr">> + if (rc)<br></div><div dir="ltr">> + return -EIO;<br></div><div dir="ltr">> *index += count;<br></div><div dir="ltr">> return count;<br></div><div dir="ltr">> }<br></div><div dir="ltr">> -- <br></div><div dir="ltr">> 2.16.1<br></div></div>
</div>
</div></div></body></html>